From patchwork Thu Aug 19 23:34:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Schmidt X-Patchwork-Id: 62222 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6B57FB6EE8 for ; Fri, 20 Aug 2010 09:34:39 +1000 (EST) Received: (qmail 10175 invoked by alias); 19 Aug 2010 23:34:37 -0000 Received: (qmail 10163 invoked by uid 22791); 19 Aug 2010 23:34:35 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 23:34:30 +0000 Received: (qmail 20977 invoked from network); 19 Aug 2010 23:34:28 -0000 Received: from unknown (HELO ?84.152.187.120?) (bernds@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Aug 2010 23:34:28 -0000 Message-ID: <4C6DBF84.2020702@codesourcery.com> Date: Fri, 20 Aug 2010 01:34:28 +0200 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.7) Gecko/20100724 Thunderbird/3.1.1 MIME-Version: 1.0 To: "H.J. Lu" CC: Eric Botcazou , gcc-patches@gcc.gnu.org, Mark Mitchell , Richard Guenther , David Daney , Andi Kleen , Steven Bosscher Subject: Re: Combine four insns References: <4C5C20D0.5020105@codesourcery.com> <201008182241.16369.ebotcazou@adacore.com> <4C6C55AF.1090705@codesourcery.com> <201008190938.07217.ebotcazou@adacore.com> <4C6D6BEC.1020700@codesourcery.com> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 08/20/2010 12:53 AM, H.J. Lu wrote: > This may have caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45350 Hmm. FIND_REG_INC_NOTE expands to 0 on i686, so it didn't show up there. Anyway, both the set and the use are conditional on i1 != NULL, so I've committed the following after a bootstrap. Bernd Index: ChangeLog =================================================================== --- ChangeLog (revision 163388) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2010-08-19 Bernd Schmidt + + PR bootstrap/45350 + * combine.c (try_combine): Initialize i1_is_used and i2_is_used. Fix + a comment. + 2010-08-19 Nathan Froyd * target.def (function_arg, function_incoming_arg): Remove const Index: combine.c =================================================================== --- combine.c (revision 163383) +++ combine.c (working copy) @@ -2511,7 +2511,7 @@ try_combine (rtx i3, rtx i2, rtx i1, rtx /* Total number of SETs to put into I3. */ int total_sets; /* Nonzero if I2's or I1's body now appears in I3. */ - int i2_is_used, i1_is_used; + int i2_is_used = 0, i1_is_used = 0; /* INSN_CODEs for new I3, new I2, and user of condition code. */ int insn_code_number, i2_code_number = 0, other_code_number = 0; /* Contains I3 if the destination of I3 is used in its source, which means @@ -2546,8 +2546,8 @@ try_combine (rtx i3, rtx i2, rtx i1, rtx int i; /* Only try four-insn combinations when there's high likelihood of - success. Look for simple insns, such as loads of constants, unary - operations, or binary operations involving a constant. */ + success. Look for simple insns, such as loads of constants or + binary operations involving a constant. */ if (i0) { int i;