From patchwork Mon Nov 28 09:40:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 699901 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tS1rn6wd0z9vF7 for ; Mon, 28 Nov 2016 20:40:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="KiEk0dER"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:cc:to :from:subject:message-id:date:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=DPWIWkMGHNBygFaN dKyS2oJ1tItzSbPjjXWByoKBNapLqOTB8Z6PyGRgQEH0qUtkju6xUFgUYXXUTLN9 hSCjTGiDRoeqoKuqJwFV2OFhtstk2uL+Q8mct0rRJ+VgZdASRsPrrDZ8uaT4/nVE XUwVOAR4FfN+cw9hveOEX3n94zs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:cc:to :from:subject:message-id:date:mime-version:content-type :content-transfer-encoding; s=default; bh=F3j/CpoMsgCOmEWgpgJGKi Qgtlo=; b=KiEk0dERqEb+kFYHYwzmK8xbJRNXZohmpctO7fo+NTTUIheF1Tpqi3 IBg2o4WF4lTInzrc+ghIgwHHbcyIp03x7CofulQi0kX/YXAcvF/GQkCbj8zn11dy trzvEcLa9hVTX6fKKaSb1F1VE2GsxuUsYhKsz3i2KD4UKgmtK17rc= Received: (qmail 124561 invoked by alias); 28 Nov 2016 09:40:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 123406 invoked by uid 89); 28 Nov 2016 09:40:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_40, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*r:RZmta, H*r:39.9, PLUS, Hx-languages-length:1320 X-HELO: mo4-p00-ob.smtp.rzone.de Received: from mo4-p00-ob.smtp.rzone.de (HELO mo4-p00-ob.smtp.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Nov 2016 09:40:27 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT3ol15ykJcYwR/bcHRirORRW3yMcVao= X-RZG-CLASS-ID: mo00 Received: from [192.168.0.123] (mail.hightec-rt.com [213.135.1.215]) by smtp.strato.de (RZmta 39.9 DYNA|AUTH) with ESMTPSA id 604e9csAS9eNEaJ (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 28 Nov 2016 10:40:23 +0100 (CET) Cc: Denis Chertykov To: gcc-patches From: Georg-Johann Lay Subject: [patch,avr,committed] Small improvement loading 16-bit values. Message-ID: <49764a80-6349-dc2a-1946-cffe34e6a873@gjlay.de> Date: Mon, 28 Nov 2016 10:40:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 X-IsSubscribed: yes http://gcc.gnu.org/r242909 This patch adds treatment of reg_unused_after for *(X+const) that only restores X if X is known to be used. Applied as obvious. Johann * config/avr/avr.c (out_movhi_r_mr) [REG_X + PLUS]: Only SBIW if X is not unused after. Index: config/avr/avr.c =================================================================== --- config/avr/avr.c (revision 242908) +++ config/avr/avr.c (revision 242909) @@ -4028,16 +4028,22 @@ out_movhi_r_mr (rtx_insn *insn, rtx op[] optimization options. */ if (reg_base == REG_X) - return reg_base == reg_dest - ? avr_asm_len ("adiw r26,%o1" CR_TAB - "ld __tmp_reg__,X+" CR_TAB - "ld %B0,X" CR_TAB - "mov %A0,__tmp_reg__", op, plen, -4) + { + if (reg_base == reg_dest) + return avr_asm_len ("adiw r26,%o1" CR_TAB + "ld __tmp_reg__,X+" CR_TAB + "ld %B0,X" CR_TAB + "mov %A0,__tmp_reg__", op, plen, -4); - : avr_asm_len ("adiw r26,%o1" CR_TAB - "ld %A0,X+" CR_TAB - "ld %B0,X" CR_TAB - "sbiw r26,%o1+1", op, plen, -4); + avr_asm_len ("adiw r26,%o1" CR_TAB + "ld %A0,X+" CR_TAB + "ld %B0,X", op, plen, -3); + + if (!reg_unused_after (insn, XEXP (base, 0))) + avr_asm_len ("sbiw r26,%o1+1", op, plen, 1); + + return ""; + } return reg_base == reg_dest ? avr_asm_len ("ldd __tmp_reg__,%A1" CR_TAB