| Message ID | 3a364ab6-9917-e9c7-522d-cd91e901c789@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite,arm] Remove xfail for vect-epilogues test | expand |
On December 11, 2019 12:27:31 PM GMT+01:00, "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com> wrote: >Hi, > >We can now vectorize an epilogue for this loop for arm too, so removing > >xfail. > >Is this OK for trunk? Wasn't entirely sure whether I could commit this >under obvious. Sure. Richard. >gcc/testsuite/ChangeLog: >2019-12-11 Andre Vieira <andre.simoesdiasvieira@arm.com> > > * gcc.dg/vect/vect-epilogues.c: Remove xfail for arm.
On Wed, 11 Dec 2019 at 12:27, Andre Vieira (lists) <andre.simoesdiasvieira@arm.com> wrote: > > Hi, > > We can now vectorize an epilogue for this loop for arm too, so removing > xfail. > > Is this OK for trunk? Wasn't entirely sure whether I could commit this > under obvious. > This fails on armeb :-( > gcc/testsuite/ChangeLog: > 2019-12-11 Andre Vieira <andre.simoesdiasvieira@arm.com> > > * gcc.dg/vect/vect-epilogues.c: Remove xfail for arm.
Yeah didn't test that, thanks.
This OK?
gcc/testsuite/ChangeLog:
2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com>
* gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian.
* lib/target-supports.exp (check_effective_target_arm_big_endian):
New target selector.
On 12/12/2019 16:42, Christophe Lyon wrote:
> On Wed, 11 Dec 2019 at 12:27, Andre Vieira (lists)
> <andre.simoesdiasvieira@arm.com> wrote:
>>
>> Hi,
>>
>> We can now vectorize an epilogue for this loop for arm too, so removing
>> xfail.
>>
>> Is this OK for trunk? Wasn't entirely sure whether I could commit this
>> under obvious.
>>
>
> This fails on armeb :-(
>
>> gcc/testsuite/ChangeLog:
>> 2019-12-11 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>
>> * gcc.dg/vect/vect-epilogues.c: Remove xfail for arm.
Hi Andre, > gcc/testsuite/ChangeLog: > > 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> > > * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. > * lib/target-supports.exp (check_effective_target_arm_big_endian): > New target selector. as always, this needs documenting in sourcebuild.texi. Rainer
Thanks for pointing it out Rainer. Thanks to that reminder I noticed
there is a different way to achieve this without adding that extra
target check.
This OK?
gcc/testsuite/ChangeLog:
2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com>
* gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian.
On 12/12/2019 17:41, Rainer Orth wrote:
> Hi Andre,
>
>> gcc/testsuite/ChangeLog:
>>
>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>
>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian.
>> * lib/target-supports.exp (check_effective_target_arm_big_endian):
>> New target selector.
>
> as always, this needs documenting in sourcebuild.texi.
>
> Rainer
>
Consequently whilst looking at the list I noticed these two were missing.
This OK for trunk?
gcc/ChangeLog:
2019-12-13 Andre Vieira <andre.simoesdiasvieira@arm.com>
* doc/sourcebuild.texi (arm_little_endian, arm_nothumb):
Documented existing target checks.
On 13/12/2019 13:05, Andre Vieira (lists) wrote:
> Thanks for pointing it out Rainer. Thanks to that reminder I noticed
> there is a different way to achieve this without adding that extra
> target check.
>
> This OK?
>
> gcc/testsuite/ChangeLog:
>
> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian.
>
> On 12/12/2019 17:41, Rainer Orth wrote:
>> Hi Andre,
>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>>
>>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian.
>>> * lib/target-supports.exp
>>> (check_effective_target_arm_big_endian):
>>> New target selector.
>>
>> as always, this needs documenting in sourcebuild.texi.
>>
>> Rainer
>>
On Fri, 13 Dec 2019, Andre Vieira (lists) wrote: > Consequently whilst looking at the list I noticed these two were missing. > > This OK for trunk? Yes. Thanks, Richard. > gcc/ChangeLog: > 2019-12-13 Andre Vieira <andre.simoesdiasvieira@arm.com> > > * doc/sourcebuild.texi (arm_little_endian, arm_nothumb): > Documented existing target checks. > > On 13/12/2019 13:05, Andre Vieira (lists) wrote: > > Thanks for pointing it out Rainer. Thanks to that reminder I noticed there > > is a different way to achieve this without adding that extra target check. > > > > This OK? > > > > gcc/testsuite/ChangeLog: > > > > 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> > > > > * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. > > > > On 12/12/2019 17:41, Rainer Orth wrote: > >> Hi Andre, > >> > >>> gcc/testsuite/ChangeLog: > >>> > >>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> > >>> > >>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. > >>> * lib/target-supports.exp > >>> (check_effective_target_arm_big_endian): > >>> New target selector. > >> > >> as always, this needs documenting in sourcebuild.texi. > >> > >> Rainer > >> >
What about the previous patch fixing the existing testism by skipping for big-endian arm using existing target supports? On 07/01/2020 07:31, Richard Biener wrote: > On Fri, 13 Dec 2019, Andre Vieira (lists) wrote: > >> Consequently whilst looking at the list I noticed these two were missing. >> >> This OK for trunk? > > Yes. > > Thanks, > Richard. > >> gcc/ChangeLog: >> 2019-12-13 Andre Vieira <andre.simoesdiasvieira@arm.com> >> >> * doc/sourcebuild.texi (arm_little_endian, arm_nothumb): >> Documented existing target checks. >> >> On 13/12/2019 13:05, Andre Vieira (lists) wrote: >>> Thanks for pointing it out Rainer. Thanks to that reminder I noticed there >>> is a different way to achieve this without adding that extra target check. >>> >>> This OK? >>> >>> gcc/testsuite/ChangeLog: >>> >>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> >>> >>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. >>> >>> On 12/12/2019 17:41, Rainer Orth wrote: >>>> Hi Andre, >>>> >>>>> gcc/testsuite/ChangeLog: >>>>> >>>>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> >>>>> >>>>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. >>>>> * lib/target-supports.exp >>>>> (check_effective_target_arm_big_endian): >>>>> New target selector. >>>> >>>> as always, this needs documenting in sourcebuild.texi. >>>> >>>> Rainer >>>> >> >
On Tue, 7 Jan 2020, Andre Vieira (lists) wrote: > What about the previous patch fixing the existing testism by skipping for > big-endian arm using existing target supports? I thought this was an update containing both - so yes, that's OK as well. Richard. > On 07/01/2020 07:31, Richard Biener wrote: > > On Fri, 13 Dec 2019, Andre Vieira (lists) wrote: > > > >> Consequently whilst looking at the list I noticed these two were missing. > >> > >> This OK for trunk? > > > > Yes. > > > > Thanks, > > Richard. > > > >> gcc/ChangeLog: > >> 2019-12-13 Andre Vieira <andre.simoesdiasvieira@arm.com> > >> > >> * doc/sourcebuild.texi (arm_little_endian, arm_nothumb): > >> Documented existing target checks. > >> > >> On 13/12/2019 13:05, Andre Vieira (lists) wrote: > >>> Thanks for pointing it out Rainer. Thanks to that reminder I noticed there > >>> is a different way to achieve this without adding that extra target check. > >>> > >>> This OK? > >>> > >>> gcc/testsuite/ChangeLog: > >>> > >>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> > >>> > >>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. > >>> > >>> On 12/12/2019 17:41, Rainer Orth wrote: > >>>> Hi Andre, > >>>> > >>>>> gcc/testsuite/ChangeLog: > >>>>> > >>>>> 2019-12-12 Andre Vieira <andre.simoesdiasvieira@arm.com> > >>>>> > >>>>> * gcc.dg/vect/vect-epilogues.c: XFAIL for arm big endian. > >>>>> * lib/target-supports.exp > >>>>> (check_effective_target_arm_big_endian): > >>>>> New target selector. > >>>> > >>>> as always, this needs documenting in sourcebuild.texi. > >>>> > >>>> Rainer > >>>> > >> > > >
diff --git a/gcc/testsuite/gcc.dg/vect/vect-epilogues.c b/gcc/testsuite/gcc.dg/vect/vect-epilogues.c index 946666e918ff9d019f07c0d891a9148692f86c92..de95310a65eed78e1f75c4cd7581f9f7a86afd16 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-epilogues.c +++ b/gcc/testsuite/gcc.dg/vect/vect-epilogues.c @@ -16,4 +16,4 @@ void pixel_avg( unsigned char *dst, int i_dst_stride, } } -/* { dg-final { scan-tree-dump "LOOP EPILOGUE VECTORIZED" "vect" { xfail { arm*-*-* } } } } */ +/* { dg-final { scan-tree-dump "LOOP EPILOGUE VECTORIZED" "vect" } } */
Hi, We can now vectorize an epilogue for this loop for arm too, so removing xfail. Is this OK for trunk? Wasn't entirely sure whether I could commit this under obvious. gcc/testsuite/ChangeLog: 2019-12-11 Andre Vieira <andre.simoesdiasvieira@arm.com> * gcc.dg/vect/vect-epilogues.c: Remove xfail for arm.