From patchwork Sat May 6 07:12:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 759264 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wKg2t1Nlxz9s89 for ; Sat, 6 May 2017 17:13:05 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="vfQ4JhBJ"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=ae1XjB2BRx5DU19twW9eLZ2Qmgtn4U7ap7CyJbb0dD7oFQishx Qqe/QLCoPsePxPh/d7jh6Ry/d4YZSEPQPKhoIo5Mu22/Bs+qLDeFOvcnwqe0oNTR 3Tz44TKjjFIJG3BVAb16mhmNfZ6h6Fei7Gy3sK2YA+Uq47bA5cxI71ERM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=dRSFTuJimrJqKi/QT5v7MzaeTc0=; b=vfQ4JhBJ1Tjh7Oy24nIk h+3lPn5n0PM5yFcXl6glFIeqX1Z72gR6FwL8V3SNHD2Gx6KEJkRuTAaemwt0rbWD dfhyVeOyc2aeBAgZpPAFCJx3EgKG0oNlpwsz9fP0LcTZixUEUsbr0Pxo2/vxrzoZ xvROYfSISCh1xCDaZshQUT0= Received: (qmail 41137 invoked by alias); 6 May 2017 07:12:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 41119 invoked by uid 89); 6 May 2017 07:12:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 06 May 2017 07:12:49 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1d6ttY-0002yc-4D from Tom_deVries@mentor.com ; Sat, 06 May 2017 00:12:48 -0700 Received: from [127.0.0.1] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Sat, 6 May 2017 08:12:43 +0100 To: Jan Hubicka , Uros Bizjak CC: GCC Patches From: Tom de Vries Subject: [patch, testsuite, PR80606] Remove default_packed lines from i386/avx-vtestp{d, s}* Message-ID: <3897685b-a8c5-d226-bfc4-34e3559358f3@mentor.com> Date: Sat, 6 May 2017 09:12:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Hi, The test-cases i386/avx-vtestp{d,s}* contain lines guarded with target default_packed, using absolute line numbers 150 and 164. The absolute line numbers intend to refer to the position of the packed attribute in unions ieee754_float and ieee754_double in m128-check.h, but they do not match the actual lines. The default_packed lines were introduced for netware support in 2009, but netware support was removed in 2011. The line numbers changes from: ... 149 unsigned sign : 1; 150 } bits __attribute__((packed)); 151 }; --- 163 unsigned sign : 1; 164 } bits __attribute__((packed)); 165 }; ... to: ... 149 unsigned long frac : 23; 150 unsigned exp : 8; 151 unsigned sign : 1; -- 163 unsigned long frac0 : 20; 164 unsigned exp : 11; 165 unsigned sign : 1; ... in Jan 2014 in r207150. Apparently nobody noticed when the line numbers changed, so they are effectively unmaintained. This patch removes the unmaintained lines. Tested on x86_64. OK for trunk? Thanks, - Tom Remove default_packed lines from i386/avx-vtestp{d,s}* 2017-05-05 Tom de Vries PR testsuite/80606 * gcc.target/i386/avx-vtestpd-1.c: Remove default_packed lines. * gcc.target/i386/avx-vtestpd-2.c: Same. * gcc.target/i386/avx-vtestpd-256-1.c: Same. * gcc.target/i386/avx-vtestpd-256-2.c: Same. * gcc.target/i386/avx-vtestpd-256-3.c: Same. * gcc.target/i386/avx-vtestpd-3.c: Same. * gcc.target/i386/avx-vtestps-1.c: Same. * gcc.target/i386/avx-vtestps-2.c: Same. * gcc.target/i386/avx-vtestps-256-1.c: Same. * gcc.target/i386/avx-vtestps-256-2.c: Same. * gcc.target/i386/avx-vtestps-256-3.c: Same. * gcc.target/i386/avx-vtestps-3.c: Same. --- gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-1.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-2.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c | 2 -- gcc/testsuite/gcc.target/i386/avx-vtestps-3.c | 2 -- 12 files changed, 24 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c index 6b52d78..a00d3e6 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c index 57dfeeb..f7b6358 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c index 050f140..bed4456 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c index 0954f1d..d29ff79 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c index 8a6e32e..2f76257 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c index 74c5dc8..d7debb5 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c index fb0c802..6064055 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c index 7482dae..97a3a84 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c index 6362c41..2d8dc60 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c index de23ab2..56b1828 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c index 717e5bb..a0286b2 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h" diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c index 61f58a6..23dfe6e 100644 --- a/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c +++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target avx } */ /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */ -/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */ -/* { dg-message " from " "include chain" { target default_packed } 0 } */ #include "avx-check.h"