diff mbox

[testsuite,PR80606] Remove default_packed lines from i386/avx-vtestp{d,s}*

Message ID 3897685b-a8c5-d226-bfc4-34e3559358f3@mentor.com
State New
Headers show

Commit Message

Tom de Vries May 6, 2017, 7:12 a.m. UTC 
Hi,

The test-cases i386/avx-vtestp{d,s}* contain lines guarded with target 
default_packed, using absolute line numbers 150 and 164.  The absolute 
line numbers intend to refer to the position of the packed attribute in 
unions ieee754_float and ieee754_double in m128-check.h, but they do not 
match the actual lines.

The default_packed lines were introduced for netware support in 2009, 
but netware support was removed in 2011.

The line numbers changes from:
...
    149	      unsigned sign : 1;
    150	   } bits __attribute__((packed));
    151	};
--
    163	      unsigned sign : 1;
    164	   } bits __attribute__((packed));
    165	};
...

to:
...
    149	      unsigned long frac : 23;
    150	      unsigned exp : 8;
    151	      unsigned sign : 1;
--
    163	      unsigned long frac0 : 20;
    164	      unsigned exp : 11;
    165	      unsigned sign : 1;
...
in Jan 2014 in r207150.

Apparently nobody noticed when the line numbers changed, so they are 
effectively unmaintained.

This patch removes the unmaintained lines.

Tested on x86_64.

OK for trunk?

Thanks,
- Tom

Comments

Uros Bizjak May 6, 2017, 7:22 a.m. UTC | #1 
On Sat, May 6, 2017 at 9:12 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> Hi,
>
> The test-cases i386/avx-vtestp{d,s}* contain lines guarded with target
> default_packed, using absolute line numbers 150 and 164.  The absolute line
> numbers intend to refer to the position of the packed attribute in unions
> ieee754_float and ieee754_double in m128-check.h, but they do not match the
> actual lines.
>
> The default_packed lines were introduced for netware support in 2009, but
> netware support was removed in 2011.
>
> The line numbers changes from:
> ...
>    149        unsigned sign : 1;
>    150     } bits __attribute__((packed));
>    151  };
> --
>    163        unsigned sign : 1;
>    164     } bits __attribute__((packed));
>    165  };
> ...
>
> to:
> ...
>    149        unsigned long frac : 23;
>    150        unsigned exp : 8;
>    151        unsigned sign : 1;
> --
>    163        unsigned long frac0 : 20;
>    164        unsigned exp : 11;
>    165        unsigned sign : 1;
> ...
> in Jan 2014 in r207150.
>
> Apparently nobody noticed when the line numbers changed, so they are
> effectively unmaintained.
>
> This patch removes the unmaintained lines.
>
> Tested on x86_64.
>
> OK for trunk?

OK.

Thanks,
Uros.
diff mbox

Patch

Remove default_packed lines from i386/avx-vtestp{d,s}*

2017-05-05  Tom de Vries  <tom@codesourcery.com>

	PR testsuite/80606
	* gcc.target/i386/avx-vtestpd-1.c: Remove default_packed lines.
	* gcc.target/i386/avx-vtestpd-2.c: Same.
	* gcc.target/i386/avx-vtestpd-256-1.c: Same.
	* gcc.target/i386/avx-vtestpd-256-2.c: Same.
	* gcc.target/i386/avx-vtestpd-256-3.c: Same.
	* gcc.target/i386/avx-vtestpd-3.c: Same.
	* gcc.target/i386/avx-vtestps-1.c: Same.
	* gcc.target/i386/avx-vtestps-2.c: Same.
	* gcc.target/i386/avx-vtestps-256-1.c: Same.
	* gcc.target/i386/avx-vtestps-256-2.c: Same.
	* gcc.target/i386/avx-vtestps-256-3.c: Same.
	* gcc.target/i386/avx-vtestps-3.c: Same.

---
 gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c     | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c     | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c     | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-1.c     | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-2.c     | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c | 2 --
 gcc/testsuite/gcc.target/i386/avx-vtestps-3.c     | 2 --
 12 files changed, 24 deletions(-)

diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c
index 6b52d78..a00d3e6 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-1.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c
index 57dfeeb..f7b6358 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-2.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c
index 050f140..bed4456 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-1.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c
index 0954f1d..d29ff79 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-2.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c
index 8a6e32e..2f76257 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-256-3.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c
index 74c5dc8..d7debb5 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestpd-3.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_DOUBLE" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 164 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c
index fb0c802..6064055 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-1.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c
index 7482dae..97a3a84 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-2.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c
index 6362c41..2d8dc60 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-1.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c
index de23ab2..56b1828 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-2.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c
index 717e5bb..a0286b2 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-256-3.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c b/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c
index 61f58a6..23dfe6e 100644
--- a/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vtestps-3.c
@@ -1,8 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
 /* { dg-options "-O2 -mavx -DNEED_IEEE754_FLOAT" } */
-/* { dg-warning "attribute ignored" "" { target default_packed } 150 } */
-/* { dg-message " from " "include chain" { target default_packed } 0 } */
 
 #include "avx-check.h"