From patchwork Fri Mar 24 06:34:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 743074 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vqDDd5ltWz9s82 for ; Fri, 24 Mar 2017 17:34:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="lvVw3SOI"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=cH1qNQFGDM7mxCr/A 1Jflu6GRP0m0GkHOaRoSunmxUjCjga9STbbq1cNLaugBj+l7HTVUILGKyaTqwTGb ikbbUvY1Tz3ww8ZA17KYoV27LcQyUq5nwfDlEWcsb1XHTsnaSkpPBNLua2h8T/OX ONIv36COMQlW4QOQN0n/kF8NmQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=jqXZgNinbKF+mIMY/j9SL1/ IKu0=; b=lvVw3SOIupFUUp4vXxkzaqCKldlWlaJIN39fggKTlSG3iUeljRQIId6 zFnZsoSihh/H2/oab4HkLKS6K2jumuu7Rin//Tn9wkTsnBdC89Wu+DvP7KcU/17k 1pLblQ5DUj3itrUAKoPD9+0mzhoFemY5kX9Cp+VG+Oar4LERvUKU= Received: (qmail 56036 invoked by alias); 24 Mar 2017 06:34:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 56005 invoked by uid 89); 24 Mar 2017 06:34:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 06:34:42 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1crIo4-0005sr-AL from Tom_deVries@mentor.com ; Thu, 23 Mar 2017 23:34:40 -0700 Received: from [127.0.0.1] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 24 Mar 2017 06:34:36 +0000 Subject: Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite To: Mike Stump References: <6e0d0f16-6db5-0369-f0dd-90344f5d272e@mentor.com> CC: GCC Patches From: Tom de Vries Message-ID: <336349f0-b973-77c0-c5f5-710240312270@mentor.com> Date: Fri, 24 Mar 2017 07:34:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) On 23/03/17 18:25, Mike Stump wrote: > On Mar 23, 2017, at 8:46 AM, Tom de Vries wrote: >> >> I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: >> ... >> sorry, unimplemented: target cannot support alloca. > > We'd encourage ports to support alloca. :-) > >> OK for trunk for stage1? > > Ok. Ok for release branches and trunk as well, if you want. I'd recommend trunk, if your port is meant to work and test out nicely in gcc 7. > Committed to trunk. Likewise, committed these 3 patches for effective target keywords nonlocal_goto, indirect_jump and global_constructor. Thanks, - Tom Require effective target global_constructor for two testcases 2017-03-23 Tom de Vries PR testsuite/80092 * gcc.dg/no_profile_instrument_function-attr-1.c: Add dg-require-effective-target global_constructor. * gcc.dg/tls/emutls-2.c: Same. --- gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c | 1 + gcc/testsuite/gcc.dg/tls/emutls-2.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c index f7afb34..0f04fb1 100644 --- a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c +++ b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c @@ -1,3 +1,4 @@ +/* { dg-require-effective-target global_constructor } */ /* { dg-options "-O2 -fprofile-generate -fprofile-update=single -fdump-tree-optimized" } */ __attribute__ ((no_profile_instrument_function)) diff --git a/gcc/testsuite/gcc.dg/tls/emutls-2.c b/gcc/testsuite/gcc.dg/tls/emutls-2.c index 1e26d5f..3b94dc7 100644 --- a/gcc/testsuite/gcc.dg/tls/emutls-2.c +++ b/gcc/testsuite/gcc.dg/tls/emutls-2.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target tls } */ +/* { dg-require-effective-target global_constructor } */ /* { dg-options "-O2" } */ /* With emulated TLS, the constructor generated during IPA