diff mbox series

[V2] rs6000: Don't pass -many to the assembler [PR112868]

Message ID 31e4c659-27f6-4db2-8678-9e7891f55685@linux.ibm.com
State New
Headers show
Series [V2] rs6000: Don't pass -many to the assembler [PR112868] | expand

Commit Message

jeevitha July 11, 2024, 11:26 a.m. UTC
Hi All,

The following patch has been bootstrapped and regtested with default configuration
[--enable-checking=yes] and with --enable-checking=release on powerpc64le-linux.

This patch removes passing the -many assembler option for release builds. Now,
GCC no longer passes -many under any conditions to the assembler.

This patch exposes the issue with target_powerpc_ppu_ok, which makes a few
test cases unsupported. Those changes will be in another patch.

2024-07-11  Jeevitha Palanisamy  <jeevitha@linux.ibm.com>

gcc/
	PR target/112868
	* config/rs6000/rs6000.h (ASM_OPT_ANY): Removed Define.
	(ASM_CPU_SPEC): Remove ASM_OPT_ANY usage.

Comments

Sam James July 11, 2024, 11:35 a.m. UTC | #1
jeevitha <jeevitha@linux.ibm.com> writes:

> Hi All,
>
> The following patch has been bootstrapped and regtested with default configuration
> [--enable-checking=yes] and with --enable-checking=release on powerpc64le-linux.
>
> This patch removes passing the -many assembler option for release builds. Now,
> GCC no longer passes -many under any conditions to the assembler.
>
> This patch exposes the issue with target_powerpc_ppu_ok, which makes a few
> test cases unsupported. Those changes will be in another patch.

For our part, I think we really need PR113652 fixed first, or it'll end up
regressing builds w/ -mcpu=7450. Other than that, we hit no issues in
our testing downstream in Gentoo.

>
> 2024-07-11  Jeevitha Palanisamy  <jeevitha@linux.ibm.com>
>
> gcc/
> 	PR target/112868
> 	* config/rs6000/rs6000.h (ASM_OPT_ANY): Removed Define.
> 	(ASM_CPU_SPEC): Remove ASM_OPT_ANY usage.
>
> diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h
> index 9211f91740a..a5bd8e461a0 100644
> --- a/gcc/config/rs6000/rs6000.h
> +++ b/gcc/config/rs6000/rs6000.h
> @@ -94,12 +94,6 @@
>    "%{mdejagnu-*: %<mdejagnu-*}", \
>     SUBTARGET_DRIVER_SELF_SPECS
>  
> -#if CHECKING_P
> -#define ASM_OPT_ANY ""
> -#else
> -#define ASM_OPT_ANY " -many"
> -#endif
> -
>  /* Common ASM definitions used by ASM_SPEC among the various targets for
>     handling -mcpu=xxx switches.  There is a parallel list in driver-rs6000.cc to
>     provide the default assembler options if the user uses -mcpu=native, so if
> @@ -166,8 +160,7 @@
>  	    mvsx: -mpower7; \
>  	    mpowerpc64: -mppc64;: %(asm_default)}; \
>    :%eMissing -mcpu option in ASM_CPU_SPEC?\n} \
> -%{mvsx: -mvsx -maltivec; maltivec: -maltivec}" \
> -ASM_OPT_ANY
> +%{mvsx: -mvsx -maltivec; maltivec: -maltivec}"
>  
>  #define CPP_DEFAULT_SPEC ""
>
diff mbox series

Patch

diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h
index 9211f91740a..a5bd8e461a0 100644
--- a/gcc/config/rs6000/rs6000.h
+++ b/gcc/config/rs6000/rs6000.h
@@ -94,12 +94,6 @@ 
   "%{mdejagnu-*: %<mdejagnu-*}", \
    SUBTARGET_DRIVER_SELF_SPECS
 
-#if CHECKING_P
-#define ASM_OPT_ANY ""
-#else
-#define ASM_OPT_ANY " -many"
-#endif
-
 /* Common ASM definitions used by ASM_SPEC among the various targets for
    handling -mcpu=xxx switches.  There is a parallel list in driver-rs6000.cc to
    provide the default assembler options if the user uses -mcpu=native, so if
@@ -166,8 +160,7 @@ 
 	    mvsx: -mpower7; \
 	    mpowerpc64: -mppc64;: %(asm_default)}; \
   :%eMissing -mcpu option in ASM_CPU_SPEC?\n} \
-%{mvsx: -mvsx -maltivec; maltivec: -maltivec}" \
-ASM_OPT_ANY
+%{mvsx: -mvsx -maltivec; maltivec: -maltivec}"
 
 #define CPP_DEFAULT_SPEC ""