From patchwork Sat Nov 9 14:57:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Koenig X-Patchwork-Id: 1192433 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512880-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=netcologne.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="G3iHGXRS"; dkim=pass (2048-bit key; unprotected) header.d=netcologne.de header.i=@netcologne.de header.b="D9pSgx3H"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 479Kxf0MDdz9sP4 for ; Sun, 10 Nov 2019 01:57:39 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=Ge3AeFIWYPuDAsBNgdctV61lxVLscWX9rr0U1B+8b5XMe+uQuy uIxPhAn7ZXYDUbSHsl3+74FssPj1TaVTzOjkyVgLzYi6kCRElIKkGI2aN5tsI/pf ohJR/EY6qW7g7ODNNTQxLbKK+L0LsB1gxvKhyivHrsUqdCKrxq9gT4NUE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=UEdtwu8bh9E/YUQ171v9Pct9z9Q=; b=G3iHGXRSHQp5KbVyMvlc smlOugnJYQZyVPgg+rZuEuJ2Ihc/g+JEdgup5Oqvm2In/BcP74wli+DqnSoQrXsj 5T3TC0PxEgiWuJqNMEXO5v+fLUadwfWIUA4qXVoXDacBq+OYiQ89kez5p9bcFgdR vElHNVInTHR3VMWPMX+jg0o= Received: (qmail 62449 invoked by alias); 9 Nov 2019 14:57:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 62422 invoked by uid 89); 9 Nov 2019 14:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Nov 2019 14:57:28 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 886591254C; Sat, 9 Nov 2019 15:57:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1573311445; bh=0oQQ+MHsTKZxefQyneOvj4TUDLsJc3jHvcrBU6mM8Dw=; h=To:From:Subject:Message-ID:Date:From; b=D9pSgx3H4Cm2KdcXh7h7sz7fCazNDOuuxQIs8yjVoRib2sMCfBvksUzGtQ273z3K0 psDaWft/rTpNPJFI0t9ZVQTo/eBP2TBh7NlNAe+09oEWaOVFWdilOfA+aVOxS5jom5 FKK9GyGFAB90LvwZCiHDmgXfjJ3mIcNXjQJyrodl7st4a8IK1ahBbkLIbfrAsFkII2 oY1ZtmSkzNqf+Rzy6wTiVu5O3MIbvqRjZnT7K4ukdacwJ7Pl+RQ15hbUge7qMKbxCc 3hoqjHOSGWb/X5eSloS1iqCssqHPSPvhCxtpNrWLKqoxcd1M2r4TdqUL0EFH5Wpc8m AsDPGSpVhYdnQ== Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 84E6611ED5; Sat, 9 Nov 2019 15:57:25 +0100 (CET) Received: from [2001:4dd6:2b98:0:7285:c2ff:fe6c:992d] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.6.0) (envelope-from ) id 5dc6d3d5-388c-7f0000012729-7f000001d620-1 for ; Sat, 09 Nov 2019 15:57:25 +0100 Received: from [IPv6:2001:4dd6:2b98:0:7285:c2ff:fe6c:992d] (2001-4dd6-2b98-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2001:4dd6:2b98:0:7285:c2ff:fe6c:992d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Sat, 9 Nov 2019 15:57:23 +0100 (CET) To: "fortran@gcc.gnu.org" , gcc-patches From: Thomas Koenig Subject: [patch, fortran, committed] Commit symbol for external BLAS routine when translating MATMUL to *GEMM. Message-ID: <2b4d48fc-273d-7e8b-3909-cf8ac22640fd@netcologne.de> Date: Sat, 9 Nov 2019 15:57:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Hi, I just committed the patch below as obvious to fix a 9/10 regression when directly calling BLAS routines for matmul. Will backport to gcc-9 soon. Regards Thomas Commit symbol for external BLAS routine when translating MATMUL to *GEMM. 2019-11-09 Thomas Koenig PR fortran/92321 * frontend-passes.c (call_external_blas): Commit symbol for external BLAS routine. 2019-11-09 Thomas Koenig PR fortran/92321 * gfortran.dg/matmul_blas_2.f90: New test. Index: frontend-passes.c =================================================================== --- frontend-passes.c (Revision 277999) +++ frontend-passes.c (Arbeitskopie) @@ -4635,6 +4635,7 @@ call_external_blas (gfc_code **c, int *walk_subtre call->symtree->n.sym->attr.procedure = 1; call->symtree->n.sym->attr.flavor = FL_PROCEDURE; call->resolved_sym = call->symtree->n.sym; + gfc_commit_symbol (call->resolved_sym); /* Argument TRANSA. */ next = gfc_get_actual_arglist ();