From patchwork Thu Jul 14 09:12:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preudhomme X-Patchwork-Id: 648280 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rqqjQ5p32z9s9Y for ; Thu, 14 Jul 2016 19:12:42 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=eWHWle2T; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=Y0SNiNnfXViSvv4I Cx8AVxVRaf6cDdn5A4SJci+Z8xkkMBYEJ0sHzJZIzicAQY56n4ypRr6fV9ISVL00 4CcMv4aYG6D6ZNC9/+I1p2MZov8CnpPfYqxT2MLomTT6tzvtqGfJwqg9vl0yajDJ PFuwQB60nuUdZd183OU0n2eu59E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=WYp2Wd3GAxR/ar/TWhsmWY ctKuA=; b=eWHWle2TmYQH1CnbAJW8PErlFkyndHFPmWEL0FLjPieBEqCJY/xAKl jzt2QxNX0EObb9Zgj3yb7BHLu2SN/mnb22CiG7QdUu7jLuYZCN3aHT86bdQA+Uh3 2f4KQFk56ob51H4OGwiXLA0QI3i/ZyfssNv1cWjPpLPk6Oyn0y0Jc= Received: (qmail 121257 invoked by alias); 14 Jul 2016 09:12:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 121242 invoked by uid 89); 14 Jul 2016 09:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1224 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jul 2016 09:12:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 772B62F; Thu, 14 Jul 2016 02:13:28 -0700 (PDT) Received: from e108577-lin.localnet (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 448CB3F213; Thu, 14 Jul 2016 02:12:22 -0700 (PDT) From: Thomas Preudhomme To: kyrylo.tkachov@arm.com, ramana.radhakrishnan@arm.com, richard.earnshaw@arm.com, gcc-patches@gcc.gnu.org Subject: [PATCH, GCC/ARM testsuite] Fix pr42574.c selector syntax error Date: Thu, 14 Jul 2016 10:12:18 +0100 Message-ID: <2942868.C3caybiHGj@e108577-lin> User-Agent: KMail/4.13.3 (Linux/3.13.0-85-generic; KDE/4.13.3; x86_64; ; ) MIME-Version: 1.0 X-IsSubscribed: yes This patch fixes a syntax error in the dg-do selector of pr42574.c: it is missing the target keyword, with the following boolean expression enclosed in curly braces. Test fails to be run without this patch and successfully pass with it. Patch is in attachment. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog *** 2016-07-13 Thomas Preud'homme * gcc.target/arm/pr42574.c: Add missing target keyword for the dg-do selector and enclose boolean expression in curly braces. Is this ok for trunk? Best regards, Thomas diff --git a/gcc/testsuite/gcc.target/arm/pr42574.c b/gcc/testsuite/gcc.target/arm/pr42574.c index e3476f37788a2b3144454aef04a9b45c0b4ac398..d3d6b5d32e5826abf1017b823a9e271383daf09d 100644 --- a/gcc/testsuite/gcc.target/arm/pr42574.c +++ b/gcc/testsuite/gcc.target/arm/pr42574.c @@ -1,4 +1,4 @@ -/* { dg-do compile { arm_thumb1_ok && { ! arm_thumb1_movt_ok } } } */ +/* { dg-do compile { target { arm_thumb1_ok && { ! arm_thumb1_movt_ok } } } } */ /* { dg-options "-mthumb -Os -fpic" } */ /* { dg-require-effective-target fpic } */ /* Make sure the address of glob.c is calculated only once and using