From patchwork Tue Dec 15 19:41:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 1416710 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=HLKPyiyG; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CwTCq6lhxz9sRR for ; Wed, 16 Dec 2020 06:41:43 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A551C386F41A; Tue, 15 Dec 2020 19:41:41 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 377543857810 for ; Tue, 15 Dec 2020 19:41:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 377543857810 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nathanmsidwell@gmail.com Received: by mail-qk1-x729.google.com with SMTP id 186so20347869qkj.3 for ; Tue, 15 Dec 2020 11:41:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=uv1SP77oPgS9+3G6AfK89SG0yeGj/PvlMw5m5ku4sJA=; b=HLKPyiyGHMpszmZjb7vDrhA2ta0yWsyr7H38Ahik6RYzqcLgUFT7wusaruihhgzvDF GSTM7fP8ZdDWrNozsBJFxkakERLeUtgXQehHsihFvNxRYTkql/yoNdcKGsUrPvMpmNEp JtuSRq6eZ5L0QO9QVbf/YPxHulCqO5nvo/mCB94Dy6eZg7RbhaQoxk0SrJLYwEs8BsXP lRYgdu3l20HztS05mJvLHbbZKTx2TvldVhdyUgSV9BBHzOI0IJ9D+QcS4zHOG30d273/ 3v7SnsAGJuh969JC1q1GoPrEi5oTr9BWbMnJrmqOGDS/HKp0P+ZaFvRBQt5Q7SAIBJ2h x1Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language; bh=uv1SP77oPgS9+3G6AfK89SG0yeGj/PvlMw5m5ku4sJA=; b=OvtiQTjTFtsjBhkwcZd3Z5dVih/nojA21MOM69adqp8yYGzi4pMdvSknURzDS2hVSx eghPPYlV2Nit9zWG8ndSThuVxW/49Hg9pFbD5+3AKamnJjShLtKz3TSk5SvxQwd8k2ru DpnKsITvHoIJEOxup7Zmma3JTeqEmOt17s8w86hUrc5HvKkWGK82scgMTEFnNIRfZ9fW /l8hhki9tBx0EKuK65KLMEvByDXEbEeRe0i1dg9LyT2tptdZfdZX497C+847soHniXTt gZYz6JIVd9E+21w1haHJOfQoU+aaOZe5GyPcD93fbVfyurJC1p9UcQ1S8pOg1KZpYaau PGLQ== X-Gm-Message-State: AOAM530YVcJioYzu5G3c1ETtNz3ukT0+Giix+UuPW9WRjfbQ5+dtmzGJ SrPatqYKgLBHW2UNnkiUz34= X-Google-Smtp-Source: ABdhPJztGWssAYZ6xmcarrWrhZkMWsAsJLgTolKZ8fDCBiqh6+4gFh81hjo16d/spvZs5zY7T2ALuA== X-Received: by 2002:a37:a110:: with SMTP id k16mr39426203qke.320.1608061298349; Tue, 15 Dec 2020 11:41:38 -0800 (PST) Received: from ?IPv6:2620:10d:c0a8:1102:58ca:9b62:2bcb:bb64? ([2620:10d:c091:480::1:a32c]) by smtp.googlemail.com with ESMTPSA id b63sm14361031qke.21.2020.12.15.11.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 11:41:37 -0800 (PST) To: GCC Patches , richard.sandiford@arm.com From: Nathan Sidwell Subject: libcody: Fix for dash Message-ID: <28b4689c-80c4-52df-d05d-f91fd9bb348d@acm.org> Date: Tue, 15 Dec 2020 14:41:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Language: en-US X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Apparently 'var+=...' is not a dash thing. Fixed thusly. * config.m4: Avoid non-dash idiom * configure: Rebuilt. pushed (2 patches, because I didn't look carefully enough the first time) diff --git i/libcody/config.m4 w/libcody/config.m4 index 0ae7b2665f0..801cfbdb593 100644 --- i/libcody/config.m4 +++ w/libcody/config.m4 @@ -173,7 +173,7 @@ AC_SUBST(EXCEPTIONS)]) AC_DEFUN([NMS_LINK_OPT], [AC_MSG_CHECKING([adding $1 to linker]) ORIG_LDFLAGS="$LDFLAGS" -LDFLAGS+=" $1" +LDFLAGS="$LDFLAGS $1" AC_LINK_IFELSE([AC_LANG_PROGRAM([])], [AC_MSG_RESULT([ok])], [LDFLAGS="$ORIG_LDFLAGS" @@ -229,8 +229,8 @@ elif test "$withval" = "no" ; then AC_MSG_RESULT(installed) else AC_MSG_RESULT(${withval}) - CPPFLAGS+=" -I${withval}/include" - LDFLAGS+=" -L${withval}/lib" + CPPFLAGS="$CPPFLAGS -I${withval}/include" + LDFLAGS="$LDFLAGS -L${withval}/lib" fi, AC_MSG_RESULT(installed))]) diff --git i/libcody/configure w/libcody/configure index 8f22dd78134..1a119c59b9f 100755 --- i/libcody/configure +++ w/libcody/configure @@ -2639,7 +2639,7 @@ fi { $as_echo "$as_me:${as_lineno-$LINENO}: checking adding -Wl,--no-undefined to linker" >&5 $as_echo_n "checking adding -Wl,--no-undefined to linker... " >&6; } ORIG_LDFLAGS="$LDFLAGS" -LDFLAGS+=" -Wl,--no-undefined" +LDFLAGS="$LDFLAGS -Wl,--no-undefined" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */