From patchwork Thu Sep 8 08:19:48 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 113876 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 15DB3B6F86 for ; Thu, 8 Sep 2011 18:20:24 +1000 (EST) Received: (qmail 12783 invoked by alias); 8 Sep 2011 08:20:15 -0000 Received: (qmail 12749 invoked by uid 22791); 8 Sep 2011 08:20:07 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2beaomr10.btconnect.com (HELO mail.btconnect.com) (213.123.26.188) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 08:19:52 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2beaomr10.btconnect.com with ESMTP id EFV31978; Thu, 08 Sep 2011 09:19:50 +0100 (BST) Message-Id: <253AEBCB-9D4D-47C1-A63F-7C71D3DB2227@sandoe-acoustics.co.uk> From: Iain Sandoe To: GCC Patches Mime-Version: 1.0 (Apple Message framework v936) Subject: [Patch, testsuite] fix target/PR49614 Date: Thu, 8 Sep 2011 09:19:48 +0100 Cc: Dominique Dhumieres X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0303.4E687AA5.0099, actions=tag X-Junkmail-Premium-Raw: score=7/50, refid=2.7.2:2011.9.8.65714:17:7.586, ip=81.138.1.83, rules=__HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CT_TEXT_PLAIN, __CTE, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, __STOCK_PHRASE_25, BODY_SIZE_1100_1199, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS, NO_URI_FOUND X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0201.4E687AA7.0056, ss=1, fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org gcc.dg/vmx/gcc-bug-i.c is failing for powerpc*-*-* with: Excess errors: /opt/gcc/work/gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c: 16:22: warning: always_inline function might not be inlinable [- Wattributes] this is because the function in question is declared: static DO_INLINE int inline_me(vector signed short data) ; where: #define DO_INLINE __attribute__ ((always_inline)) so, unless __attribute__ ((always_inline)) is intended to imply "inline", the fix below is proposed, OK for trunk? Iain gcc/testsuite: PR target/49614 * gcc.dg/vmx/gcc-bug-i.c (inline_me): Declare 'inline'. Index: gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c =================================================================== --- gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c (revision 177459) +++ gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c (working copy) @@ -13,7 +13,7 @@ #define DO_INLINE __attribute__ ((always_inline)) #define DONT_INLINE __attribute__ ((noinline)) -static DO_INLINE int inline_me(vector signed short data) +static inline DO_INLINE int inline_me(vector signed short data) { union {vector signed short v; signed short s[8];} u; u.v = data;