From patchwork Thu Nov 7 09:15:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 2007892 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UYpLa9Yh; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wAimMtod; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UYpLa9Yh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wAimMtod; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xkbyp4RJ3z1xyS for ; Thu, 7 Nov 2024 20:15:46 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C7DF3858D34 for ; Thu, 7 Nov 2024 09:15:44 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 41A5F3858D20 for ; Thu, 7 Nov 2024 09:15:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41A5F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41A5F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730970925; cv=none; b=o99mpCuQetSpIXeEIxSwrtSevYx58P0/ForPxOMJTFLYH65UrujIwpmRv/0xVm6mRLAkBSU7pPV5NQO5zwGIi7Up8XuTPZwMheLhrZSsiEA3ZepnBgndTt38+yhfU2YuzQPXogjymq6w7F740qkbF0Gfn/aySfXBzBJTKghTXNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730970925; c=relaxed/simple; bh=Pn3oAuWtnED7qR2ZgSPxPU4UQMX3pc97NSSjtx53KzU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=xnpOrDlcJQke00PFyV3MYbIs+0ThGVAiLw0jl0L5QU7a5AtX7USkCQ2AmsLlcUFk1pDTkQt/lq1xMI47jnWyTxNPvVIQLtFfBJ7UpQ7Sc/nyaUV4z1tc64X2gletVIGUmDoAlUL3nvfL6+9KlQ0lt7AuFmnLi3aH+fO9zmw1TWM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F28B41FF23 for ; Thu, 7 Nov 2024 09:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730970921; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NHjS7vljri2Dt2aS4gYOgmEQ2IYQNWl9sHDZA8+cEwM=; b=UYpLa9YhQQe8/qV3u1oHaM7O6cSptWQXiH1qMISZHw/Jv5Jhygpg7hBiGc2fLuiInA26hH emvLnE+FMgqYOrI1tYUHy3eESehWJxFwuUqu6I1ylfr6VpbEBzdPwnb6eoUGUNE1LDnBVL n55IQMi3Bl59VJunl5Ulh8lQpPr5qfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730970921; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NHjS7vljri2Dt2aS4gYOgmEQ2IYQNWl9sHDZA8+cEwM=; b=wAimMtod2K6cevhbz0B7j6bHqSYAseFOfp+Y+qtMOoKmFkKb/RPpIhOIQOa7fSAchrD7Uj 2kep9DPyqk8s/IAQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730970921; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NHjS7vljri2Dt2aS4gYOgmEQ2IYQNWl9sHDZA8+cEwM=; b=UYpLa9YhQQe8/qV3u1oHaM7O6cSptWQXiH1qMISZHw/Jv5Jhygpg7hBiGc2fLuiInA26hH emvLnE+FMgqYOrI1tYUHy3eESehWJxFwuUqu6I1ylfr6VpbEBzdPwnb6eoUGUNE1LDnBVL n55IQMi3Bl59VJunl5Ulh8lQpPr5qfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730970921; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NHjS7vljri2Dt2aS4gYOgmEQ2IYQNWl9sHDZA8+cEwM=; b=wAimMtod2K6cevhbz0B7j6bHqSYAseFOfp+Y+qtMOoKmFkKb/RPpIhOIQOa7fSAchrD7Uj 2kep9DPyqk8s/IAQ== Date: Thu, 7 Nov 2024 10:15:20 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] rtl-optimization/117467 - 33% compile-time in rest of compilation MIME-Version: 1.0 X-Spamd-Result: default: False [-1.17 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.38)[-0.385]; NEURAL_HAM_SHORT(-0.19)[-0.943]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241107091544.2C7DF3858D34@sourceware.org> ext-dce uses TV_NONE, that's not OK for a pass taking 33% compile-time. The following adds a timevar to it for proper blaming. Bootstrap running on x86_64-unknown-linux-gnu. PR rtl-optimization/117467 * timevar.def (TV_EXT_DCE): New. * ext-dce.cc (pass_data_ext_dce): Use TV_EXT_DCE. --- gcc/ext-dce.cc | 2 +- gcc/timevar.def | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/ext-dce.cc b/gcc/ext-dce.cc index a449b9f6b49..0ece37726c7 100644 --- a/gcc/ext-dce.cc +++ b/gcc/ext-dce.cc @@ -1103,7 +1103,7 @@ const pass_data pass_data_ext_dce = RTL_PASS, /* type */ "ext_dce", /* name */ OPTGROUP_NONE, /* optinfo_flags */ - TV_NONE, /* tv_id */ + TV_EXT_DCE, /* tv_id */ PROP_cfglayout, /* properties_required */ 0, /* properties_provided */ 0, /* properties_destroyed */ diff --git a/gcc/timevar.def b/gcc/timevar.def index 0f9d2c0b032..ae80a311a2d 100644 --- a/gcc/timevar.def +++ b/gcc/timevar.def @@ -313,6 +313,7 @@ DEFTIMEVAR (TV_INITIALIZE_RTL , "initialize rtl") DEFTIMEVAR (TV_GIMPLE_LADDRESS , "address lowering") DEFTIMEVAR (TV_TREE_LOOP_IFCVT , "tree loop if-conversion") DEFTIMEVAR (TV_WARN_ACCESS , "access analysis") +DEFTIMEVAR (TV_EXT_DCE , "ext dce") /* Everything else in rest_of_compilation not included above. */ DEFTIMEVAR (TV_EARLY_LOCAL , "early local passes")