| Message ID | 20241106093925.4042292-1-torbjorn.svensson@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: arm: Use effective-target for pr84556.cc test | expand |
On 06/11/2024 09:39, Torbjörn SVENSSON wrote: > Ok for trunk and releases/gcc-14? > > -- > > Using "dg-do run" with a selector breaks testing arm-none-eabi for any > architecture when check_effective_target_arm_neon_hw returns 0. > > gcc/testsuite/ChangeLog: > > * g++.dg/vect/pr84556.cc: Change from "dg-do run" with selector > to instead use dg-require-effective-target with the same > selector. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> Ah, this is because it overrides the default selector set by vect.exp that picks between dg-do run and dg-do compile based on the target's support for simd operations. I think that should be made clearer in the commit message as otherwise others may be as confused as I was :) R. > --- > gcc/testsuite/g++.dg/vect/pr84556.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/g++.dg/vect/pr84556.cc b/gcc/testsuite/g++.dg/vect/pr84556.cc > index 6b1c9cec515..c7e331628a8 100644 > --- a/gcc/testsuite/g++.dg/vect/pr84556.cc > +++ b/gcc/testsuite/g++.dg/vect/pr84556.cc > @@ -1,5 +1,5 @@ > // PR c++/84556 > -// { dg-do run { target c++11 } } > +// { dg-require-effective-target c++11 } > // { dg-additional-options "-O2 -fopenmp-simd" } > // { dg-additional-options "-mavx" { target avx_runtime } } >
diff --git a/gcc/testsuite/g++.dg/vect/pr84556.cc b/gcc/testsuite/g++.dg/vect/pr84556.cc index 6b1c9cec515..c7e331628a8 100644 --- a/gcc/testsuite/g++.dg/vect/pr84556.cc +++ b/gcc/testsuite/g++.dg/vect/pr84556.cc @@ -1,5 +1,5 @@ // PR c++/84556 -// { dg-do run { target c++11 } } +// { dg-require-effective-target c++11 } // { dg-additional-options "-O2 -fopenmp-simd" } // { dg-additional-options "-mavx" { target avx_runtime } }
Ok for trunk and releases/gcc-14? -- Using "dg-do run" with a selector breaks testing arm-none-eabi for any architecture when check_effective_target_arm_neon_hw returns 0. gcc/testsuite/ChangeLog: * g++.dg/vect/pr84556.cc: Change from "dg-do run" with selector to instead use dg-require-effective-target with the same selector. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> --- gcc/testsuite/g++.dg/vect/pr84556.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)