From patchwork Fri Oct 18 13:12:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Craig Blackmore X-Patchwork-Id: 1999114 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Fjas5IlG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XVQF54VBXz1xth for ; Sat, 19 Oct 2024 00:15:53 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7BB0385AC19 for ; Fri, 18 Oct 2024 13:15:51 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 86CFF3858410 for ; Fri, 18 Oct 2024 13:14:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86CFF3858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86CFF3858410 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729257261; cv=none; b=hgMe3MRqHUg8DLDu9UCxBx5XNTkOVqr6D/asEeU43UGYv2FUJ057b9vCqiGPYuNUHI0o1s0syd/mmYq9Y0m7Pn2p9TSKYsYoq88+tm8QdUFkElKUJpac3d+mn/+n/2uC7z2fqWpnUnn5uH57uIla1mnbyotQYMMJkNO0A0C336o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729257261; c=relaxed/simple; bh=laJB1s6fWzFrRHueizeRKINW6u3pKVJL8sTuX0O6kEM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FGt4oobh28ZLnCibRy0QbUtpkP9VzfsyvybLMcfJ4MTGCVMGZTgG+G/ygxMmqb6YoAhLv/rQdw5jBDLDDeKhQn3N+mlO2vVbB829E+asgTJqpxGyRkpggA/yAGfzIgqDfiVJnprk8QiORhLjSOKVGvoKN6NSjiNK+8ryr+N+mPI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43159c9f617so17568735e9.2 for ; Fri, 18 Oct 2024 06:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1729257258; x=1729862058; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ymgmCBxXfzF74LepquK/UXZrl8Y3SHbp/tmDu8IsaS8=; b=Fjas5IlGyPkAoCJTmVOu2KKwGK8BzOGDTpW+JlGCP6Rjhz1bBdR0YagFFcoBkvakoq ZodhhwPfw2p9t7iYZV6MFEnfJa2fRsIOSvnwOFqep0QJ0XKzg0LjOmXqFRpPgXhFb7jg kOfm9p4W4IksOss14KWCaGuulsP2VV9s2rfE7IJO1s0/2XJcuOoHbzJJUEhhDc9Nu/E+ a1rM9VQsfH4P7I1xVWcC1l/soQvNlOM9s8Tmrlqx249UFnPZdqXXDk7wUiQv2uaHDy5t xxj2ItPWBcgHal7UW+a7kY4aqc0cmW8sEAZ0dUuJ6kaJ3zxHSIC3HM4BdyIDmVGCSa6p dt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729257258; x=1729862058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ymgmCBxXfzF74LepquK/UXZrl8Y3SHbp/tmDu8IsaS8=; b=PZphXeM7sau1KntFkDqgqnppWKO61shppobwTK4+qVsN2U9KVYVniVVyTe7hQclItU 5Vt53Qtav+uxDEqL3i4maq1gJMcGoMMp/fOG4DbXCyA8oRzOUC3AjhEloP5jueSLkdBA hZgPDuIN1vdcTduMVj1YM63SZ3wFuzSEE+ipCMTOgOHtanWMXU11dqlkeeoXxSnbrZMl HRO30WJmVSwYpFYbAQ7ncwDxcOI8/bUXBj/WVY+avsGCTRfU+WhRC8wAVl/JMr3hmCWn /SobDy+A2ri8R31EBJvbxkFatLpIpOcEzhO0xU0QNx8cQPc+qOUukXY4BTGEFjemMme/ X5bw== X-Gm-Message-State: AOJu0YwmJoDRblH8drnDO2vcXYSdmQGk8yg+eIcdgCPzgigzIWIiX1Ef vlK6NLECYN9yc35k8sokOpeLSOIP1iOlS1eQiBRL3eIIu7uKjPmXoCBh8fzZ/chA79NEthDCyuk 4 X-Google-Smtp-Source: AGHT+IGQkOpGoIcyrGfIMZbw51vVd+QHYeEnV6w1TwJx438R/nDCwEGfTrn69d1fBKga32+SqFEcOA== X-Received: by 2002:a05:600c:4e12:b0:431:50fa:89c4 with SMTP id 5b1f17b1804b1-43161622aa4mr17908925e9.3.1729257258081; Fri, 18 Oct 2024 06:14:18 -0700 (PDT) Received: from dorian.. (sals-04-b2-v4wan-167965-cust660.vm36.cable.virginm.net. [80.3.10.149]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43160dc9a89sm23577435e9.16.2024.10.18.06.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 06:14:17 -0700 (PDT) From: Craig Blackmore To: gcc-patches@gcc.gnu.org Cc: Craig Blackmore Subject: [PATCH 2/7] RISC-V: Fix uninitialized reg in memcpy Date: Fri, 18 Oct 2024 14:12:55 +0100 Message-ID: <20241018131300.1150819-3-craig.blackmore@embecosm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241018131300.1150819-1-craig.blackmore@embecosm.com> References: <20241018131300.1150819-1-craig.blackmore@embecosm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org riscv_vector::expand_block_move contains a gen_rtx_NE that uses uninitialized reg rtx `end`. It looks like `length_rtx` was supposed to be used here. gcc/ChangeLog: * config/riscv/riscv-string.cc (expand_block_move): Replace `end` with `length_rtx` in gen_rtx_NE. --- gcc/config/riscv/riscv-string.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/config/riscv/riscv-string.cc b/gcc/config/riscv/riscv-string.cc index 0c5ffd7d861..0f1353baba3 100644 --- a/gcc/config/riscv/riscv-string.cc +++ b/gcc/config/riscv/riscv-string.cc @@ -1078,7 +1078,6 @@ expand_block_move (rtx dst_in, rtx src_in, rtx length_in) bool need_loop = true; bool size_p = optimize_function_for_size_p (cfun); rtx src, dst; - rtx end = gen_reg_rtx (Pmode); rtx vec; rtx length_rtx = length_in; @@ -1245,7 +1244,7 @@ expand_block_move (rtx dst_in, rtx src_in, rtx length_in) emit_insn (gen_rtx_SET (length_rtx, gen_rtx_MINUS (Pmode, length_rtx, cnt))); /* Emit the loop condition. */ - rtx test = gen_rtx_NE (VOIDmode, end, const0_rtx); + rtx test = gen_rtx_NE (VOIDmode, length_rtx, const0_rtx); emit_jump_insn (gen_cbranch4 (Pmode, test, length_rtx, const0_rtx, label)); emit_insn (gen_nop ()); }