From patchwork Thu Oct 17 13:03:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1998577 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dPA/hxHz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gomvsw6q; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gVHodrcG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6H16xZc9; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTp1k1gXvz1xw2 for ; Fri, 18 Oct 2024 00:03:54 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5E4C3858420 for ; Thu, 17 Oct 2024 13:03:51 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id D21E53858431 for ; Thu, 17 Oct 2024 13:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D21E53858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D21E53858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729170196; cv=none; b=n/LShaL6cQv0qqsHco+Pfp9SpRgKFmzkALHGyLo4LmM4Y7zRjY3xxB3X1P2UuYG3OqGLRwkDG4HNPvY7WftfidnhVVOs67A2/5TICgMItrD8+YdlM8kAXBcr0bx1HwHc2ATMv/iGm7yP1A1temGk8E9RgXfV0kY6Q3OjjBYril4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729170196; c=relaxed/simple; bh=1LplMSXY/Isxws0I+Z6ZLVLRT2rUFAbDJMxGspuafQQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=JnvhMlXntdNOH1xeqeotHu4UmMnNhjR3XBIfFmd+FiNntaitRDpzWt+eiLxxBM96RNimt3aKh1hjIieIpKZeIdRaPirTnpP2w1CWjOe5SraOoVRYEFDmng6I0y+rmtIE5Yleqm00oaBhxGCPCkIpR6EpDRItmby0ChN+ba+qSh8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D9A861FD2A; Thu, 17 Oct 2024 13:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729170185; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=w7diqgvSvl36SmjiIjritfYk90cTo20ZPfP/QC9cAek=; b=dPA/hxHzWMBr+QpODC7k241ENWy1R88itB1QOmfWjEiylHgF1msvCRj94uDsyRes/Qbpum VOerNNsVgbzE6y74ho0NuOifoNH1sxgT1HfaufSKG5W9AMyooP7eZsEE6ktWzM1Qr1aSAa cQhMSgllmOYjOlueOnlBJ5052mmrT4U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729170185; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=w7diqgvSvl36SmjiIjritfYk90cTo20ZPfP/QC9cAek=; b=gomvsw6q0dUj/qfjl6CGB5ub29/WD0vxKqrQzbLCqZU2API4x98A8kL5YD5Wexi0sxJ9Iu AdP33JrQAEcjaeBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729170184; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=w7diqgvSvl36SmjiIjritfYk90cTo20ZPfP/QC9cAek=; b=gVHodrcGcvxsuzDVmrGkz119WYuOvNWfrxWCp0UkDNpoWo8T9fXOg4GZP68XZxQ57ui/oQ BnKQme7rzpXAxw6xhkBMS6jx6D44HWb0O9hyrxaiDkB4bA1gEKeltZiwo56WdLFxmrMJES u0aVIRpbMO2FXRTrWf3IPsQBMPKaPxY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729170184; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=w7diqgvSvl36SmjiIjritfYk90cTo20ZPfP/QC9cAek=; b=6H16xZc9M1lpfJ64yOVOB27LjM/j5BF7c9zqUAPp906U2f1+7HLd4RsJ21aXTb8mrgfxiC zePJmZ1njugWccCA== Date: Thu, 17 Oct 2024 15:03:04 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: RISC-V CI Subject: [PATCH] Relax boolean processing in vect_maybe_update_slp_op_vectype MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-1.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.73)[-0.733]; NEURAL_HAM_SHORT(-0.18)[-0.887]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[] X-Spam-Score: -1.51 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241017130351.B5E4C3858420@sourceware.org> The following makes VECTOR_BOOLEAN_TYPE_P processing consistent with what we do without SLP. The original motivation for rejecting of VECTOR_BOOLEAN_TYPE_P extern defs was bad code generation. But the non-SLP codepath happily goes along - but always hits the case of an uniform vector and this case specifically we can now code-generate optimally. So the following allows single-lane externs as well. Requiring patterns to code-generate can have bad influence on the vectorization factor though a prototype patch of mine shows that generating vector compares externally isn't always trivial. The patch fixes the gcc.dg/vect/vect-early-break_82.c FAIL on x86_64 when --param vect-force-slp=1 is in effect. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. PR tree-optimization/117171 * tree-vect-stmts.cc (vect_maybe_update_slp_op_vectype): Relax vect_external_def VECTOR_BOOLEAN_TYPE_P constraint. --- gcc/tree-vect-stmts.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 948726d51c5..7d7d1512bd4 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -14292,9 +14292,12 @@ vect_maybe_update_slp_op_vectype (slp_tree op, tree vectype) if (SLP_TREE_VECTYPE (op)) return types_compatible_p (SLP_TREE_VECTYPE (op), vectype); /* For external defs refuse to produce VECTOR_BOOLEAN_TYPE_P, those - should be handled by patters. Allow vect_constant_def for now. */ + should be handled by patters. Allow vect_constant_def for now + as well as the trivial single-lane uniform vect_external_def case + both of which we code-generate reasonably. */ if (VECTOR_BOOLEAN_TYPE_P (vectype) - && SLP_TREE_DEF_TYPE (op) == vect_external_def) + && SLP_TREE_DEF_TYPE (op) == vect_external_def + && SLP_TREE_LANES (op) > 1) return false; SLP_TREE_VECTYPE (op) = vectype; return true;