From patchwork Wed Oct 16 16:18:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eikansh Gupta X-Patchwork-Id: 1998165 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QTnmF36D; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTGQv1VfQz1xth for ; Thu, 17 Oct 2024 03:20:23 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BDE03858CD1 for ; Wed, 16 Oct 2024 16:20:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 0CCA83858D20 for ; Wed, 16 Oct 2024 16:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CCA83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CCA83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729095602; cv=none; b=PY9jBc8HKTQiBYGAJbGAfEj48ljS3WBYF5ndt+x00aEoytCMSt3b40uolPr/xmRrTRuf6UeQTnqI8obbUSZggZvGRLU/p79Ww/wtQmA3wVCokQkdKvyefwN0/2x9ZqHuXGuQzDBwMmWjGGrEI5KZKZvNUgjIiAlC8k+YSkxFVVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729095602; c=relaxed/simple; bh=t6plYtr3eKUlWNlgi+LGpvV859yvPB81nS39hVkWx6s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UyYG3lg7X4HDqPre//CNcWVZByNTBRm+bbS2bUjgfXHePcnQOwCi1F5eVMC1W3qHpAENdzmLXN7wCXNURPOvNqQjGbQ2PwBCYCSQ6nCU+IjZLBRJSp2r5ZvbfXuC0ECWNXvQ/ZRTK2a0PkkQtusrfYZPsXAcfV50WVkeMjPbm4Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49G8Pvvf014341 for ; Wed, 16 Oct 2024 16:19:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:message-id:mime-version:subject:to; s= qcppdkim1; bh=+HcS9PlJhfNgubZk3a0lnNs3XN3klXixSWxEVSxlBjc=; b=QT nmF36Dfo9lGGmpzgtZiRr0sLaK8pRjYeOUP0rRmre66/1VsAZPJ2isbfNjujSrVI 9Iu6chSi18dBCWhlX7A6roGT9L/shr/5Psgs3ezm/Y6nWI1bZJg4Pi/um0AcJ+Rg XQbP3/4bBS+tI6h9jB3fyvwYaoIIcdYN6awo/hmbA9X022FseDXqMiDHkhpwRLd7 9DUV4xjFDvoafD5irjvCCJk8l488TjOzCOWvkr6hRu4FHoA+1gyh3jE8y1zp68hQ awPRsvfOvi6POrSqZC0HiwJSiONseFmUA925s81R6S6vaywoTZXEwmcMyktclgyy 7lxav1lumdupa9sRuFEQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42a79ha069-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Oct 2024 16:19:58 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49GGJuMK022425 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Oct 2024 16:19:57 GMT Received: from hu-eikagupt-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 16 Oct 2024 09:19:55 -0700 From: Eikansh Gupta To: CC: Eikansh Gupta Subject: [PATCH v2] MATCH: Simplify `(trunc)copysign ((extend)x, CST)` to `copysign (x, -1.0/1.0)` [PR112472] Date: Wed, 16 Oct 2024 21:48:44 +0530 Message-ID: <20241016161844.1672-1-quic_eikagupt@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: tBTJNClFp8eRpPk7wotF9d3ahWnF3OcO X-Proofpoint-ORIG-GUID: tBTJNClFp8eRpPk7wotF9d3ahWnF3OcO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410160103 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org This patch simplify `(trunc)copysign ((extend)x, CST)` to `copysign (x, -1.0/1.0)` depending on the sign of CST. Previously, it was simplified to `copysign (x, CST)`. It can be optimized as the sign of the CST matters, not the value. The patch also simplify `(trunc)abs (extend x)` to `abs (x)`. PR tree-optimization/112472 gcc/ChangeLog: * match.pd ((trunc)copysign ((extend)x, -CST) --> copysign (x, -1.0)): New pattern. ((trunc)abs (extend x) --> abs (x)): New pattern. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr112472.c: New test. Signed-off-by: Eikansh Gupta --- gcc/match.pd | 20 +++++++++++++++++--- gcc/testsuite/gcc.dg/tree-ssa/pr112472.c | 22 ++++++++++++++++++++++ 2 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/pr112472.c diff --git a/gcc/match.pd b/gcc/match.pd index 940292d0d49..a1668c4c9dc 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -8527,15 +8527,29 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) x,y is float value, similar for _Float16/double. */ (for copysigns (COPYSIGN_ALL) (simplify - (convert (copysigns (convert@2 @0) (convert @1))) + (convert (copysigns (convert@2 @0) (convert2? @1))) (if (optimize && !HONOR_SNANS (@2) && types_match (type, TREE_TYPE (@0)) - && types_match (type, TREE_TYPE (@1)) && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@2)) && direct_internal_fn_supported_p (IFN_COPYSIGN, type, OPTIMIZE_FOR_BOTH)) - (IFN_COPYSIGN @0 @1)))) + (if (types_match (type, TREE_TYPE (@1))) + (IFN_COPYSIGN @0 @1) + /* (trunc)copysign (extend)x, CST) to copysign (x, -1.0/1.0) */ + (if (REAL_VALUE_NEGATIVE (TREE_REAL_CST (@1))) + (IFN_COPYSIGN @0 { build_minus_one_cst (type); }) + (IFN_COPYSIGN @0 { build_one_cst (type); })))))) + +/* (trunc)abs (extend x) --> abs (x) + x is a float value */ +(simplify + (convert (abs (convert@1 @0))) + (if (optimize + && !HONOR_SNANS (@1) + && types_match (type, TREE_TYPE (@0)) + && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@1))) + (abs @0))) (for froms (BUILT_IN_FMAF BUILT_IN_FMA BUILT_IN_FMAL) tos (IFN_FMA IFN_FMA IFN_FMA) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c b/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c new file mode 100644 index 00000000000..8f97278ffe8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c @@ -0,0 +1,22 @@ +/* PR tree-optimization/109878 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +/* Optimized to .COPYSIGN(a, -1.0e+0) */ +float f(float a) +{ + return (float)__builtin_copysign(a, -3.0); +} + +/* This gets converted to (float) abs((double) a) + With the patch it is optimized to abs(a) */ +float f2(float a) +{ + return (float)__builtin_copysign(a, 5.0); +} + +/* { dg-final { scan-tree-dump-not "= __builtin_copysign" "optimized" } } */ +/* { dg-final { scan-tree-dump-not " double " "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times ".COPYSIGN" 1 "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times "-1.0e\\+0" 1 "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times " ABS_EXPR " 1 "optimized" { target ifn_copysign } } } */