From patchwork Wed Oct 16 09:41:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1997889 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H62FwDMO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9EJ5kGa5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H62FwDMO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9EJ5kGa5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XT5Zr5jLMz1xvV for ; Wed, 16 Oct 2024 20:41:38 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B24AD3858433 for ; Wed, 16 Oct 2024 09:41:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 9B9293858D20 for ; Wed, 16 Oct 2024 09:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B9293858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B9293858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729071675; cv=none; b=oOvC7HJbCbRBADhVsykAHX29dpPrbMMBH1jCtIXse/zgEz3bEF6xhft18aZgrXHANh69GHzAzLOnqRnDpIXVwNdXb836nqiHarAK0BoHKcZi4jAKaARWEXcksIk+IXS+Qh0czQqPfETpOOEy1ta8wvlwG1vnKJlrj7SzAPsrJoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729071675; c=relaxed/simple; bh=jx8pcq191Np6rKHH3aIwWimJjovG1GpXiCf+G3Ujbc8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=ihxq8eqFOg2Pg0ssTpoJQB8gEYq4P43NpKIM63jisdxvuv+toZhULmv5ZrweFX9WVb7olW5yplQBKNl/rjiVA3mPHOC9huundURj9BIWFALdqrwlqMuo9+R7Phe8IJBbufOYYG3oKt6MlGb4I//bKfAB8Ot+ERR4/9b0oZpqxy0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9CEF621C76; Wed, 16 Oct 2024 09:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729071663; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=v2RZRbeiOBo/UzalrX45fPbtp8l/kkYiR4czyhrNJHY=; b=H62FwDMOFfMkeiszoGtsh4mHpBPrqCBQ1oRDtYmgGCmWEVawuciFoEF1qptkPZTtJ+k0No vGL/4IwZ6StSNMCQVxTZDOCPLdtZE0ygv5U5shYcekKgO+NaumebDVhsulU2dQyy/0GzkC rH1RzCHoGIwAxZc3N1YOTpmrTp8bYqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729071663; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=v2RZRbeiOBo/UzalrX45fPbtp8l/kkYiR4czyhrNJHY=; b=9EJ5kGa5HGeamvpnkxOrxdgwbaqXBRCBGjKTAL9zNgPZNmFzXsydIjVr9eQWKeccM0/qGt tMw8d7iqTdYO4ZBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729071663; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=v2RZRbeiOBo/UzalrX45fPbtp8l/kkYiR4czyhrNJHY=; b=H62FwDMOFfMkeiszoGtsh4mHpBPrqCBQ1oRDtYmgGCmWEVawuciFoEF1qptkPZTtJ+k0No vGL/4IwZ6StSNMCQVxTZDOCPLdtZE0ygv5U5shYcekKgO+NaumebDVhsulU2dQyy/0GzkC rH1RzCHoGIwAxZc3N1YOTpmrTp8bYqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729071663; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=v2RZRbeiOBo/UzalrX45fPbtp8l/kkYiR4czyhrNJHY=; b=9EJ5kGa5HGeamvpnkxOrxdgwbaqXBRCBGjKTAL9zNgPZNmFzXsydIjVr9eQWKeccM0/qGt tMw8d7iqTdYO4ZBA== Date: Wed, 16 Oct 2024 11:41:03 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: RISC-V CI Subject: [PATCH] Fix gcc.dg/vect/vect-early-break_39.c FAIL with forced SLP MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-1.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.73)[-0.728]; NEURAL_HAM_SHORT(-0.18)[-0.875]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[] X-Spam-Score: -1.50 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241016094136.B24AD3858433@sourceware.org> The testcases shows single-element interleaving of size three being exempted from permutation lowering via heuristics (see also PR116973). But it wasn't supposed to apply to non-power-of-two sizes so this amends the check to ensure the sub-group is aligned even when the number of lanes is one. Bootstrap and regtest running on x86_64-unknown-linux-gnu. * tree-vect-slp.cc (vect_lower_load_permutations): Avoid exempting non-power-of-two group sizes from lowering. --- gcc/tree-vect-slp.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 629c4b433ab..d35c2ea02dc 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -4427,6 +4427,7 @@ vect_lower_load_permutations (loop_vec_info loop_vinfo, && contiguous && (SLP_TREE_LANES (load) > 1 || loads.size () == 1) && pow2p_hwi (SLP_TREE_LANES (load)) + && pow2p_hwi (group_lanes) && SLP_TREE_LOAD_PERMUTATION (load)[0] % SLP_TREE_LANES (load) == 0 && group_lanes % SLP_TREE_LANES (load) == 0) {