From patchwork Tue Oct 15 14:20:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 1997507 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V3ZnVHKQ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XSc4j5sZDz1xvK for ; Wed, 16 Oct 2024 01:32:21 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08F3E3858C98 for ; Tue, 15 Oct 2024 14:32:20 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 28B7A385801B for ; Tue, 15 Oct 2024 14:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28B7A385801B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28B7A385801B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729002420; cv=none; b=P3l4FzhYtCuWgeOWviBt8PYWQSXaPIsppNrJaq/nMtRhUjGk0wNexspKaVyOc1NTAFK9A/1R07EOFV/EiwQVN+/qxajTNS5UYW1v4aWxGcsWhn/JjLC42yNF+OeETEDWdTPi3onWE9q1t99rQNGyfoTrtt6Q2WVQpwfYHsn4JPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729002420; c=relaxed/simple; bh=MsnN9tuArAGuobkbuJcwtJJ3CPJhjFxtIns1gw7zEYU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kPJWOmFZ5MzuS+MCU5SWirfHHTH4tlY0yVLoWDpj2Zh/w2txLrlkTjW9k2H8EHYy7+eIEyD5tgwcUnkpexBUV2NFxqr+IkYyIZ+ZpVvwbn70A2tshczxFHoI29cx4Xsh/bCxDe0px75VNmBQSrceHi5GIIIfxFAnbHL8AHDMMLU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729002409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQRowgmm+mT3ZQ3eBlHRKE3kj4jZhplrRJHjA8pimqU=; b=V3ZnVHKQEAqgnHujfqMJjmszXjuBx9aSE2zKJucvAhMqWSQOZNd5QVUqkjb8CqNH/57ASz XzXbaSEgqvLxVIBKzqKPH0PuKFOG7rEc9WKjWQb2JXC8VBvJroNtg913anAKtNTj6jN6pO JmHP4gjpQsxZsQLeDzUxxdbogcAHLUw= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-hMWyFLOPO8WfQYZG8fRs9A-1; Tue, 15 Oct 2024 10:26:47 -0400 X-MC-Unique: hMWyFLOPO8WfQYZG8fRs9A-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 316AD19560B5; Tue, 15 Oct 2024 14:26:46 +0000 (UTC) Received: from localhost (unknown [10.42.28.16]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8BA951956089; Tue, 15 Oct 2024 14:26:45 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH 6/7] libstdc++: Add always_inline to some one-liners in Date: Tue, 15 Oct 2024 15:20:16 +0100 Message-ID: <20241015142630.2148792-6-jwakely@redhat.com> In-Reply-To: <20241015142630.2148792-1-jwakely@redhat.com> References: <20241015142630.2148792-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Tested x86_64-linux. -- >8 -- We implement std::copy, std::fill etc. as a series of calls to other overloads which incrementally peel off layers of iterator wrappers. This adds a high abstraction penalty for -O0 and potentially even -O1. Add the always_inline attribute to several functions that are just a single return statement (and maybe a static_assert, or some concept-checking assertions which are disabled by default). libstdc++-v3/ChangeLog: * include/bits/stl_algobase.h (__copy_move_a1, __copy_move_a) (__copy_move_backward_a1, __copy_move_backward_a, move_backward) (__fill_a1, __fill_a, fill, __fill_n_a, fill_n, __equal_aux): Add always_inline attribute to one-line forwarding functions. --- libstdc++-v3/include/bits/stl_algobase.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/libstdc++-v3/include/bits/stl_algobase.h b/libstdc++-v3/include/bits/stl_algobase.h index d9d1d00b113..b2f5b96d46e 100644 --- a/libstdc++-v3/include/bits/stl_algobase.h +++ b/libstdc++-v3/include/bits/stl_algobase.h @@ -500,12 +500,14 @@ _GLIBCXX_END_NAMESPACE_CONTAINER __copy_move_a1(_II, _II, _GLIBCXX_STD_C::_Deque_iterator<_Tp, _Tp&, _Tp*>); template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OI __copy_move_a1(_II __first, _II __last, _OI __result) { return std::__copy_move_a2<_IsMove>(__first, __last, __result); } template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OI __copy_move_a(_II __first, _II __last, _OI __result) @@ -757,6 +759,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER #undef _GLIBCXX_ADVANCE template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _BI2 __copy_move_backward_a1(_BI1 __first, _BI1 __last, _BI2 __result) @@ -785,6 +788,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER _GLIBCXX_STD_C::_Deque_iterator<_Tp, _Tp&, _Tp*>); template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OI __copy_move_backward_a(_II __first, _II __last, _OI __result) @@ -840,6 +844,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER * that the start of the output range may overlap [first,last). */ template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _BI2 copy_backward(_BI1 __first, _BI1 __last, _BI2 __result) @@ -875,6 +880,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER * that the start of the output range may overlap [first,last). */ template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _BI2 move_backward(_BI1 __first, _BI1 __last, _BI2 __result) @@ -958,6 +964,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER } template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline void __fill_a1(::__gnu_cxx::__normal_iterator<_Ite, _Cont> __first, @@ -977,6 +984,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER const bool&); template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline void __fill_a(_FIte __first, _FIte __last, const _Tp& __value) @@ -1002,6 +1010,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER * to @c memset or @c wmemset. */ template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline void fill(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) @@ -1108,6 +1117,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER std::input_iterator_tag); template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OutputIterator __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value, @@ -1120,6 +1130,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER } template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OutputIterator __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value, @@ -1132,6 +1143,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER } template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OutputIterator __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value, @@ -1167,6 +1179,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER // DR 865. More algorithms that throw away information // DR 426. search_n(), fill_n(), and generate_n() with negative n template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline _OI fill_n(_OI __first, _Size __n, const _Tp& __value) @@ -1246,6 +1259,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER } template + __attribute__((__always_inline__)) _GLIBCXX20_CONSTEXPR inline bool __equal_aux(_II1 __first1, _II1 __last1, _II2 __first2)