diff mbox series

Don't force_reg operands[3] when it's not const0_rtx.

Message ID 20240909021424.1685107-1-hongtao.liu@intel.com
State New
Headers show
Series Don't force_reg operands[3] when it's not const0_rtx. | expand

Commit Message

Liu, Hongtao Sept. 9, 2024, 2:14 a.m. UTC
It fix the regression by

a51f2fc0d80869ab079a93cc3858f24a1fd28237 is the first bad commit
commit a51f2fc0d80869ab079a93cc3858f24a1fd28237
Author: liuhongt <hongtao.liu@intel.com>
Date:   Wed Sep 4 15:39:17 2024 +0800

    Handle const0_operand for *avx2_pcmp<mode>3_1.

caused

FAIL: gcc.target/i386/pr59539-1.c scan-assembler-times vmovdqu|vmovups 1

To reproduce:

$ cd {build_dir}/gcc && make check RUNTESTFLAGS="i386.exp=gcc.target/i386/pr59539-1.c --target_board='unix{-m32\ -march=cascadelake}'"
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="i386.exp=gcc.target/i386/pr59539-1.c --target_board='unix{-m64\ -march=cascadelake}'"

Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
Ready push to trunk.


gcc/ChangeLog:

	* config/i386/sse.md (*avx2_pcmp<mode>3_1): Don't force_reg
	operands[3] when it's not const0_rtx.
---
 gcc/config/i386/sse.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 1946d3513be..1ae61182d0c 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -17929,7 +17929,8 @@  (define_insn_and_split "*avx2_pcmp<mode>3_1"
   if (INTVAL (operands[5]) == 1)
     std::swap (operands[3], operands[4]);
 
-  operands[3] = force_reg (<MODE>mode, operands[3]);
+  if (operands[3] == CONST0_RTX (<MODE>mode))
+    operands[3] = force_reg (<MODE>mode, operands[3]);
   if (operands[4] == CONST0_RTX (<MODE>mode))
     operands[4] = force_reg (<MODE>mode, operands[4]);