From patchwork Wed Sep 4 21:05:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1980997 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=IVVoudni; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WzZm66xYjz1yg3 for ; Thu, 5 Sep 2024 07:06:10 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76DA63858424 for ; Wed, 4 Sep 2024 21:06:08 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 603493858424 for ; Wed, 4 Sep 2024 21:05:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 603493858424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 603493858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725483945; cv=none; b=eDU8eYuYj31OZBOrA4kxWMuFmN/Xk0LuKLmFV9ovh55z69wl3gjyNqUHo/Mf098YR5NP7WoIbnI18nhdo/yCiQQiDMkHrfF583dtIU3BEKtoTSZyvoSAvghWQpNmr/mWzlTV6JP0e+EMIntraGwePrVrBfcnGwAL7d/qQxD34pA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725483945; c=relaxed/simple; bh=iDrJDSuq+Z6+WNMDwrex9iwOIeEye4ncAzD3a2E+Z48=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SyWSG/8WnBwhoYshqZ6+DVxRqoVC5vjH2B01YuA4YNpSebWNvdLdpoatj3syj4J3rQ8Kp7LkYxmggK+fiRufbMxllb/2OD3+zQOB0yWUALPRxEkDBUmTGBipcPeHRzQ6K8Hqnuu93llJwBEapITlTJBWV/BbE6/7CNq3vFLDx0o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484BOtY1009100 for ; Wed, 4 Sep 2024 21:05:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=4uE7WuppeeGMwNST2zQnM6 INs6rlT2PJphtEqXJbg+8=; b=IVVoudniAGYjuNrRpvJqewhLxxyQSFrSbeBnTt yRLxzCBaZBhFY7Fjf2JLR/bv0Rjmg7kegKNrcz0vbI9HQep2/p0TLovLJWjFbhrj zzYyCWJfTjqFIlPREEifCxLGNQof95cZC+qqpdXoqE96DwPQ/LgG7rURC8Y3GjXT usKl/Xx2M4DbNNC4SJ5Hz754V9jbHkrKTe+J/9yJmzprtVoipTbEtee87Sf3B1yQ bQKDTzYyEyLjl8iT/kDiMQsyb8dd2tdrt8SULSj0DsRg0UnQ3eD92nK7oLi9XLYl dI0Qqqv81fyeRy3DLA/ktDUDfwnyeIY5LomqODl4N7defN2Q== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41btrxuytn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Sep 2024 21:05:43 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 484L5fZw031883 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Sep 2024 21:05:41 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 4 Sep 2024 14:05:41 -0700 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH] aarch64: Handle attributes in the global namespace for aarch64_lookup_shared_state_flags [PR116598] Date: Wed, 4 Sep 2024 14:05:21 -0700 Message-ID: <20240904210521.3310478-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 1rynd-LLOL0Xx6IE1i4niBQ9-cmoUWIg X-Proofpoint-ORIG-GUID: 1rynd-LLOL0Xx6IE1i4niBQ9-cmoUWIg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_19,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 phishscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=810 spamscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2409040159 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The code in aarch64_lookup_shared_state_flags all C++11 attributes on the function type had a namespace associated with them. But with the addition of reproducible/unsequenced, this was no longer true. This is the simple fix to ignore attributes in the global namespace since we are looking for ones in the `arm` namespace instead. Built and tested for aarch64-linux-gnu. gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch64_lookup_shared_state_flags): Ignore attributes in the global namespace. Signed-off-by: Andrew Pinski --- gcc/config/aarch64/aarch64.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index 27e24ba70ab..3f7bc572edc 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -597,6 +597,10 @@ aarch64_lookup_shared_state_flags (tree attrs, const char *state_name) if (!cxx11_attribute_p (attr)) continue; + /* Skip the attributes in the global namespace. */ + if (!TREE_PURPOSE (TREE_PURPOSE (attr))) + continue; + auto ns = IDENTIFIER_POINTER (TREE_PURPOSE (TREE_PURPOSE (attr))); if (strcmp (ns, "arm") != 0) continue;