| Message ID | 20240904132650.2720446-3-christophe.lyon@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm: [MVE intrinsics] Re-implement more intrinsics | expand |
On 04/09/2024 14:26, Christophe Lyon wrote: > vcreateq have no overloaded forms, so there's no need for resolve (). > > 2024-07-11 Christophe Lyon <christophe.lyon@linaro.org> > > gcc/ > * config/arm/arm-mve-builtins-shapes.cc (create_def): Remove > resolve. Wouldn't it be more usual to write (create_def::resolve): Delete function? Otherwise OK. R. > --- > gcc/config/arm/arm-mve-builtins-shapes.cc | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-mve-builtins-shapes.cc > index e01939469e3..0520a8331db 100644 > --- a/gcc/config/arm/arm-mve-builtins-shapes.cc > +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc > @@ -1408,12 +1408,6 @@ struct create_def : public nonoverloaded_base > { > build_all (b, "v0,su64,su64", group, MODE_none, preserve_user_namespace); > } > - > - tree > - resolve (function_resolver &r) const override > - { > - return r.resolve_uniform (0, 2); > - } > }; > SHAPE (create) >
On 10/14/24 18:39, Richard Earnshaw (lists) wrote: > On 04/09/2024 14:26, Christophe Lyon wrote: >> vcreateq have no overloaded forms, so there's no need for resolve (). >> >> 2024-07-11 Christophe Lyon <christophe.lyon@linaro.org> >> >> gcc/ >> * config/arm/arm-mve-builtins-shapes.cc (create_def): Remove >> resolve. > > Wouldn't it be more usual to write (create_def::resolve): Delete function? > > Otherwise OK. > Sure, I'll change that. > R. > >> --- >> gcc/config/arm/arm-mve-builtins-shapes.cc | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-mve-builtins-shapes.cc >> index e01939469e3..0520a8331db 100644 >> --- a/gcc/config/arm/arm-mve-builtins-shapes.cc >> +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc >> @@ -1408,12 +1408,6 @@ struct create_def : public nonoverloaded_base >> { >> build_all (b, "v0,su64,su64", group, MODE_none, preserve_user_namespace); >> } >> - >> - tree >> - resolve (function_resolver &r) const override >> - { >> - return r.resolve_uniform (0, 2); >> - } >> }; >> SHAPE (create) >> >
diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-mve-builtins-shapes.cc index e01939469e3..0520a8331db 100644 --- a/gcc/config/arm/arm-mve-builtins-shapes.cc +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc @@ -1408,12 +1408,6 @@ struct create_def : public nonoverloaded_base { build_all (b, "v0,su64,su64", group, MODE_none, preserve_user_namespace); } - - tree - resolve (function_resolver &r) const override - { - return r.resolve_uniform (0, 2); - } }; SHAPE (create)