diff mbox series

[V3,09/10] c6x: Adjust dot-product backend patterns

Message ID 20240815084425.2519197-10-victor.donascimento@arm.com
State New
Headers show
Series optabs: Make all `*dot_prod_optab's modeled as conversions | expand

Commit Message

Victor Do Nascimento Aug. 15, 2024, 8:44 a.m. UTC 
Following the migration of the dot_prod optab from a direct to a
conversion-type optab, ensure all back-end patterns incorporate the
second machine mode into pattern names.

gcc/ChangeLog:

	* config/c6x/c6x.md (sdot_prodv2hi): Renamed to...
	(sdot_prodsiv2hi): ...this.
---
 gcc/config/c6x/c6x.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Victor Do Nascimento Aug. 28, 2024, 3:18 p.m. UTC | #1 
Hello,

Gentle reminder for this simple renaming patch :)

Thanks,
Victor

On 8/15/24 09:44, Victor Do Nascimento wrote:
> Following the migration of the dot_prod optab from a direct to a
> conversion-type optab, ensure all back-end patterns incorporate the
> second machine mode into pattern names.
> 
> gcc/ChangeLog:
> 
> 	* config/c6x/c6x.md (sdot_prodv2hi): Renamed to...
> 	(sdot_prodsiv2hi): ...this.
> ---
>   gcc/config/c6x/c6x.md | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/c6x/c6x.md b/gcc/config/c6x/c6x.md
> index 5964dd69d0d..ea9ffe8b4e1 100644
> --- a/gcc/config/c6x/c6x.md
> +++ b/gcc/config/c6x/c6x.md
> @@ -3082,7 +3082,7 @@ (define_insn "<shift_code>v2hi3"
>   ;; Widening vector multiply and dot product.
>   ;; See c6x-mult.md.in for the define_insn patterns
>   
> -(define_expand "sdot_prodv2hi"
> +(define_expand "sdot_prodsiv2hi"
>     [(match_operand:SI 0 "register_operand" "")
>      (match_operand:V2HI 1 "register_operand" "")
>      (match_operand:V2HI 2 "register_operand" "")
Richard Sandiford Aug. 29, 2024, 5:15 p.m. UTC | #2 
Victor Do Nascimento <victor.donascimento@arm.com> writes:
> Hello,
>
> Gentle reminder for this simple renaming patch :)

OK, thanks.

Richard

> Thanks,
> Victor
>
> On 8/15/24 09:44, Victor Do Nascimento wrote:
>> Following the migration of the dot_prod optab from a direct to a
>> conversion-type optab, ensure all back-end patterns incorporate the
>> second machine mode into pattern names.
>> 
>> gcc/ChangeLog:
>> 
>> 	* config/c6x/c6x.md (sdot_prodv2hi): Renamed to...
>> 	(sdot_prodsiv2hi): ...this.
>> ---
>>   gcc/config/c6x/c6x.md | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/gcc/config/c6x/c6x.md b/gcc/config/c6x/c6x.md
>> index 5964dd69d0d..ea9ffe8b4e1 100644
>> --- a/gcc/config/c6x/c6x.md
>> +++ b/gcc/config/c6x/c6x.md
>> @@ -3082,7 +3082,7 @@ (define_insn "<shift_code>v2hi3"
>>   ;; Widening vector multiply and dot product.
>>   ;; See c6x-mult.md.in for the define_insn patterns
>>   
>> -(define_expand "sdot_prodv2hi"
>> +(define_expand "sdot_prodsiv2hi"
>>     [(match_operand:SI 0 "register_operand" "")
>>      (match_operand:V2HI 1 "register_operand" "")
>>      (match_operand:V2HI 2 "register_operand" "")
diff mbox series

Patch

diff --git a/gcc/config/c6x/c6x.md b/gcc/config/c6x/c6x.md
index 5964dd69d0d..ea9ffe8b4e1 100644
--- a/gcc/config/c6x/c6x.md
+++ b/gcc/config/c6x/c6x.md
@@ -3082,7 +3082,7 @@  (define_insn "<shift_code>v2hi3"
 ;; Widening vector multiply and dot product.
 ;; See c6x-mult.md.in for the define_insn patterns
 
-(define_expand "sdot_prodv2hi"
+(define_expand "sdot_prodsiv2hi"
   [(match_operand:SI 0 "register_operand" "")
    (match_operand:V2HI 1 "register_operand" "")
    (match_operand:V2HI 2 "register_operand" "")