From patchwork Thu Aug 8 14:29:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 1970581 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=ihLEKZZO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WfqGt6s91z1ybS for ; Fri, 9 Aug 2024 00:31:18 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C948A3864816 for ; Thu, 8 Aug 2024 14:31:16 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 874B63861025 for ; Thu, 8 Aug 2024 14:30:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 874B63861025 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 874B63861025 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723127437; cv=none; b=oL3XS2EJBNGVDGAOyoiUIDJcz7FBO7JGO1zOIsqjLZfvCHLUA/qTNGIZSxrzNb5rzb1ZhC4n7Go434RhN5fIvVecK+rllst/A84YxrSoRVsgmCIcKVdEZn2tUnlrCFoxHehpsgMnUSK+X5+wScPiH+0+VUaS8W91qNd7Co6PcWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723127437; c=relaxed/simple; bh=KqUF2txA4Cvq9iUQ7d7z7N7WsCtljtig5bp3Y9AC1JI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c/gLOvp8CkeDhKQAVYEb9cADwWB6Wxz7MY67VQiWPAkvGFjmooRiLsJyt7Ik2BpNd7AoowGkR7DkoQKO7CtM5sbiv9yFZAJeNI/8aN/zJf74k9rpfEa8fou+9VjooXM/ni/ZjqpDP7STCLGgxQMDKfcQed3CsCe965IWkAV7Cto= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4280b3a7efaso7577045e9.0 for ; Thu, 08 Aug 2024 07:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1723127434; x=1723732234; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MziclQGT0mk9V7OwzeKUPVC3M3kdUwUTtkaEjw2fN2Q=; b=ihLEKZZO5zf12W0qRXtJV6JCtQLicN4Duuqs/SIPajFMS00oTZbfrgtGmAmFdNM2b9 mPR8FwMD2TK0bC/3JkLqsP9QmGEpi7n1wDs4R/rFQRNh7TdhudSr1Z+mO8kXX8FVIkR/ ec7WFhSO7rOwu5O4ug6w/kvXMQEo6tC8I2qL9Jb/w1PB6wNN4XVJKio9Kb+Gc4sYaQPn 0vx8SIcpcDdmK5XvWvkWohGIP4wsbYzGYt+gg2h5R/KNXk/PyJUBZs5MbRXoHrsrQOL7 B59UWuVv4l8/VpPWV4a+3upqheGm5OGpnHaAH3Oukm1OfMy6qDo0+7BBfoN7ScjGWMrX Bg+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723127434; x=1723732234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MziclQGT0mk9V7OwzeKUPVC3M3kdUwUTtkaEjw2fN2Q=; b=oIQss7XvrzbZuPBY7/EIFW6WXWt34E9RHLNXBlmRqaYm/rxaDBbLJN67oDKMD0EDdW npzfK1XgIKWQsA+NzU/L7SwnfUUpvP3hkixKXkxs5mYzUTcKaDh1cSy7Y5aEXoGaDGDb 2fBwBZPujQD97PgsMjpEGVzsoiAn7LF2ILL4B8EaTeu46FbTjh4AeYIIv7Vjey6igmrh k9VrMCZNV9QGv4mAWGuqtSh4UM0C1Ali3Jfj/u9GHZchHDac7azvlQk5QJliULznt7tv aibNeQMywp7EL9uqcHcP9biomurQkxpnJMSoI472eDvI4vhtA/SpKA4G4pDvYELGnfMB T9ew== X-Gm-Message-State: AOJu0Yx1q0AcOg72967mFvhZ9pyEoFSOlrsaAtDcKtoCwgoRUtxvkxT3 y3Gp6tBgJWAmYaNTROcL/Jz3X0VkgZ4W2myl8ENor2HG4MiPljkvAK2j1BiTMEI5L96ZkWHuAi8 5sw== X-Google-Smtp-Source: AGHT+IG/E/hB8J6FhTDjHHiuuBfRQ65mOrGukE1ppJFhtYfbuNaCkJkLJBFyQohvhFcRpPEMb8lAOw== X-Received: by 2002:a05:600c:1c99:b0:428:f1b4:3473 with SMTP id 5b1f17b1804b1-4290af0fc8amr16052005e9.26.1723127433986; Thu, 08 Aug 2024 07:30:33 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290c72d6c8sm25992015e9.9.2024.08.08.07.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 07:30:33 -0700 (PDT) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Javier Miranda Subject: [COMMITTED 1/6] ada: Finalization_Size raises Constraint_Error Date: Thu, 8 Aug 2024 16:29:43 +0200 Message-ID: <20240808142948.807190-1-poulhies@adacore.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org From: Javier Miranda When the attribute Finalization_Size is applied to an interface type object, the compiler-generated code fails at runtime, raising a Constraint_Error exception. gcc/ada/ * exp_attr.adb (Expand_N_Attribute_Reference) : If the prefix is an interface type, generate code to obtain its address and displace it to reference the base of the object. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_attr.adb | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/gcc/ada/exp_attr.adb b/gcc/ada/exp_attr.adb index 13c7444ca87..6475308f71b 100644 --- a/gcc/ada/exp_attr.adb +++ b/gcc/ada/exp_attr.adb @@ -3688,11 +3688,34 @@ package body Exp_Attr is -- Local variables - Size : Entity_Id; + P_Loc : constant Source_Ptr := Sloc (Pref); + Size : Entity_Id; -- Start of processing for Finalization_Size begin + -- If the prefix is an interface type, generate code to obtain its + -- address and displace it to reference the base of the object. + + if Is_Interface (Ptyp) then + -- Generate: + -- Ptyp!(tag_ptr!($base_address (ptr.all'address)).all) + + Rewrite (Pref, + Unchecked_Convert_To (Ptyp, + Make_Explicit_Dereference (P_Loc, + Unchecked_Convert_To (RTE (RE_Tag_Ptr), + Make_Function_Call (P_Loc, + Name => New_Occurrence_Of + (RTE (RE_Base_Address), P_Loc), + Parameter_Associations => + New_List ( + Make_Attribute_Reference (P_Loc, + Prefix => Duplicate_Subexpr (Pref), + Attribute_Name => Name_Address))))))); + Analyze_And_Resolve (Pref, Ptyp); + end if; + -- If the prefix is the dereference of an access value subject to -- pragma No_Heap_Finalization, then no header has been added.