From patchwork Thu Jul 25 22:12:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 1964927 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UV4adMje; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WVQCH2zjQz1yY9 for ; Fri, 26 Jul 2024 08:14:03 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95E8A385DDFB for ; Thu, 25 Jul 2024 22:14:01 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 245713858288 for ; Thu, 25 Jul 2024 22:13:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 245713858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 245713858288 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721945584; cv=none; b=eD+f97k+/F1QlRvnt7R2DP+naZU13+wyZrSPlf0BT1XT8edZ8fO3mYeY+FEZiEqBkbzEYZ8yGwKEhePmNd6T+dhZURiaJgoq5JzycbqGdlO+Zhoel3xP0mbB1kgWdnlqcoRZXfDOnGhTgPvPRi6PvyurpqHE28srJg/yp4+mLRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721945584; c=relaxed/simple; bh=jC6sCS3a6ATAG740W+hQBjfq8I4QDtLZvSMwt1nbm0g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=a7OAGKVR+xn/ozARVFA1Dbw87B1hD1Ks/D2NdlTG2TRWuPBybcNm2etjPWVi/CvQitHnEqScXCqzSWLZFLTapZXXz7FN6LMENZvGw+794Oh6QYU4211ZCdfPslM6ewl0PblEcIfETzGyl3jIPqPjsyuc95hWy2ojJ39E1tawXvw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721945582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2GtLADpI8K+Dy80oy22OKFEESa0LcMUQdNq8zN6wEek=; b=UV4adMjep4IAjkkrcaeqFQPiHte9SWnMgoQAlSVZiVoRHLjppIf2qcdK9Wj4DzeZX1g0BT I0mpS5EkpEnTBcSD/pG2F2wxkXE0FN1/oPKuK2wArctXbhzE0Y/Ka2BQU5x13N3MXBxciX +y3KJHnragqfg7qXqO311rIHFENm5eg= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-w-yFp2ghNIqM4PvFMyRVzA-1; Thu, 25 Jul 2024 18:13:00 -0400 X-MC-Unique: w-yFp2ghNIqM4PvFMyRVzA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7897A195608B; Thu, 25 Jul 2024 22:12:59 +0000 (UTC) Received: from localhost (unknown [10.42.28.14]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B317A1955D42; Thu, 25 Jul 2024 22:12:57 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Remove std::basic_format_args default constructor (LWG 4106) Date: Thu, 25 Jul 2024 23:12:52 +0100 Message-ID: <20240725221256.151157-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Tested x86_64-linux. Pushed to trunk. -- >8 -- There's no valid use case for default constructing this type, so the committee approved removing the default constructor. libstdc++-v3/ChangeLog: * include/std/format (basic_format_args): Remove default constructor, as per LWG 4106. * testsuite/std/format/arguments/args.cc: Check it isn't default constructible. --- libstdc++-v3/include/std/format | 2 -- libstdc++-v3/testsuite/std/format/arguments/args.cc | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 16cee0d3c74..8f6a82a1fd4 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -3667,8 +3667,6 @@ namespace __format { return {_Format_arg::template _S_to_enum<_Args>()...}; } public: - basic_format_args() noexcept = default; - template basic_format_args(const _Store<_Args...>& __store) noexcept; diff --git a/libstdc++-v3/testsuite/std/format/arguments/args.cc b/libstdc++-v3/testsuite/std/format/arguments/args.cc index eba129ff894..16ca71caecb 100644 --- a/libstdc++-v3/testsuite/std/format/arguments/args.cc +++ b/libstdc++-v3/testsuite/std/format/arguments/args.cc @@ -3,6 +3,10 @@ #include #include +// LWG 4106. basic_format_args should not be default-constructible +static_assert( ! std::is_default_constructible_v ); +static_assert( ! std::is_default_constructible_v ); + template bool equals(std::basic_format_arg fmt_arg, T expected) { return std::visit_format_arg([=](auto arg_val) {