| Message ID | 20240715101629.3571801-1-torbjorn.svensson@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: Disable finate math only for test [PR115826] | expand |
On Mon, 15 Jul 2024, Torbjörn SVENSSON wrote: > As the test case requires +-Inf and NaN to work and -ffast-math is added > by default for arm-none-eabi, re-enable non-finite math. Isn't /* { dg-add-options ieee } */ the canonical way to handle CPU/testsuite defaults? > gcc/testsuite/ChangeLog: > > PR testsuite/115826 > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > index dba95a81973..3e619a3fa5a 100644 > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > @@ -4,6 +4,9 @@ > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > /* { dg-require-effective-target vect_float } */ > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > +/* { dg-additional-options "-fno-finite-math-only" } */ > + > #include "tsvc.h" > > real_t s1281(struct args_t * func_args) >
Gentle ping :) As mentioned in the ticket, I would like to target this to trunk and releases/gcc-14. Kind regards, Torbjörn On 2024-07-15 12:16, Torbjörn SVENSSON wrote: > As the test case requires +-Inf and NaN to work and -ffast-math is added > by default for arm-none-eabi, re-enable non-finite math. > > gcc/testsuite/ChangeLog: > > PR testsuite/115826 > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > index dba95a81973..3e619a3fa5a 100644 > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > @@ -4,6 +4,9 @@ > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > /* { dg-require-effective-target vect_float } */ > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > +/* { dg-additional-options "-fno-finite-math-only" } */ > + > #include "tsvc.h" > > real_t s1281(struct args_t * func_args)
On Tue, 23 Jul 2024, Torbjorn SVENSSON wrote: > Gentle ping :) > > As mentioned in the ticket, I would like to target this to trunk and > releases/gcc-14. OK. Richard. > Kind regards, > Torbjörn > > On 2024-07-15 12:16, Torbjörn SVENSSON wrote: > > As the test case requires +-Inf and NaN to work and -ffast-math is added > > by default for arm-none-eabi, re-enable non-finite math. > > > > gcc/testsuite/ChangeLog: > > > > PR testsuite/115826 > > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > > --- > > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > index dba95a81973..3e619a3fa5a 100644 > > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > @@ -4,6 +4,9 @@ > > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > > /* { dg-require-effective-target vect_float } */ > > > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > > +/* { dg-additional-options "-fno-finite-math-only" } */ > > + > > #include "tsvc.h" > > > > real_t s1281(struct args_t * func_args) > >
On 2024-07-23 09:59, Richard Biener wrote: > On Tue, 23 Jul 2024, Torbjorn SVENSSON wrote: > >> Gentle ping :) >> >> As mentioned in the ticket, I would like to target this to trunk and >> releases/gcc-14. > > OK. > > Richard. > Pushed as releases/gcc-14.1.0-331-ga544898f6dd and basepoints/gcc-15-2224-g7793f5b4194. Kind regards, Torbjörn
diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c index dba95a81973..3e619a3fa5a 100644 --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c @@ -4,6 +4,9 @@ /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ /* { dg-require-effective-target vect_float } */ +/* This test requires +-Inf and NaN, so disable finite-math-only */ +/* { dg-additional-options "-fno-finite-math-only" } */ + #include "tsvc.h" real_t s1281(struct args_t * func_args)
As the test case requires +-Inf and NaN to work and -ffast-math is added by default for arm-none-eabi, re-enable non-finite math. gcc/testsuite/ChangeLog: PR testsuite/115826 * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> --- gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ 1 file changed, 3 insertions(+)