| Message ID | 20240707211059.90E8733EA6@hamza.pair.com |
|---|---|
| State | New |
| Headers | show |
| Series | [pushed] maintainer-scripts: Switch bug reporting URL to https | expand |
On Sun, 7 Jul 2024, Gerald Pfeifer wrote: > However, wouldn't it be so much better if we could import (or "import") > BUGURL from gcc/ where it is also set? Yes, it would seem reasonable to parse the ACX_BUGURL line in gcc/configure.ac. (It's not obvious that the URL should change more frequently than that line changes for other reasons that might break the parsing - but still, if there's an obvious error for failing to parse a plausible URL, that might be better than having the information in two places. The parsing would need to take place after update_web_docs_git clones the repository, and before it removes all files that are not documentation sources - or alternatively, consider gcc/configure.ac to be part of the documentation sources and so don't remove it at that stage.
diff --git a/maintainer-scripts/update_web_docs_git b/maintainer-scripts/update_web_docs_git index c651e567424..0d7b6c90fe9 100755 --- a/maintainer-scripts/update_web_docs_git +++ b/maintainer-scripts/update_web_docs_git @@ -45,7 +45,7 @@ MANUALS="cpp libiberty porting" -BUGURL="http://gcc.gnu.org/bugs/" +BUGURL="https://gcc.gnu.org/bugs/" CSS=/texinfo-manuals.css WWWBASE=${WWWBASE:-"/www/gcc/htdocs"}
So, this required quite some detective work to understand why https://gcc.gnu.org/onlinedocs/gcc/Bug-Reporting.html still referred to http://gcc.gnu.org/bugs/ *without* https from the following makeinfo snippet Bugs should be reported to the bug database at @value{BUGURL}. in gcc/doc/bugreport.texi when elsewhere in the tree we had updated BUGURL a while ago. Now it turns out I had already improved things there last year via commit 0c061da91a3657afdb3fac68e4595af685909a1a Author: Gerald Pfeifer <gerald@pfeifer.com> Date: Thu Mar 16 01:20:26 2023 +0100 maintainer-scripts: Abstract BUGURL in update_web_docs_git The URL where to report bugs is hard coded in two places; abstract that into one variable, defined up front. maintainer-scripts/ChangeLog: * update_web_docs_git (BUGURL): Introduce and use throughout. However, wouldn't it be so much better if we could import (or "import") BUGURL from gcc/ where it is also set? Any thoughts? Joseph, I believe you helped put the current mechanics in place? Gerald PS: In any case I pushed the patch below for now. maintainer-scripts: * update_web_docs_git (BUGURL): Switch to https. --- maintainer-scripts/update_web_docs_git | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)