From patchwork Wed Jun 19 23:36:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Collin Funk X-Patchwork-Id: 1949877 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=OZfGdgZ0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W4KrX2hF4z20Wb for ; Thu, 20 Jun 2024 09:41:14 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D37DF3887008 for ; Wed, 19 Jun 2024 23:41:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id D27E83858C41; Wed, 19 Jun 2024 23:40:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D27E83858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D27E83858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718840453; cv=none; b=p3FRz5gPijIRspUvHqLUoTJpR5/Qrk6W/u7dfQlPZlndj4mW5Y/RBfkuRk7TLN7Rc7nY1TXX7XO86llsppe/ozlHaOzcwGyFXDTacFPNotG6nsCqYgvSk+vE3ij4PnR2JQPs9if9gRHrAbyIiLZ7SS6SqqDTGiNOEtQJfF0Ij2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718840453; c=relaxed/simple; bh=zsX5BBfqc5Bv0QetNTKtcT9fKTpD7sypUHMHXNWTArc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=g89jIK6EKQzoz6mVGb8DTMVjzwIfnNKlMMVt31uZ29cWCp+iwFd76Xz8jJNQSsjtYBAOcLhb3fa8q+h9uKzM2FrzfFr4c9OSWXu705UEE5G5MeHKVZAai/m4gQorrhby9RYGGbJt5WkJx4bzh1OkdGjFDpBF9YhpKG7azGDMMvk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-6bce380eb9bso214016a12.0; Wed, 19 Jun 2024 16:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718840450; x=1719445250; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ujBL4isVYu74JntSJiPIfICS4ykXhoDqosDGKdOYwyo=; b=OZfGdgZ0HVQ5NQbsI/kwZyTIEmpavgysodmIqFlBvnMLjZJeixTbgJFLwrMUUw3I6N aKFuA9vjC8avo5fQp0btTIGNi7iDHgJIHlAf9dtMq+9LSbW0/mkQZlIQ3V4hVk+9eLV9 svKH0xzU+xmuiN73TcSXO1jCVy6CerbfMR7E9s+DdltPz02Awa5V5VxPNfFlRQ8O6z1M LByWCLJWwJ3ACZ3OKyUKemX/nytQ5rdGRSuhmM/yok57uGZiv+yDv5SGLomjfw2fyppZ C4eluPr7tjxIlQVs1353o3QJkdXkDVuyXMn1TVICUGUe3PDp1tiRduNF/U1NVKSz6zto cL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718840450; x=1719445250; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ujBL4isVYu74JntSJiPIfICS4ykXhoDqosDGKdOYwyo=; b=i4VQUkN6sIBqwHXXyTUQhruCGqCl38ghqWIXhv7SO92s8heEGri7TmTI6261p6kQKm pznXFhceF7COuH9M3TWjzY1kO2bCI2osQa3idmk5wGrZE9bZeAbcXnSUA7Ami9xZxXPC 35ZgdKRaA+DMjvvZQO0iaxwDiFEg7s5FG3lLGSo7KXVmEK9X1KbBmjQyvq0jfuHh71V2 OtNkiLPpKFZM904ZBYXRZDZnc2wr7UiJEkF4ql+oHpE/Rgkj/UCYFqxe3HOq1eTZ6nJq Hd1LpDQcJTWjPhxa+T4ihfLKJlL4php+XkWljCkd8deU51w+k+Oe6b0Gc3nisGj2Z3Gc 6GxA== X-Gm-Message-State: AOJu0YzFGkhWQ2DvZJldqd4hocs2tMdUwjRJUbgJKum8W4DfP7ghZ6QI VSo/+av1mm1cxnIBmTV3XeY+09auUktrMvW5Mp4UULS0fjH8+uSgHN/y/w== X-Google-Smtp-Source: AGHT+IGcgFZV2Z40v8Gu2A0+5c13rMU7FQm6npLvjgufUIPfI846NvHnJVsGRu0a6plqNpqz+znytg== X-Received: by 2002:a05:6a20:a89c:b0:1b5:d477:fcd5 with SMTP id adf61e73a8af0-1bcbb411065mr3578854637.25.1718840449550; Wed, 19 Jun 2024 16:40:49 -0700 (PDT) Received: from fedora.. (c-73-189-213-139.hsd1.ca.comcast.net. [73.189.213.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb8d9acsm11230181b3a.197.2024.06.19.16.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 16:40:49 -0700 (PDT) From: Collin Funk To: gcc-patches@gcc.gnu.org Cc: syq@gcc.gnu.org, Collin Funk Subject: [PATCH] build: Fix missing variable quotes and typo Date: Wed, 19 Jun 2024 16:36:50 -0700 Message-ID: <20240619234020.35486-2-collin.funk1@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: CAKcpw6VR9OPpHgrah20y-E5YSWxo4mSrrV5mTSEtcBzLUrWYOA@mail.gmail.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org I've just fixed the quotes and that typo in one patch. I hope you don't mind. When using Autoconf 2.69 and Automake 1.15.1 that copyright diff goes away. I'm not familiar with the gcc-autoregen bot but I think this should make it happy. -- >8 -- When dlopen and pthread_create are in libc the variable is set to "none required", therefore running configure will show the following errors: ./configure: line 8997: test: too many arguments ./configure: line 8999: test: too many arguments ./configure: line 9003: test: too many arguments ./configure: line 9005: test: =: unary operator expected ChangeLog: PR bootstrap/115453 * configure.ac: Quote variable result of AC_SEARCH_LIBS. Fix typo ac_cv_search_pthread_crate. * configure: Regenerate. Signed-off-by: Collin Funk --- configure | 8 ++++---- configure.ac | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 51576a41f30..51bf1d1add1 100755 --- a/configure +++ b/configure @@ -8994,15 +8994,15 @@ if test "$ac_res" != no; then : fi -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_create" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi diff --git a/configure.ac b/configure.ac index 5eda8dcdbf7..20457005e29 100644 --- a/configure.ac +++ b/configure.ac @@ -2045,15 +2045,15 @@ missing_rust_dynlibs=none AC_SEARCH_LIBS([dlopen], [dl]) AC_SEARCH_LIBS([pthread_create], [pthread]) -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_create" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi