From patchwork Fri Jun 14 10:31:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1947859 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jsvpSz/h; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6QM7HOe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jsvpSz/h; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6QM7HOe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W0wYj6dWxz20X9 for ; Fri, 14 Jun 2024 20:31:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D55C3882176 for ; Fri, 14 Jun 2024 10:31:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B9702388206F; Fri, 14 Jun 2024 10:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9702388206F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9702388206F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718361078; cv=none; b=pcoSX88G2udZ5Bx2SY9avGTQMKwMFLWi3YGtjjN0Z8fbhIjMVe9hb3DMflGkiB5Di0vQQpPZAD44BF7D8mFf2dCaWMFvW4Hpfk8AVAeuuDFpxbMte196jnVaMxrHwqtxAMucLsv6BJHHETmHJiiPvoRViNLl1zUSGWusgAYPrG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718361078; c=relaxed/simple; bh=IP869S8taq3xnvBKpYXoDcWDgehpzmWOJrZUfaVlzIc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=RFuDFZOlkeGlNSrmYBaXwvN1faQQkUFlWLpfgNuZuTEFdXF8J5OOhoO0A3p31IGFALvnk613EW55RPbjA/EcdH9SPe1l9uWe/wkIAN4QXfWXAz4yxkenUz3SjNKjpo7wYG4brdCT9bzuSgJubQB3gK7uZQ2Sn3VY120qDMF8/eE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7F62D20336; Fri, 14 Jun 2024 10:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718361075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=AP7uQABgDUnS3gYvwsnDDD3hziaSUGTFSEUPYoy3oLM=; b=jsvpSz/hcQtjsKhwimE5DE1PzkrtJp5W5M91hs2Phkt2lzBC+pe12PVDYf8J9XMuF7olQD 6nKqr6thel63gMFBejjhMOBhNRob1vT7H/RIG6G0xYtW/5sOe4y4H4ETRH1p+H9Eod83GH cKquro6efuo+65O7iYtaMaKidp5SMfQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718361075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=AP7uQABgDUnS3gYvwsnDDD3hziaSUGTFSEUPYoy3oLM=; b=w6QM7HOedplkcAFbClwoYKEpe72HY1mEev8VXftjk79UlwTMNmXaWW+znpx1MXrcpXU83k O9/vxLKGl/Wjj8Bg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jsvpSz/h"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=w6QM7HOe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718361075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=AP7uQABgDUnS3gYvwsnDDD3hziaSUGTFSEUPYoy3oLM=; b=jsvpSz/hcQtjsKhwimE5DE1PzkrtJp5W5M91hs2Phkt2lzBC+pe12PVDYf8J9XMuF7olQD 6nKqr6thel63gMFBejjhMOBhNRob1vT7H/RIG6G0xYtW/5sOe4y4H4ETRH1p+H9Eod83GH cKquro6efuo+65O7iYtaMaKidp5SMfQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718361075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=AP7uQABgDUnS3gYvwsnDDD3hziaSUGTFSEUPYoy3oLM=; b=w6QM7HOedplkcAFbClwoYKEpe72HY1mEev8VXftjk79UlwTMNmXaWW+znpx1MXrcpXU83k O9/vxLKGl/Wjj8Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1DB0213AB1; Fri, 14 Jun 2024 10:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SS6ZBfMbbGZyCAAAD6G6ig (envelope-from ); Fri, 14 Jun 2024 10:31:15 +0000 Date: Fri, 14 Jun 2024 12:31:10 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: hongtao.liu@intel.com, ebotcazou@libertysurf.fr, krebbel@linux.ibm.com, linkw@gcc.gnu.org, syq@gcc.gnu.org, xuchenghua@loongson.cn, ams@baylibre.com, richard.sandiford@arm.com, richard.earnshaw@arm.com Subject: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab MIME-Version: 1.0 Message-Id: <20240614103115.1DB0213AB1@imap1.dmz-prg2.suse.org> X-Spamd-Result: default: False [-5.17 / 50.00]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; BAYES_HAM(-1.66)[92.88%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[10]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 7F62D20336 X-Spam-Score: -5.17 X-Spam-Level: X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The following retires vcond{,u,eq} optabs by stopping to use them from the middle-end. Targets instead (should) implement vcond_mask and vec_cmp{,u,eq} optabs. The PR this change refers to lists possibly affected targets - those implementing these patterns, and in particular it lists mips, sparc and ia64 as targets that most definitely will regress while others might simply remove their vcond{,u,eq} patterns. I'd appreciate testing, I do not expect fallout for x86 or arm/aarch64. I know riscv doesn't implement any of the legacy optabs. But less maintained vector targets might need adjustments. I want to get rid of those optabs for GCC 15. If I don't hear from you I will assume your target is fine. Thanks, Richard. PR middle-end/114189 * optabs-query.h (get_vcond_icode): Always return CODE_FOR_nothing. (get_vcond_eq_icode): Likewise. --- gcc/optabs-query.h | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/gcc/optabs-query.h b/gcc/optabs-query.h index 0cb2c21ba85..31fbce80175 100644 --- a/gcc/optabs-query.h +++ b/gcc/optabs-query.h @@ -112,14 +112,9 @@ get_vec_cmp_eq_icode (machine_mode vmode, machine_mode mask_mode) mode CMODE, unsigned if UNS is true, resulting in a value of mode VMODE. */ inline enum insn_code -get_vcond_icode (machine_mode vmode, machine_mode cmode, bool uns) +get_vcond_icode (machine_mode, machine_mode, bool) { - enum insn_code icode = CODE_FOR_nothing; - if (uns) - icode = convert_optab_handler (vcondu_optab, vmode, cmode); - else - icode = convert_optab_handler (vcond_optab, vmode, cmode); - return icode; + return CODE_FOR_nothing; } /* Return insn code for a conditional operator with a mask mode @@ -135,9 +130,9 @@ get_vcond_mask_icode (machine_mode vmode, machine_mode mmode) mode CMODE (only EQ/NE), resulting in a value of mode VMODE. */ inline enum insn_code -get_vcond_eq_icode (machine_mode vmode, machine_mode cmode) +get_vcond_eq_icode (machine_mode, machine_mode) { - return convert_optab_handler (vcondeq_optab, vmode, cmode); + return CODE_FOR_nothing; } /* Enumerates the possible extraction_insn operations. */