From patchwork Tue May 28 08:14:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1940318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zky9XvaG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Xhc6vKID; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zky9XvaG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Xhc6vKID; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VpQLw2f8Hz20Q9 for ; Tue, 28 May 2024 18:15:51 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75E693882110 for ; Tue, 28 May 2024 08:15:49 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E80863858435 for ; Tue, 28 May 2024 08:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E80863858435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E80863858435 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716884112; cv=none; b=p7MroKiGBB9xqed5Urx6UOifHAz80kzZNSCSDq9ZPy609twt0GXNwKDIshY6ANjBt2zi1I9DmIzJAwygpmgOHUrThc6vK4rF3FlIRY4J+ZOAOvKG3D5n0oq5GSDKMLeQYYZ3OGT/hX7Q+vlG8XA2Qt5sUgdQXlDp2uDUPPxmDu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716884112; c=relaxed/simple; bh=AmNDXLGEoJoem0zwpJT9fJgycnQ4hUQ2K3ym3XSrKOo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=wrkoHD9SSDpCF82Tp+QyY1yMhnCsrRRD8NBhjXs0HyWNmUKVBDHnhgTSDsisGzwwIRhBhuPF6HiINOGjO4ErskzDLEHVu7bHhpNGzPlMR4uysp88DR1ZVG47CJQULyQJhat5k6GqVT0ZzRPScyczd/eXYPNU4dl54nofyU+mlvE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CC74022672 for ; Tue, 28 May 2024 08:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716884099; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=haPOijCfH/QJnr98Ar+aupyWiQiInbLXgvysKW0j4y4=; b=zky9XvaGcA03WV87x6SooKcDC0qXkeZD9HSZ+eC/yqBu5Xye00NuJxiQFg1MnctWWqFk2q ctToeHtBYmHd789+/w+tFkKh5Hbfgg70lZn3ITJTog4I+pZMP7PT9fJsTD/U8iV9gEn/Tg PcaakR9zZ9OAvA3sFHskNzgnx5NwIRU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716884099; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=haPOijCfH/QJnr98Ar+aupyWiQiInbLXgvysKW0j4y4=; b=Xhc6vKIDQdny7q/zvjll5YSLqCKFA+k9qudpnVkD/N4zsQYeA/lkGsGbPSLEef/+PQTYld d8sBn+jJLOhvV1Bw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716884099; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=haPOijCfH/QJnr98Ar+aupyWiQiInbLXgvysKW0j4y4=; b=zky9XvaGcA03WV87x6SooKcDC0qXkeZD9HSZ+eC/yqBu5Xye00NuJxiQFg1MnctWWqFk2q ctToeHtBYmHd789+/w+tFkKh5Hbfgg70lZn3ITJTog4I+pZMP7PT9fJsTD/U8iV9gEn/Tg PcaakR9zZ9OAvA3sFHskNzgnx5NwIRU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716884099; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=haPOijCfH/QJnr98Ar+aupyWiQiInbLXgvysKW0j4y4=; b=Xhc6vKIDQdny7q/zvjll5YSLqCKFA+k9qudpnVkD/N4zsQYeA/lkGsGbPSLEef/+PQTYld d8sBn+jJLOhvV1Bw== Date: Tue, 28 May 2024 10:14:59 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix SLP reduction neutral op value for pointer reductions MIME-Version: 1.0 X-Spam-Score: -1.57 X-Spam-Level: X-Spamd-Result: default: False [-1.57 / 50.00]; BAYES_HAM(-2.81)[99.17%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.99)[-0.986]; NEURAL_HAM_SHORT(-0.18)[-0.891]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240528081549.75E693882110@sourceware.org> When the neutral op is the initial value we might need to convert it from pointer to integer. Bootstrapped and tested no x86_64-unknown-linux-gnu, pushed. This shows with the SLP single-lane reduction discovery. * tree-vect-loop.cc (get_initial_defs_for_reduction): Convert neutral op to the vector component type. --- gcc/tree-vect-loop.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index 31abfe047a4..24a1239f016 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -5616,7 +5616,14 @@ get_initial_defs_for_reduction (loop_vec_info loop_vinfo, /* Get the def before the loop. In reduction chain we have only one initial value. Else we have as many as PHIs in the group. */ if (i >= initial_values.length () || (j > i && neutral_op)) - op = neutral_op; + { + if (!useless_type_conversion_p (TREE_TYPE (vector_type), + TREE_TYPE (neutral_op))) + neutral_op = gimple_convert (&ctor_seq, + TREE_TYPE (vector_type), + neutral_op); + op = neutral_op; + } else { if (!useless_type_conversion_p (TREE_TYPE (vector_type),