From patchwork Tue May 21 10:53:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2" X-Patchwork-Id: 1937340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ZLOJauY2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VkBCP4Gf9z1ydW for ; Tue, 21 May 2024 20:54:41 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D288938449C2 for ; Tue, 21 May 2024 10:54:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by sourceware.org (Postfix) with ESMTPS id 031B03844073 for ; Tue, 21 May 2024 10:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 031B03844073 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 031B03844073 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716288858; cv=none; b=VqwR8FGpO8UyE7FDhOplfCJ/3rVhs9i3OT8YeZLOEJsQiiqP3ebX+xAoj8+fkK11yC111BG6Y7sqM6UdReYPJZI62TG0apGjcpoC/aPe8sVYrIW7aTVwcyt3dzWeJb3NBSjS35i1/Lc/aL78GcseFKxac/9QC27qojAqm18akqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716288858; c=relaxed/simple; bh=xv9W3oBPN+UQvdiG9e78tkmcMfpT3ILxmf2N/Cinqg8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=qAhoSu5ql/IieiTmtuYCCYTCyojDPeXBgiTdOHeRQwRbsmRmfMfjBbiW4pUtNvmzg/fJxB0QOtAkz3zqZUIzhgSR307e++M/hu3Lpx807MWqywWh3COTtofxSzCRgpCk/iAvh1B6JdvpsvQ8OqzPD/ll0/ESKjlhAJILsvSpbJw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716288852; x=1747824852; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xv9W3oBPN+UQvdiG9e78tkmcMfpT3ILxmf2N/Cinqg8=; b=ZLOJauY24TWmqZluWQq4w5Qjm6KvNVlDK7KQi3rvSS1jbYd0sD9QAz7o 3vN+D1kUVLtSNCWjQ/CnwTMlKdvEE+noYKfSVfpanoVRQ+AVBLZ2NjzXv qSuEmTjgmf5m6mpbSTS1z8KlUyC9FXit1UqPy4jLis4adrUuz3qx8KwKp ZVhrdXdtRj7N23ZnjwZ5uQI3N91rA3ejvaYKW5EIFL0C0yPyu/hxnBv/L zyEZMm6vqIGiBaQ+/ivjfIC+e30xDW/oajmvHPNVlIqYcVmgO7Ul09U6Q JfWEF96XKaKSwW8X7Uc1WKx8FvcO2SwH2KTg/kZE5GTThXN83QyaDwD7l A==; X-CSE-ConnectionGUID: 6y9CH/Z7RfSlwfrkFzDmbw== X-CSE-MsgGUID: q8HfVWN8QtW6jGyd0JIM4g== X-IronPort-AV: E=McAfee;i="6600,9927,11078"; a="29980586" X-IronPort-AV: E=Sophos;i="6.08,177,1712646000"; d="scan'208";a="29980586" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2024 03:54:11 -0700 X-CSE-ConnectionGUID: HbZ2+jDGRWGAziYQelYd0Q== X-CSE-MsgGUID: MCgUuAhOQg62TAFf1igwlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,177,1712646000"; d="scan'208";a="37836020" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orviesa004.jf.intel.com with ESMTP; 21 May 2024 03:53:14 -0700 Received: from pli-ubuntu.sh.intel.com (pli-ubuntu.sh.intel.com [10.239.159.47]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 872B21008F74; Tue, 21 May 2024 18:53:13 +0800 (CST) From: pan2.li@intel.com To: gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, tamar.christina@arm.com, richard.guenther@gmail.com, Pan Li Subject: [PATCH v1 1/2] Match: Support __builtin_add_overflow branch form for unsigned SAT_ADD Date: Tue, 21 May 2024 18:53:12 +0800 Message-Id: <20240521105312.4112496-1-pan2.li@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Pan Li This patch would like to support the __builtin_add_overflow branch form for unsigned SAT_ADD. For example as below: uint64_t sat_add (uint64_t x, uint64_t y) { uint64_t ret; return __builtin_add_overflow (x, y, &ret) ? -1 : ret; } Different to the branchless version, we leverage the simplify to convert the branch version of SAT_ADD into branchless if and only if the backend has supported the IFN_SAT_ADD. Thus, the backend has the ability to choose branch or branchless implementation of .SAT_ADD. For example, some target can take care of branches code more optimally. When the target implement the IFN_SAT_ADD for unsigned and before this patch: uint64_t sat_add (uint64_t x, uint64_t y) { long unsigned int _1; long unsigned int _2; uint64_t _3; __complex__ long unsigned int _6; ;; basic block 2, loop depth 0 ;; pred: ENTRY _6 = .ADD_OVERFLOW (x_4(D), y_5(D)); _2 = IMAGPART_EXPR <_6>; if (_2 != 0) goto ; [35.00%] else goto ; [65.00%] ;; succ: 4 ;; 3 ;; basic block 3, loop depth 0 ;; pred: 2 _1 = REALPART_EXPR <_6>; ;; succ: 4 ;; basic block 4, loop depth 0 ;; pred: 3 ;; 2 # _3 = PHI <_1(3), 18446744073709551615(2)> return _3; ;; succ: EXIT } After this patch: uint64_t sat_add (uint64_t x, uint64_t y) { long unsigned int _12; ;; basic block 2, loop depth 0 ;; pred: ENTRY _12 = .SAT_ADD (x_4(D), y_5(D)); [tail call] return _12; ;; succ: EXIT } The below test suites are passed for this patch: * The x86 bootstrap test. * The x86 fully regression test. * The riscv fully regression test. gcc/ChangeLog: * match.pd: Add new simplify to convert branch SAT_ADD into branchless, if and only if backend implement the IFN. Signed-off-by: Pan Li Signed-off-by: Pan Li > --- gcc/match.pd | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index 0f9c34fa897..8b9ded98323 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -3094,6 +3094,16 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (match (unsigned_integer_sat_add @0 @1) (bit_ior:c (usadd_left_part_2 @0 @1) (usadd_right_part_2 @0 @1))) +#if GIMPLE + +(simplify + (cond (ne (imagpart (IFN_ADD_OVERFLOW:c@2 @0 @1)) integer_zerop) + integer_minus_onep (realpart @2)) + (if (direct_internal_fn_supported_p (IFN_SAT_ADD, type, OPTIMIZE_FOR_BOTH)) + (bit_ior (plus@3 @0 @1) (negate (convert (lt @3 @0)))))) + +#endif + /* x > y && x != XXX_MIN --> x > y x > y && x == XXX_MIN --> false . */ (for eqne (eq ne)