From patchwork Thu May 9 04:59:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1933326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jw6tiuVw; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VZfvW0sQ9z20fZ for ; Thu, 9 May 2024 14:59:51 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 97FD73849AF6 for ; Thu, 9 May 2024 04:59:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by sourceware.org (Postfix) with ESMTPS id 8C6D33858C35 for ; Thu, 9 May 2024 04:59:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C6D33858C35 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=localhost.redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C6D33858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.139.111.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715230771; cv=none; b=NtYbQu5IY1PDg1CWHIf8w8370I82g8+8HmF8IIRYIALVuFqeHCXONlKbi6tPdDzojuOoWqxoujgQ1dLPap/T9ZWllacAEAiUgOyk+hExbuKEo4ufWkNtndlCStafCfpeQVBfOkTExYU5M0wh+4SCPaw3ig26nugenEq33uHqp6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715230771; c=relaxed/simple; bh=GxlojKzMokwe3lQ7xqlGLxHXOlmWJTHHtCD3SEpqLOM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gHE/bRRZK+0AYK4IGzdZMB4eCDdqCpw+gBiYXxGNyZ5EwaQ6799M2m61zWT6U9IpERyyb4Z7Yhx2axM8w4wLVW+nTbE5aKCfc9Qn0kaiydysqvpxAxOTYI89sfQRtHoZmiszkVDaErX7OUOcGFnK8PVBo1FNMrlg49eOsYnonuk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715230769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BecM4HL3Fv5MtImBgscm8CvWb+erknWXdAx5milQ79k=; b=Jw6tiuVwWddEzT9V7NqJTt1qM/LoonuS43hKjElYhgtBKobS2KEwA9TI6GmdoR59adb4jX knW3OnMauZF4CtesiyeWUl02fEjy3U3mcYWqhIWO/U4CL7tgY5axrV3NSX1TJukUpYItb9 Lhd/UDZsOEtIZ7O5zj67oGqfUOK9R3o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-CEGUaubUMHO5Qa28cla8gw-1; Thu, 09 May 2024 00:59:28 -0400 X-MC-Unique: CEGUaubUMHO5Qa28cla8gw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15E59802314 for ; Thu, 9 May 2024 04:59:28 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5D793C30; Thu, 9 May 2024 04:59:27 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.18.1/8.17.1) with ESMTPS id 4494xPTn236752 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 9 May 2024 06:59:25 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.18.1/8.18.1/Submit) id 4494xP9H236749; Thu, 9 May 2024 06:59:25 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] [prange] Reword dispatch error message [PR114985] Date: Thu, 9 May 2024 06:59:21 +0200 Message-ID: <20240509045924.236714-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org After reading the ICE for the PR, it's obvious the error message is rather cryptic. This makes it less so. gcc/ChangeLog: * range-op.cc (range_op_handler::discriminator_fail): Reword error message. --- gcc/range-op.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/range-op.cc b/gcc/range-op.cc index 65f3843227d..a134af68141 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -207,7 +207,8 @@ range_op_handler::discriminator_fail (const vrange &r1, gcc_checking_assert (r1.m_discriminator < sizeof (name) - 1); gcc_checking_assert (r2.m_discriminator < sizeof (name) - 1); gcc_checking_assert (r3.m_discriminator < sizeof (name) - 1); - fprintf (stderr, "DISCRIMINATOR FAIL. Dispatch ====> RO_%c%c%c <====\n", + fprintf (stderr, + "Unsupported operand combination in dispatch: RO_%c%c%c\n", name[r1.m_discriminator], name[r2.m_discriminator], name[r3.m_discriminator]);