From patchwork Wed May 8 09:45:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1932925 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NQid9Zah; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=udsmk5ao; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NQid9Zah; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=udsmk5ao; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VZ9Hn31TGz1ymg for ; Wed, 8 May 2024 19:45:39 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE1C438AA27D for ; Wed, 8 May 2024 09:45:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id CB5513875453 for ; Wed, 8 May 2024 09:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB5513875453 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB5513875453 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715161519; cv=none; b=NyNmAmeUCP1N2hpX7IpnV2EcOGBLzkj4CXr64rmTocaZJvMZIMq/YdQFt7yH63A+29ALyGx1yLKX/xuFlPQpLV3/dEtAyudmSHlfeuwltTRAcYzv/QiTGyGICmPHe1Mk2n8fWEda8/VrRMRBz0AWcAYVdPebRuh6uQsc50IOp80= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715161519; c=relaxed/simple; bh=Am8x8fHsafHM/sdfynR4VJOXPwac4V0PJNoEwmOukok=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=YV9XjKIGCx5zrxrllG+ZM59hFYyyQpoHbwvWtrAGfADRLyuCLGENNpEOzkI1trg2o60uCi9JrnR2G1A0OcdKPyURfh34ZACEp9L/on0AT8i3c6ux7jEbqxgN/OQ0mZM5c37mG6Jv2lxKoG6wP2fQ/XezBd6lZd9yZvyOXm6AP3Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 88D955C76F for ; Wed, 8 May 2024 09:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715161515; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Aos9YSgnmwBgvRUPac/Our9lAkB6VAZAgpUEsT9JMVw=; b=NQid9Zah1iwECAg9ka6hhNFvri4cMS5m3tg559gpmwxZLLlj2LlWxHqB7v4CDXlR4Xvz99 ibrJIwmKUg+UPNUKXLcJzaJYyrKgbA3eAJgtP7NFb6oK+NnGkEeTOUIn+uGzwrb9g786hK A1xQJFHoFvoYmQwKeKNuOYReFDQ3ZSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715161515; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Aos9YSgnmwBgvRUPac/Our9lAkB6VAZAgpUEsT9JMVw=; b=udsmk5aod/ExFtkUFq6ZuxtXLbEIojWH92vE7GYhRsRmmvhw1ARrCRVvXElIo0t0WsP/oV YDbjlCN3igz3MmBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715161515; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Aos9YSgnmwBgvRUPac/Our9lAkB6VAZAgpUEsT9JMVw=; b=NQid9Zah1iwECAg9ka6hhNFvri4cMS5m3tg559gpmwxZLLlj2LlWxHqB7v4CDXlR4Xvz99 ibrJIwmKUg+UPNUKXLcJzaJYyrKgbA3eAJgtP7NFb6oK+NnGkEeTOUIn+uGzwrb9g786hK A1xQJFHoFvoYmQwKeKNuOYReFDQ3ZSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715161515; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Aos9YSgnmwBgvRUPac/Our9lAkB6VAZAgpUEsT9JMVw=; b=udsmk5aod/ExFtkUFq6ZuxtXLbEIojWH92vE7GYhRsRmmvhw1ARrCRVvXElIo0t0WsP/oV YDbjlCN3igz3MmBA== Date: Wed, 8 May 2024 11:45:15 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix non-grouped SLP load/store accounting in alignment peeling MIME-Version: 1.0 X-Spam-Score: -0.08 X-Spam-Level: X-Spamd-Result: default: False [-0.08 / 50.00]; MISSING_MID(2.50)[]; BAYES_HAM(-1.29)[89.96%]; NEURAL_HAM_LONG(-1.00)[-0.996]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240508094537.EE1C438AA27D@sourceware.org> When we have a non-grouped access we bogously multiply by zero. This shows most with single-lane SLP but also happens with the multi-lane splat case. Re-bootstrap & regtest running on x86_64-unknown-linux-gnu. I've ran into this latent bug on the force-slp branch. Richard. * tree-vect-data-refs.cc (vect_enhance_data_refs_alignment): Properly guard DR_GROUP_SIZE access with STMT_VINFO_GROUPED_ACCESS. --- gcc/tree-vect-data-refs.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index c531079d3bb..ae237407672 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -2290,8 +2290,11 @@ vect_enhance_data_refs_alignment (loop_vec_info loop_vinfo) if (unlimited_cost_model (LOOP_VINFO_LOOP (loop_vinfo))) { poly_uint64 vf = LOOP_VINFO_VECT_FACTOR (loop_vinfo); - nscalars = (STMT_SLP_TYPE (stmt_info) - ? vf * DR_GROUP_SIZE (stmt_info) : vf); + unsigned group_size = 1; + if (STMT_SLP_TYPE (stmt_info) + && STMT_VINFO_GROUPED_ACCESS (stmt_info)) + group_size = DR_GROUP_SIZE (stmt_info); + nscalars = vf * group_size; } /* Save info about DR in the hash table. Also include peeling