Message ID | 20240210152103.1825046-1-torbjorn.svensson@foss.st.com |
---|---|
State | New |
Headers | show |
Series | testsuite: Update test case to comply with GCC14 changes | expand |
On Feb 10, 2024, at 7:21 AM, Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> wrote: > > I have confirmed that this updated pr97969.c file still hangs with > gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969. > > Ok for trunk? Ok.
On 2024-02-11 20:01, Mike Stump wrote: > On Feb 10, 2024, at 7:21 AM, Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> wrote: >> >> I have confirmed that this updated pr97969.c file still hangs with >> gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969. >> >> Ok for trunk? > > Ok. Pushed as f85450819414700a7883a7de128b03f655f43d44.
diff --git a/gcc/testsuite/gcc.target/arm/pr97969.c b/gcc/testsuite/gcc.target/arm/pr97969.c index b8c3a23676a..af69e47ad9f 100644 --- a/gcc/testsuite/gcc.target/arm/pr97969.c +++ b/gcc/testsuite/gcc.target/arm/pr97969.c @@ -3,17 +3,17 @@ /* { dg-options "-std=c99 -fno-omit-frame-pointer -w -Os" } */ /* { dg-add-options arm_arch_v6m } */ -typedef a[23]; +typedef int a[23]; enum { b }; typedef struct { int c; char *e; - char f + char f; } d; typedef enum { g = 1 } h; typedef struct { h i; - int j + int j; } k; typedef struct { a l; @@ -29,9 +29,18 @@ typedef struct { d t; d *u; short v; - int w + int w; } aa; -c(char x, int y, char z, int ab) { + +void ae(short*, int, int); +void af(aa*, int, char, int); +int ag(int); +void ah(aa); +void ai(int); +void aj(aa); +int setjmp(); + +int c(char x, int y, char z, int ab) { aa ac; ac.r.i = 0; d ad; @@ -43,9 +52,9 @@ c(char x, int y, char z, int ab) { if (ag(0)) return 0; if (x) - ac.s = z + ab; + ac.s = (char*)(z + ab); else - ac.s = x + y; + ac.s = (char*)(x + y); ac.o |= g; if (!setjmp()) { ah(ac);
I have confirmed that this updated pr97969.c file still hangs with gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969. Ok for trunk? -- The test case for PR97969 needs updates in order to comply with recent changes in GCC14. Without these changes, failures like this can be seen on arm-none-eabi: .../pr97969.c:6:9: error: type defaults to 'int' in declaration of 'a' [-Wimplicit-int] .../pr97969.c:34:1: error: return type defaults to 'int' [-Wimplicit-int] .../pr97969.c:40:3: error: implicit declaration of function 'ae' [-Wimplicit-function-declaration] .../pr97969.c:42:3: error: implicit declaration of function 'af' [-Wimplicit-function-declaration] .../pr97969.c:43:7: error: implicit declaration of function 'ag' [-Wimplicit-function-declaration] .../pr97969.c:46:10: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion] .../pr97969.c:48:10: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion] .../pr97969.c:50:8: error: implicit declaration of function 'setjmp' [-Wimplicit-function-declaration] .../pr97969.c:51:5: error: implicit declaration of function 'ah' [-Wimplicit-function-declaration] .../pr97969.c:52:5: error: implicit declaration of function 'ai' [-Wimplicit-function-declaration] .../pr97969.c:54:5: error: implicit declaration of function 'aj' [-Wimplicit-function-declaration] Patch has been verified on Linux. gcc/testsuite/ChangeLog: * gcc.target/arm/pr97969.c: Update to comply with GCC14 changes. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> --- gcc/testsuite/gcc.target/arm/pr97969.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)