From patchwork Tue Jan 30 12:07:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 1892887 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=UBtk281J; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TPPpy2Ylkz23dQ for ; Tue, 30 Jan 2024 23:38:34 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54E09386C58E for ; Tue, 30 Jan 2024 12:38:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 2EFF33857C7D for ; Tue, 30 Jan 2024 12:11:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EFF33857C7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2EFF33857C7D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616725; cv=none; b=f9g2+pR64dJDSjju9z1aA8IIBv+yii999XuVaYuYno+GLOtUXFkRoEfrrVpu75iwDjl4w2NjAedBJQNnTisXYEa2Vxg26SACA5Qrxe6ESXj6fg9FZhX7tHP9TvQyNAd3ljSlDCdn/ENm6qL4q1uBV+3UZA9U/VBI58XBMHBIwq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616725; c=relaxed/simple; bh=fCJ+dW56/eRjZRX3mdZZWthnOSE8tDh/d3d1gJzSSsQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HvUiBjLkCuSagugw44S5gYHDcoi61knMvkB2GB0kYKZUo6c1eXR0hLYR5TOdCST60fMnE5yN4o7Ti8zbM6DUVbgoEAZakAKRmwzcgCtLvIemc/A+ovN8LWjA2l872GL4y9bQg2BEsvbJRLGkne0wA2pDtlGieoh3Q5A63xcCrZA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so3029358f8f.1 for ; Tue, 30 Jan 2024 04:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616691; x=1707221491; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=l6q8oLIWHaJf3t7j5fmWON5mJxrap4cF6WFh9DxU2ss=; b=UBtk281JBqcyOfrYSqTWjMHtvxQbEd/S70lDKDvQ+lf1WoHqqUxYrkRedoBBxiMmCE zdaSzb8h4dBSoek5jOq20Ks380N8kqDycVcPuS8KPngle+SgOs2ohoDuyibemz/qZHWL oYk2EXvbJbgyvmZZrOJy3lKU8r0hRUibBot4MjxsiUChaYKjvjwYU8bapsmjJ2Aief3v pSF5vv9KLW9uTBzYG4gm9fhVXk9jRrtRzjCxrYF9z1u0uuqdwH4/1I+Mwk+1sofOFDdA /zgLKtyGBlPiT0DekuOrxKT3+NWplfWm7xY6qqr9/Fczj991jM1+kakNHj4u1JEWkeu8 Ikkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616691; x=1707221491; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l6q8oLIWHaJf3t7j5fmWON5mJxrap4cF6WFh9DxU2ss=; b=iU95yxaPoKIBDg8mkqcg+c5dRaMVfpOtojW+YQ1KUjnQ14BA1YernehzqlRMSSMO3c 3ugBYC5th+u3cfvYTDwFDEB+9rWo+Y//a3LZXqKbHGfWKH4NF+jUTLElR7L5u1SYPn8q FEUmW6sCuCb2rDTI+K97/N/MTE/cjaKBqxSDK0l7Bwhm4OPzzOuupTSuG0tzCtOlhmg9 NiE8G4hy3hGDw0w3Zeruz8c2+AZp6e8rmwTZa+Z2oVJwb/qvuD6stZlmxC9VzVvIjkEb RBozc7VTamh/5wGPZMtnE/C/r645yqOddxaLjUc/JbNgCTW1fHE+4YcAXVKdMOsgBe7A nv/Q== X-Gm-Message-State: AOJu0YyRlg5TqPMZc4XV+PBgdg6Eok7w/a+MR+5CR6JITmharLMB7d+1 75+V7ew676t8su9Azr9DBUltx7q8FGUEXf1wIhL3+o1RgH9lU8AD2ynRUp5J/znWjAVgdSZDJDC 6UQ== X-Google-Smtp-Source: AGHT+IGcGfJvSCP3bq6Ltorz3H8N+OPKDmiHTuMrV4BXya6Ipz07syAXrWlgTQ7qT/4uZxbVDzE+nw== X-Received: by 2002:adf:ea51:0:b0:33a:e89f:1dc5 with SMTP id j17-20020adfea51000000b0033ae89f1dc5mr4753581wrn.23.1706616690779; Tue, 30 Jan 2024 04:11:30 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:30 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: [COMMITTED 055/101] gccrs: Add AST validation check for const in trait Date: Tue, 30 Jan 2024 13:07:11 +0100 Message-ID: <20240130121026.807464-58-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arthur.cohen@embecosm.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Pierre-Emmanuel Patry Add a new check in AST validation pass that checks that no function declaration in traits are declared const. gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add const check. * checks/errors/rust-ast-validation.h: Add visit function prototype. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/checks/errors/rust-ast-validation.cc | 10 ++++++++++ gcc/rust/checks/errors/rust-ast-validation.h | 1 + 2 files changed, 11 insertions(+) diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index 54276e8fd59..2743eb0ca29 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -117,6 +117,16 @@ ASTValidation::visit (AST::Function &function) AST::ContextualASTVisitor::visit (function); } +void +ASTValidation::visit (AST::TraitFunctionDecl &decl) +{ + const auto &qualifiers = decl.get_qualifiers (); + + if (context.back () == Context::TRAIT && qualifiers.is_const ()) + rust_error_at (decl.get_identifier ().get_locus (), ErrorCode::E0379, + "functions in traits cannot be declared const"); +} + void ASTValidation::visit (AST::Trait &trait) { diff --git a/gcc/rust/checks/errors/rust-ast-validation.h b/gcc/rust/checks/errors/rust-ast-validation.h index 01d923ceff3..963357f86cd 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.h +++ b/gcc/rust/checks/errors/rust-ast-validation.h @@ -42,6 +42,7 @@ public: virtual void visit (AST::Union &item); virtual void visit (AST::Function &function); virtual void visit (AST::Trait &trait); + virtual void visit (AST::TraitFunctionDecl &decl); }; } // namespace Rust