From patchwork Tue Jan 30 12:06:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 1892810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Ry4Gsvm9; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TPPKL43SYz23gZ for ; Tue, 30 Jan 2024 23:16:22 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77398385802A for ; Tue, 30 Jan 2024 12:16:20 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 38F4E3858013 for ; Tue, 30 Jan 2024 12:11:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38F4E3858013 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38F4E3858013 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616663; cv=none; b=s8nA2EePSbjhtncPNKef3bMatZ86zzatABHGPu0CkbHwBppTd1PPgL7hkrwqK2xDVs/j3VjLMbJmdxwVYf3NWJgwzqpe/JOWTZ/fLXncyjO8SDI3nXieJVN/niE0tVKRJAu4LNq8DE3yhqJSC0PMLs4jh/QAf9F9C223nFseutw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616663; c=relaxed/simple; bh=SARfAZZfppjviofKp//rwOzBoEsEhUL3XzVwaZQ5xPU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ClzYW2pJpX55nyeEacQ4GyOsMFgZSdKbL+TK5K0RYjgqNbYbI0l9WY7yEZ04w0JMmj6+ORDv3ouxwNu8CF1ajn5u8QgPDZyVmLX0kqMd1gSEaZ98JCIrYM042i/vbZnNtmSr4omr/NJwIWHeKWjLEUT0fNi0Rhs0KuCGarc6XFw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40faf6788d1so1638255e9.0 for ; Tue, 30 Jan 2024 04:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616658; x=1707221458; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JbjvnR7SPKCHqLG43as+0BfNS49SF2SIiL28v3ta9vc=; b=Ry4Gsvm9ZHQWc+5v2ZepNqR7CAa7j6uAx9ZpEL3qtid3ATQjyyxUDYGGdZ9FCiHc8b QQnPFYZKhZNTGlAm0s/SEpCwaiektzXHyno/cpTpYjAld64XCA2wxgSJ34tXhCm/tMp2 qBH5XcwtdZrXattL6oKNQF5aUzwdOZaHnQa77wMbyVTLPE3wO0X7v474zGpUWyRpC+Yj jRiTFNSc/za944g5DakkbJ7x5dfA21vleraMJmzx6H86evsJFoTES0yaWKYhmzKlEgkD wnl7mmgDI1CR0ZpSspji8XcH8LNqmDTCgCrW8VrjiopkAl5iFlQJN/KgaNX8mp7QoFnp y+Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616658; x=1707221458; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JbjvnR7SPKCHqLG43as+0BfNS49SF2SIiL28v3ta9vc=; b=MCialAIdqZZiaa4EOR7Btv11Ak2Z1htT56En0ICmDa9O6WYJP8HOLZoQb2miVMgEUu +jNrAQQJenA4TyjpBjFZSJLZtD/tjUJYb15JDZWimcpsZ+dVPf1HZScg9LCxn5OnzBor l+lIryrEm0wqjbSnDrmZgEl8ZOsuRgaKX/v1VgMuLRUzGBPQ2vmsCRfp+TAHY+0OXShO at79mVikulIz9qRFE8wa2C97jw5zKhziBb5E7zKD5ZVFEonvMA+6zCAbl9zAGq/V5r70 xRls+0zsP7wK/mcp0agDiLHcT4XA/pczOC2FWqNo8+s/7u5OMU5hwdLvURsg48miY7rb M5eQ== X-Gm-Message-State: AOJu0Yx6ys5GFS4j2iR9W9KVncdZp8wQT+sJ+MNPP9GFVCe0pLCjIGZ+ Cp8exM5rlUQ7bLynv1NHtgEzwWYuVTpCh5AseQH4FRV2HWOJptIICpY2uFeB0puA3O5ukrJNCmS 5pw== X-Google-Smtp-Source: AGHT+IGTYGdiXCpmlwKztBNdScVle5XhD4f2xJgAL+3NPT8kMy8WoSPL6Lruuo3u/n1srjdpYK2v4g== X-Received: by 2002:adf:f285:0:b0:33a:f090:f758 with SMTP id k5-20020adff285000000b0033af090f758mr1424709wro.27.1706616658014; Tue, 30 Jan 2024 04:10:58 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:10:57 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Arthur Cohen Subject: [COMMITTED 011/101] gccrs: forever stack: Improve resolve_path implementation Date: Tue, 30 Jan 2024 13:06:27 +0100 Message-ID: <20240130121026.807464-14-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arthur.cohen@embecosm.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Arthur Cohen gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Do not copy segment when dereferencing iterator in `find_starting_point`. --- gcc/rust/resolve/rust-forever-stack.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/rust/resolve/rust-forever-stack.hxx b/gcc/rust/resolve/rust-forever-stack.hxx index 8f0ab66b18b..642135cda85 100644 --- a/gcc/rust/resolve/rust-forever-stack.hxx +++ b/gcc/rust/resolve/rust-forever-stack.hxx @@ -333,7 +333,7 @@ ForeverStack::find_starting_point (const std::vector &segments, for (; !is_last (iterator, segments); iterator++) { - auto seg = *iterator; + auto &seg = *iterator; auto is_self_or_crate = seg.is_crate_path_seg () || seg.is_lower_self_seg ();