From patchwork Tue Jan 2 11:55:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2" X-Patchwork-Id: 1881623 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=W5HnWXCc; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T4DS76CJ4z1ygb for ; Wed, 3 Jan 2024 00:37:42 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A1FAD3858435 for ; Tue, 2 Jan 2024 13:37:40 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 03CDD3858D32 for ; Tue, 2 Jan 2024 13:37:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03CDD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 03CDD3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.55.52.88 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704202637; cv=none; b=hRIKOy4a9xdbYNpERK8FTWVKp9tHwemspeJL2CNslhF5cX/YC+4SHBR5Q5ig4rrEyQET0jOdb7kzaDQOGbBjf91CpDZ9OQLz5oPDAQN/OUmF25KdVUshc+mU1Ja4gxVu92hyNcVSco4f1WljNTOmEqn11dtvqv1TLXtlzOievYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704202637; c=relaxed/simple; bh=IcxcBi3/yTwTXNjbJ6eWuTXMqUQFpuzSI8gtZ32lJvI=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=keVsf+QVjgrGE1ieo2WCQd/UMzhnfh9y7aI9n0QgXEW/OW0fhzu+d073ntYuRj8ltGj6x2Ie9cyOHBnucmiulKUcZ1xl8Ryq7wko58c7zUsYOVTmiodg6IdcHUTP8d5rfsuZbH+aVGlaP1prVCLjBnRnj4ooJUutYWxZxzelS2I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704202634; x=1735738634; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IcxcBi3/yTwTXNjbJ6eWuTXMqUQFpuzSI8gtZ32lJvI=; b=W5HnWXCcO7UNzRLp7ESxMsef5cCbMrNA67TakUWz/XrFFZs6cuVV8AXF gXOpsQpTBUqSDDHZKl9Bh9q4MG5Oquc4nQ/sFMM7vbfJJ76jtDFKGwQ0w KqrtftDUpcMlAa8I6/VbO0Vs9KYjHoUcTT0rr2f9b7VpjF9Dnw457OIlr AjGF8RB0F2hmDLmC3BvIHNmyf1eW6b28ntzqb7tEulKRHv0JM7x/kswCz mXP8WfIe71hhXNPU5x2ajGCwVB1jZApY4naRkrpdvFUU6BqJSGoaSMGQJ t4AxEDG4DkTrowWlmUvnfLKeUuK5a3FSMLiza6hGCurcAQCThBJ06G3f3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="428041833" X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="428041833" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 05:37:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="845584162" X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="845584162" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by fmsmga008.fm.intel.com with ESMTP; 02 Jan 2024 05:37:07 -0800 Received: from pli-ubuntu.sh.intel.com (pli-ubuntu.sh.intel.com [10.239.159.47]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 3EB131005686; Tue, 2 Jan 2024 21:37:06 +0800 (CST) From: pan2.li@intel.com To: gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, pan2.li@intel.com, yanzhang.wang@intel.com, kito.cheng@gmail.com, richard.guenther@gmail.com, jeffreyalaw@gmail.com Subject: [PATCH v3] RISC-V: Bugfix for doesn't honor no-signed-zeros option Date: Tue, 2 Jan 2024 19:55:38 +0800 Message-Id: <20240102115538.1471137-1-pan2.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231223110733.2565292-1-pan2.li@intel.com> References: <20231223110733.2565292-1-pan2.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Pan Li According to the sematics of no-signed-zeros option, the backend like RISC-V should treat the minus zero -0.0f as plus zero 0.0f. Consider below example with option -fno-signed-zeros. void test (float *a) { *a = -0.0; } We will generate code as below, which doesn't treat the minus zero as plus zero. test: lui a5,%hi(.LC0) flw fa5,%lo(.LC0)(a5) fsw fa5,0(a0) ret .LC0: .word -2147483648 // aka -0.0 (0x80000000 in hex) This patch would like to fix the bug and treat the minus zero -0.0 as plus zero, aka +0.0. Thus after this patch we will have asm code as below for the above sampe code. test: sw zero,0(a0) ret This patch also fix the run failure of the test case pr30957-1.c. The below tests are passed for this patch. * The riscv regression tests. * The pr30957-1.c run tests. gcc/ChangeLog: * config/riscv/constraints.md: Leverage func riscv_float_const_zero_rtx_p for predicating the rtx is const zero float or not. * config/riscv/predicates.md: Ditto. * config/riscv/riscv.cc (riscv_const_insns): Ditto. (riscv_float_const_zero_rtx_p): New func impl for predicating the rtx is const zero float or not. (riscv_const_zero_rtx_p): New func impl for predicating the rtx is const zero (both int and fp) or not. * config/riscv/riscv-protos.h (riscv_float_const_zero_rtx_p): New func decl. (riscv_const_zero_rtx_p): Ditto. * config/riscv/riscv.md: Making sure the operand[1] of movfp is CONST0_RTX when the operand[1] is const zero float. gcc/testsuite/ChangeLog: * gcc.target/riscv/no-signed-zeros-0.c: New test. * gcc.target/riscv/no-signed-zeros-1.c: New test. * gcc.target/riscv/no-signed-zeros-2.c: New test. * gcc.target/riscv/no-signed-zeros-3.c: New test. * gcc.target/riscv/no-signed-zeros-4.c: New test. * gcc.target/riscv/no-signed-zeros-5.c: New test. * gcc.target/riscv/no-signed-zeros-run-0.c: New test. * gcc.target/riscv/no-signed-zeros-run-1.c: New test. Signed-off-by: Pan Li --- gcc/config/riscv/constraints.md | 2 +- gcc/config/riscv/predicates.md | 2 +- gcc/config/riscv/riscv-protos.h | 2 + gcc/config/riscv/riscv.cc | 35 ++++++++++++- gcc/config/riscv/riscv.md | 49 ++++++++++++++++--- .../gcc.target/riscv/no-signed-zeros-0.c | 26 ++++++++++ .../gcc.target/riscv/no-signed-zeros-1.c | 28 +++++++++++ .../gcc.target/riscv/no-signed-zeros-2.c | 26 ++++++++++ .../gcc.target/riscv/no-signed-zeros-3.c | 28 +++++++++++ .../gcc.target/riscv/no-signed-zeros-4.c | 26 ++++++++++ .../gcc.target/riscv/no-signed-zeros-5.c | 28 +++++++++++ .../gcc.target/riscv/no-signed-zeros-run-0.c | 36 ++++++++++++++ .../gcc.target/riscv/no-signed-zeros-run-1.c | 36 ++++++++++++++ 13 files changed, 314 insertions(+), 10 deletions(-) create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-0.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-1.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-2.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-3.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-4.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-5.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-0.c create mode 100644 gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-1.c diff --git a/gcc/config/riscv/constraints.md b/gcc/config/riscv/constraints.md index de4359af00d..db1d5e1385f 100644 --- a/gcc/config/riscv/constraints.md +++ b/gcc/config/riscv/constraints.md @@ -108,7 +108,7 @@ (define_constraint "DnS" (define_constraint "G" "@internal" (and (match_code "const_double") - (match_test "op == CONST0_RTX (mode)"))) + (match_test "riscv_float_const_zero_rtx_p (op)"))) (define_memory_constraint "A" "An address that is held in a general-purpose register." diff --git a/gcc/config/riscv/predicates.md b/gcc/config/riscv/predicates.md index b87a6900841..b428d842101 100644 --- a/gcc/config/riscv/predicates.md +++ b/gcc/config/riscv/predicates.md @@ -78,7 +78,7 @@ (define_predicate "sleu_operand" (define_predicate "const_0_operand" (and (match_code "const_int,const_wide_int,const_double,const_vector") - (match_test "op == CONST0_RTX (GET_MODE (op))"))) + (match_test "riscv_const_zero_rtx_p (op)"))) (define_predicate "const_1_operand" (and (match_code "const_int,const_wide_int,const_vector") diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h index 31049ef7523..fcf30e084a3 100644 --- a/gcc/config/riscv/riscv-protos.h +++ b/gcc/config/riscv/riscv-protos.h @@ -131,6 +131,8 @@ extern void riscv_asm_output_external (FILE *, const tree, const char *); extern bool riscv_zcmp_valid_stack_adj_bytes_p (HOST_WIDE_INT, int); extern void riscv_legitimize_poly_move (machine_mode, rtx, rtx, rtx); +extern bool riscv_float_const_zero_rtx_p (rtx); +extern bool riscv_const_zero_rtx_p (rtx); #ifdef RTX_CODE extern void riscv_expand_int_scc (rtx, enum rtx_code, rtx, rtx, bool *invert_ptr = 0); diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 0d1cbc5cb5f..a8ad86b7068 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -1635,7 +1635,7 @@ riscv_const_insns (rtx x) return 1; /* We can use x0 to load floating-point zero. */ - return x == CONST0_RTX (GET_MODE (x)) ? 1 : 0; + return riscv_float_const_zero_rtx_p (x) ? 1 : 0; case CONST_VECTOR: { /* TODO: This is not accurate, we will need to @@ -9481,6 +9481,39 @@ riscv_zcmp_valid_stack_adj_bytes_p (HOST_WIDE_INT total, int regs_num) || additioanl_bytes == ZCMP_MAX_SPIMM * ZCMP_SP_INC_STEP; } +/* Return true if rtx op is const zero of the floating-point. */ +bool +riscv_float_const_zero_rtx_p (rtx op) +{ + machine_mode mode = GET_MODE (op); + + if (GET_MODE_CLASS (mode) != MODE_FLOAT) + return false; + + if (GET_CODE (op) != CONST_DOUBLE) + return false; + + const struct real_value *op_rvalue = CONST_DOUBLE_REAL_VALUE (op); + + if (REAL_VALUE_MINUS_ZERO (*op_rvalue)) + return !HONOR_SIGNED_ZEROS (mode); + + return real_equal (op_rvalue, &dconst0); +} + +/* Return true if rtx op is const zero, include both the integer + and floating-point. */ +bool +riscv_const_zero_rtx_p (rtx op) +{ + machine_mode mode = GET_MODE (op); + + if (GET_MODE_CLASS (mode) == MODE_FLOAT) + return riscv_float_const_zero_rtx_p (op); + + return op == CONST0_RTX (mode); +} + /* Return true if it's valid gpr_save pattern. */ bool diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md index 68f7203b676..cd429f6dcdd 100644 --- a/gcc/config/riscv/riscv.md +++ b/gcc/config/riscv/riscv.md @@ -1878,7 +1878,12 @@ (define_insn "*movhf_hardfloat" "TARGET_ZFHMIN && (register_operand (operands[0], HFmode) || reg_or_0_operand (operands[1], HFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "fmove,fmove,mtc,fpload,fpstore,store,mtc,mfc,move,load,store") (set_attr "type" "fmove") (set_attr "mode" "HF")]) @@ -1889,7 +1894,12 @@ (define_insn "*movhf_softfloat" "!TARGET_ZFHMIN && (register_operand (operands[0], HFmode) || reg_or_0_operand (operands[1], HFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "fmove,move,load,store,mtc,mfc") (set_attr "type" "fmove") (set_attr "mode" "HF")]) @@ -2243,7 +2253,12 @@ (define_insn "*movsf_hardfloat" "TARGET_HARD_FLOAT && (register_operand (operands[0], SFmode) || reg_or_0_operand (operands[1], SFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "fmove,fmove,mtc,fpload,fpstore,store,mtc,mfc,move,load,store") (set_attr "type" "fmove") (set_attr "mode" "SF")]) @@ -2254,7 +2269,12 @@ (define_insn "*movsf_softfloat" "!TARGET_HARD_FLOAT && (register_operand (operands[0], SFmode) || reg_or_0_operand (operands[1], SFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "move,load,store") (set_attr "type" "fmove") (set_attr "mode" "SF")]) @@ -2279,7 +2299,12 @@ (define_insn "*movdf_hardfloat_rv32" "!TARGET_64BIT && TARGET_DOUBLE_FLOAT && (register_operand (operands[0], DFmode) || reg_or_0_operand (operands[1], DFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "fmove,fmove,mtc,fpload,fpstore,store,mtc,mfc,move,load,store") (set_attr "type" "fmove") (set_attr "mode" "DF")]) @@ -2290,7 +2315,12 @@ (define_insn "*movdf_hardfloat_rv64" "TARGET_64BIT && TARGET_DOUBLE_FLOAT && (register_operand (operands[0], DFmode) || reg_or_0_operand (operands[1], DFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "fmove,fmove,mtc,fpload,fpstore,store,mtc,mfc,move,load,store") (set_attr "type" "fmove") (set_attr "mode" "DF")]) @@ -2301,7 +2331,12 @@ (define_insn "*movdf_softfloat" "!TARGET_DOUBLE_FLOAT && (register_operand (operands[0], DFmode) || reg_or_0_operand (operands[1], DFmode))" - { return riscv_output_move (operands[0], operands[1]); } + { + if (riscv_float_const_zero_rtx_p (operands[1])) + operands[1] = CONST0_RTX (GET_MODE (operands[1])); + + return riscv_output_move (operands[0], operands[1]); + } [(set_attr "move_type" "move,load,store") (set_attr "type" "fmove") (set_attr "mode" "DF")]) diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-0.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-0.c new file mode 100644 index 00000000000..1eda13a3406 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-0.c @@ -0,0 +1,26 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +/* +** test_float_plus_zero_assign: +** sw\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_plus_zero_assign (float *a) +{ + *a = +0.0; +} + +/* +** test_float_plus_zero_assign: +** sw\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_minus_zero_assign (float *a) +{ + *a = -0.0; +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-1.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-1.c new file mode 100644 index 00000000000..8041ec3ea95 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-1.c @@ -0,0 +1,28 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +extern void float_assign (float *a, float b); + +/* +** test_float_plus_zero_assign: +** fmv\.s\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_plus_zero_assign (float *a) +{ + float_assign (a, +0.0); +} + +/* +** test_float_minus_zero_assign: +** fmv\.s\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_minus_zero_assign (float *a) +{ + float_assign (a, -0.0); +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-2.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-2.c new file mode 100644 index 00000000000..a6996dae4de --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-2.c @@ -0,0 +1,26 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +/* +** test_float_plus_zero_assign: +** sd\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_plus_zero_assign (double *a) +{ + *a = +0.0; +} + +/* +** test_float_plus_zero_assign: +** sd\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_minus_zero_assign (double *a) +{ + *a = -0.0; +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-3.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-3.c new file mode 100644 index 00000000000..b4ba8a247df --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-3.c @@ -0,0 +1,28 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +extern void float_assign (double *a, double b); + +/* +** test_float_plus_zero_assign: +** fmv\.d\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_plus_zero_assign (double *a) +{ + float_assign (a, +0.0); +} + +/* +** test_float_minus_zero_assign: +** fmv\.d\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_minus_zero_assign (double *a) +{ + float_assign (a, -0.0); +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-4.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-4.c new file mode 100644 index 00000000000..60acf7155d3 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-4.c @@ -0,0 +1,26 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv_zfh -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +/* +** test_float_plus_zero_assign: +** sh\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_plus_zero_assign (_Float16 *a) +{ + *a = +0.0; +} + +/* +** test_float_plus_zero_assign: +** sh\s+zero,0\([atx][0-9]+\) +** ret +*/ +void +test_float_minus_zero_assign (_Float16 *a) +{ + *a = -0.0; +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-5.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-5.c new file mode 100644 index 00000000000..d10efbeb37b --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-5.c @@ -0,0 +1,28 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv_zfh -mabi=lp64d -O3 -fno-signed-zeros -fno-schedule-insns -fno-schedule-insns2" } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ +/* { dg-final { check-function-bodies "**" "" } } */ + +extern void float_assign (_Float16 *a, _Float16 b); + +/* +** test_float_plus_zero_assign: +** fmv\.h\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_plus_zero_assign (_Float16 *a) +{ + float_assign (a, +0.0); +} + +/* +** test_float_minus_zero_assign: +** fmv\.h\.x\s+fa[0-9]+,\s*zero +** tail\s+float_assign +*/ +void +test_float_minus_zero_assign (_Float16 *a) +{ + float_assign (a, -0.0); +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-0.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-0.c new file mode 100644 index 00000000000..347e4b0ff74 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-0.c @@ -0,0 +1,36 @@ +/* { dg-do run { target { riscv_v } } } */ +/* { dg-additional-options "-std=c99 -O3 -fno-signed-zeros" } */ + +float f_val; + +void +__attribute__ ((noinline)) +test_float_plus_zero_assign (float *a) +{ + *a = +0.0; +} + +void +__attribute__ ((noinline)) +test_float_minus_zero_assign (float *a) +{ + *a = -0.0; +} + +int +main () +{ + f_val = -1.0; + test_float_plus_zero_assign (&f_val); + + if (__builtin_copysignf (1.0, f_val) != 1.0) + __builtin_abort (); + + f_val = -1.0; + test_float_minus_zero_assign (&f_val); + + if (__builtin_copysignf (1.0, f_val) != 1.0) + __builtin_abort (); + + return 0; +} diff --git a/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-1.c b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-1.c new file mode 100644 index 00000000000..1eb1edba457 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/no-signed-zeros-run-1.c @@ -0,0 +1,36 @@ +/* { dg-do run { target { riscv_v } } } */ +/* { dg-additional-options "-std=c99 -O3 -fno-signed-zeros" } */ + +double f_val; + +void +__attribute__ ((noinline)) +test_float_plus_zero_assign (double *a) +{ + *a = +0.0; +} + +void +__attribute__ ((noinline)) +test_float_minus_zero_assign (double *a) +{ + *a = -0.0; +} + +int +main () +{ + f_val = -1.0; + test_float_plus_zero_assign (&f_val); + + if (__builtin_copysignf (1.0, f_val) != 1.0) + __builtin_abort (); + + f_val = -1.0; + test_float_minus_zero_assign (&f_val); + + if (__builtin_copysignf (1.0, f_val) != 1.0) + __builtin_abort (); + + return 0; +}