| Message ID | 20231122020423.4699F20424@pchp3.se.axis.com |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: Tweak xfail bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120 | expand |
On Wed, Nov 22, 2023 at 3:04 AM Hans-Peter Nilsson <hp@axis.com> wrote: > > I added that xfail in February for { ilp32 && c++98_only } and it > looks like it's moved on to lp64 now. :-/ Noted by Rainer > Orth, see the PR. > > Tested cris-elf and x86_64-pc-linux-gnu w/wo. -m32. > Ok to commit? OK > -- >8 -- > The conditions under which this this bogus warning is > emitted has changed to not happen for 32-bit targets > anymore. Adjust accordingly. > > PR testsuite/106120 > * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for > lp64 targets with c++98. > --- > gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > index 275ecac01b5f..2024f8d93ca3 100644 > --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[]) > > int r_imin_imax = SR (INT_MIN, INT_MAX); > T (S (1), new int16_t[r_imin_imax]); > - T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { c++98_only } } } > + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { lp64 && c++98_only } } } > T (S (9), new int16_t[r_imin_imax * 2 + 1]); > > int r_0_imax = SR (0, INT_MAX); > -- > 2.30.2 >
diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C index 275ecac01b5f..2024f8d93ca3 100644 --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[]) int r_imin_imax = SR (INT_MIN, INT_MAX); T (S (1), new int16_t[r_imin_imax]); - T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { c++98_only } } } + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { lp64 && c++98_only } } } T (S (9), new int16_t[r_imin_imax * 2 + 1]); int r_0_imax = SR (0, INT_MAX);
I added that xfail in February for { ilp32 && c++98_only } and it looks like it's moved on to lp64 now. :-/ Noted by Rainer Orth, see the PR. Tested cris-elf and x86_64-pc-linux-gnu w/wo. -m32. Ok to commit? -- >8 -- The conditions under which this this bogus warning is emitted has changed to not happen for 32-bit targets anymore. Adjust accordingly. PR testsuite/106120 * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for lp64 targets with c++98. --- gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)