From patchwork Sat Nov 18 17:45:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 1865506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256 header.s=default header.b=F3sLpjBI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SXhBV1NKrz1yRV for ; Sun, 19 Nov 2023 04:50:26 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 86FD23858D33 for ; Sat, 18 Nov 2023 17:50:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 59B983858D32 for ; Sat, 18 Nov 2023 17:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59B983858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 59B983858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700329807; cv=none; b=w8ju5ZU5KdPq2z3+MY4W99BNkTkdQfctsJNeo5zo5T8L3HWPSrwEQkZOe2YsGXFybnyNXtri8835EaEjZoRPUIBN55bWhMMeIiiTg4S4eXpfmB3BOZ1BoGi/Y5NNQGWlNmTGFW8KXoN2CGOKvOGsLp/+b+aWC0xK+WclsX9Z/LI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700329807; c=relaxed/simple; bh=esat9NltwxlV9Y//5xHIh/mAyNLEt8GIwEYyS0ZR4Dc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nLyDGMvlV42DIyN1XWcQXWbmWmbTwHp5DbyfQ+E3l9/6y+MrfGtY4G7dTHei/hdkJ7bu4l9Sjy7mgcOBq8+Dsuwj0xw+rrLmP23+cP+mi+Cm1yp0gD1rThNH/9ZF2iIL/eZC7RPOJwXaLdH1auS/6hdMQbEEey1kbArhOPEmkhw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700329805; bh=esat9NltwxlV9Y//5xHIh/mAyNLEt8GIwEYyS0ZR4Dc=; h=From:To:Cc:Subject:Date:From; b=F3sLpjBIX78B/VRD0SL0g64u8m8IvAGXmttczN8o4xPHv8z4OMVohQzC9+6l45NG9 +99bK0LjbDC5JTg0nQytse8u80bMgYfrKyIHMGJtQkqmr22hGWNZ3+OXkcf8Dj0O7o D/OcTeEJFD7+4gRSVdKoIezXEJJGbScyAVGKCiAw= Received: from stargazer.. (unknown [IPv6:240e:358:1182:dc00:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 6364966B06; Sat, 18 Nov 2023 12:50:02 -0500 (EST) From: Xi Ruoyao To: gcc-patches@gcc.gnu.org Cc: chenglulu , i@xen0n.name, xuchenghua@loongson.cn, Xi Ruoyao Subject: [PATCH] LoongArch: Fix "-mexplict-relocs=none -mcmodel=medium" producing %call36 when the assembler does not support it Date: Sun, 19 Nov 2023 01:45:55 +0800 Message-ID: <20231118174554.25661-2-xry111@xry111.site> X-Mailer: git-send-email 2.42.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_STOCKGEN, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Even if !HAVE_AS_SUPPORT_CALL36, const_call_insn_operand should still return false when -mexplict-relocs=none -mcmodel=medium to make loongarch_legitimize_call_address emit la.local or la.global. gcc/ChangeLog: * config/loongarch/predicates.md (const_call_insn_operand): Remove buggy "HAVE_AS_SUPPORT_CALL36" conditions. Change "1" to "true" to make the coding style consistent. --- Not fully regtested, but it should be obvious and it indeed fixes the func-call-medium-*.c test failures. Ok for trunk? gcc/config/loongarch/predicates.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/config/loongarch/predicates.md b/gcc/config/loongarch/predicates.md index 56f7c48e126..d02e846cb12 100644 --- a/gcc/config/loongarch/predicates.md +++ b/gcc/config/loongarch/predicates.md @@ -444,21 +444,19 @@ (define_predicate "const_call_insn_operand" case SYMBOL_PCREL: if (TARGET_CMODEL_EXTREME || (TARGET_CMODEL_MEDIUM - && HAVE_AS_SUPPORT_CALL36 && (la_opt_explicit_relocs == EXPLICIT_RELOCS_NONE))) return false; else - return 1; + return true; case SYMBOL_GOT_DISP: if (TARGET_CMODEL_EXTREME || !flag_plt || (flag_plt && TARGET_CMODEL_MEDIUM - && HAVE_AS_SUPPORT_CALL36 && (la_opt_explicit_relocs == EXPLICIT_RELOCS_NONE))) return false; else - return 1; + return true; default: return false;