From patchwork Wed Sep 6 17:50:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edwin Lu X-Patchwork-Id: 1830505 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=VGnwAQJd; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Rgqgl5VqHz1yh5 for ; Thu, 7 Sep 2023 03:51:47 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0B5E385703A for ; Wed, 6 Sep 2023 17:51:45 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 182573857725 for ; Wed, 6 Sep 2023 17:50:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 182573857725 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-68e369ba5f8so90222b3a.2 for ; Wed, 06 Sep 2023 10:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694022642; x=1694627442; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KZADUiyHRXPLif/+6c3X45kWcmfASOAs0U5BsxEAfYM=; b=VGnwAQJdddheYD2mCv4KplFm3xw2pqkHq+uE0HzZxC0MZ4k0S0nlpHiBtxDQUEFddp fk3US6uUFGku7WukowBVcuZ5v/LDYqUYOVxQiU8D86lhyqvs1YoPAQjfV+PWFs1FRtlU OS4XtpyuNu5HhGbzDWhAU21P+15yprtsi8VmOzuVz7ZIm+VpEo8dN9ir85ko1BFgwNrj 6gQMExspypw5rj89omiNNFy8c5Wm+hxpwVgWKhgJJx+Yh/pFvvomhFgwt11IB0tLY8om iTz4CSsFeyasDsHsACpkbdA85hGGS/8Ca4/kPdG4nkxL0EMiObrNTyTt7xcodgizwYPG 3YEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694022642; x=1694627442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZADUiyHRXPLif/+6c3X45kWcmfASOAs0U5BsxEAfYM=; b=cr+RmIBrGazjd/2zbznpM98RsIE9Ulw8VgJGxRW2jL1DMTYTrWNVQ/O15hH4IiUaML 4VPL6y4R+LgG64IxpYw6GEQyceCqaMGwnbzylRtwKs2UAxHUnBI3BfViq5ASNhP31jyy cJs2X4EZ8G9OJgTGvp8jpAmSfIr0moCtVB+L2BAGUuYg+Hoh+ogEuREc2dLlOLEL5ao8 ywJ2B2+pRRk/jMFsP+D1QBiu8OxQqrXxpvAbOTi+6ZRcTRzvK5jefwAwOCz/UQexaBD6 dK6ioAXRkgf/+RwAMkfyghRj+nQZMgVn3KWqH4sZXHt31fREZYB3Gp6gbdc9Cdju4VAm BFng== X-Gm-Message-State: AOJu0YxPJTrXKh/M9PjZX5qBNsvxAbH6dyFZbYIaDwY2PoJq6h7JFdJB z8pHdDkMsXKn9Vnc7Vrl/EHiwmZwRjzaMpwYy58= X-Google-Smtp-Source: AGHT+IFQslFUirZxDwVWb0s8RPGeKWBYZ5wHRw1iNfzdlTdTWMf+6Ty9+0ZuDLG7m3es0aVZwxGFkA== X-Received: by 2002:a05:6a20:1057:b0:14d:e780:4007 with SMTP id gt23-20020a056a20105700b0014de7804007mr14118880pzc.42.1694022642099; Wed, 06 Sep 2023 10:50:42 -0700 (PDT) Received: from ewlu.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id f8-20020aa782c8000000b00687a4b70d1esm11017428pfn.218.2023.09.06.10.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 10:50:41 -0700 (PDT) From: Edwin Lu To: gcc-patches@gcc.gnu.org Subject: [PATCH 5/5] RISC-V: Remove Assert Protecting Types Date: Wed, 6 Sep 2023 10:50:23 -0700 Message-ID: <20230906175025.935887-6-ewlu@rivosinc.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230906175025.935887-1-ewlu@rivosinc.com> References: <20230906175025.935887-1-ewlu@rivosinc.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gnu-toolchain@rivosinc.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" This patch turns on the assert which ensures every instruction has type that is not TYPE_UNKNOWN. gcc/ChangeLog: * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert Signed-off-by: Edwin Lu --- gcc/config/riscv/riscv.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index ef63079de8e..f0576351cda 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -7330,11 +7330,9 @@ riscv_sched_variable_issue (FILE *, int, rtx_insn *insn, int more) if (get_attr_type (insn) == TYPE_GHOST) return 0; -#if 0 /* If we ever encounter an insn with an unknown type, trip an assert so we can find and fix this problem. */ gcc_assert (get_attr_type (insn) != TYPE_UNKNOWN); -#endif return more - 1; }