From patchwork Sat Aug 7 14:41:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1514687 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=fs/9T0Ry; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GhlS847kTz9s5R for ; Sun, 8 Aug 2021 00:42:30 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46D983857815 for ; Sat, 7 Aug 2021 14:42:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46D983857815 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1628347348; bh=9GgfL6XZVjxRP1R+fzdI0f4NJ/QEYR9xb+/DfUbx5sE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=fs/9T0RypQpmWdEad7oJ4ncmFWciU6cKvI6WZlaEEC5s9iH+O1YD5siu3ZM5cPotz vApZ/1sXmbUZ/eCVnwJX+0Ng+LtDxgJVrpW0d69sbay2Hiib/Cko6Xzr5D6NDZ/1kr yeA/VX/EMZj1uddKdMWaoqvq0Ph+g13gtyC793xQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 2EAFF3858404 for ; Sat, 7 Aug 2021 14:41:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EAFF3858404 Received: by mail-pl1-x629.google.com with SMTP id u2so11211753plg.10 for ; Sat, 07 Aug 2021 07:41:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9GgfL6XZVjxRP1R+fzdI0f4NJ/QEYR9xb+/DfUbx5sE=; b=tW/+wY+ShENFYcnC0W3LqxyQtj6w0jXzpXGqJHHfk4tcmjgMv/rJ7Ycy0UO1eJA23t Y+Rq3RQ7V92ch+HUHSHr4EVJOICZ9OK0Xtqk2Kd56q9G1XS3GpQrMQADa5AD5rKQzcol ZJNpbyzISbz6ZqqvPhG2+vWN9N+olNfOuEHVAc7D8AM/U3ZejyMLhBUJb3ZNsOkvnDN/ 7riNvHh/a52jm1RdqdkQbHEnVQhH2CTlEZ9OvrjxJi4/bObtWZIpnfu2bTKWlHj/hshl uAliv5CnUg0Pg5bk+8JEyeRbYtgBYrF5hzeHnWU3cuXzM1uy0Ah6YVBuOedgSMJrjkfh aglg== X-Gm-Message-State: AOAM532TrhA8NQYaG0oIEC5hEy14AmFHAbdW7d4W/lPmSbUuxhnYF1+o Xw7ii4auLkJkMbwI9xD857MnA8BQTyw= X-Google-Smtp-Source: ABdhPJwZlLzt6VYA+UblNrKULd5pdQBTIg28aP9U3rJRO9Vngm7WWo4JJuAkQGJFAYJ0QUCCon4w0A== X-Received: by 2002:a63:1d60:: with SMTP id d32mr1043410pgm.36.1628347304130; Sat, 07 Aug 2021 07:41:44 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id o8sm16237232pjh.20.2021.08.07.07.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Aug 2021 07:41:43 -0700 (PDT) Received: from gnu-tgl-2.localdomain (gnu-tgl-2 [192.168.1.34]) by gnu-cfl-2.localdomain (Postfix) with ESMTPS id A0910C02BD; Sat, 7 Aug 2021 07:41:42 -0700 (PDT) Received: from gnu-tgl-2.lan (localhost [IPv6:::1]) by gnu-tgl-2.localdomain (Postfix) with ESMTP id 8132A3002C2; Sat, 7 Aug 2021 07:41:32 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] x86: Optimize load of const all 1s float vectors Date: Sat, 7 Aug 2021 07:41:32 -0700 Message-Id: <20210807144132.3645400-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Gcc-patches" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: liuhongt Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Update vector_all_ones_operand to return true for const all 1s float vectors. gcc/ PR target/101804 * config/i386/predicates.md (vector_all_ones_operand): Return true for const all 1s float vectors. gcc/testsuite/ PR target/101804 * gcc.target/i386/avx2-gather-2.c: Pass -march=skylake instead of "-mavx2 -mtune=skylake". Scan vpcmpeqd. --- gcc/config/i386/predicates.md | 7 ++++--- gcc/testsuite/gcc.target/i386/avx2-gather-2.c | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md index 6aa1ea32627..9637e64ea58 100644 --- a/gcc/config/i386/predicates.md +++ b/gcc/config/i386/predicates.md @@ -1126,9 +1126,10 @@ (define_predicate "float_vector_all_ones_operand" /* Return true if operand is a vector constant that is all ones. */ (define_predicate "vector_all_ones_operand" - (and (match_code "const_vector") - (match_test "INTEGRAL_MODE_P (GET_MODE (op))") - (match_test "op == CONSTM1_RTX (GET_MODE (op))"))) + (ior (and (match_code "const_vector") + (match_test "INTEGRAL_MODE_P (GET_MODE (op))") + (match_test "op == CONSTM1_RTX (GET_MODE (op))")) + (match_operand 0 "float_vector_all_ones_operand"))) ; Return true when OP is operand acceptable for vector memory operand. ; Only AVX can have misaligned memory operand. diff --git a/gcc/testsuite/gcc.target/i386/avx2-gather-2.c b/gcc/testsuite/gcc.target/i386/avx2-gather-2.c index 1a704afd834..ad5ef73107c 100644 --- a/gcc/testsuite/gcc.target/i386/avx2-gather-2.c +++ b/gcc/testsuite/gcc.target/i386/avx2-gather-2.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-O3 -mavx2 -fdump-tree-vect-details -mtune=skylake" } */ +/* { dg-options "-O3 -fdump-tree-vect-details -march=skylake" } */ #include "avx2-gather-1.c" /* { dg-final { scan-tree-dump-times "vectorized 1 loops in function" 16 "vect" } } */ +/* { dg-final { scan-assembler "vpcmpeqd" } } */