From patchwork Fri Jul 2 17:12:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1500194 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=JMH+tCVS; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GGhVV4vYPz9sS8 for ; Sat, 3 Jul 2021 03:13:05 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2EF6E3848013 for ; Fri, 2 Jul 2021 17:13:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2EF6E3848013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1625245982; bh=LUjB21dKyuRO9fKH8jBf38899YAo/QIF+PqvY/80umw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=JMH+tCVSV73/0QZ4ckEhEduZ8L7UuOrhAcigSZeuXItoOEw/yW/qpu/iHbV+Hpun6 ZrNEv3Aj0lOg8NxBJ62BS1hMQA/AGB/+y74b0IJMEa+NJSm5w2avQX4CarJKhFUaVg XcLVU2oHNAo6zaB8OZESyB/I86zS6TMiNomKeXZM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id D68423851C0B for ; Fri, 2 Jul 2021 17:12:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D68423851C0B Received: by mail-pl1-x62b.google.com with SMTP id s13so2813687plg.12 for ; Fri, 02 Jul 2021 10:12:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LUjB21dKyuRO9fKH8jBf38899YAo/QIF+PqvY/80umw=; b=JZxSEaoDJzyeFDn52zkVoELsdd3nviooGSi0AmWuh0mDaxkG9bsrVc4ovsO7PIqNBs qID+8bUb/VazGutvBuRcHPGvYwBDeIGr56ynpZ8Kh6UErkHcjnzPyLsikoAtGhva59vd t14ZI3BpEjER9vZ2jCNuDVF4ZVjH01z3Gwk5vmigtLSKvGRXQM9m0ELKFD1wn5aCxWOW k33GwopiVzdlC45jBwcAE71jNZnTmo/JcupQGQRM+nNds2yn6C42QgDYCi8Osup/dlNW vFpEFYgUA1X3ec+a7u1Z3ntUgHRaJs5S7ljmCQ1oyoJCwp8Ia7gJE7Z0j3l09aCoUe7e 2Rkg== X-Gm-Message-State: AOAM532Jl3HZsbUHjhznfQ4Gg97vtOxaVlJe390r2Mi589mDSQgpmPRI ltsdhkQxwWiqTz9IKtFji3G6BvwFqz0= X-Google-Smtp-Source: ABdhPJys5GEyir8JtQJGDdram8wYbq8IjifXEhdAZ3/6CWNXcNUSwa/jI59LnSJ/lRT/uOyI0l8rdQ== X-Received: by 2002:a17:90b:793:: with SMTP id l19mr735958pjz.96.1625245937683; Fri, 02 Jul 2021 10:12:17 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.56.39.115]) by smtp.gmail.com with ESMTPSA id g6sm2790491pfr.87.2021.07.02.10.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 10:12:17 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id D338FC030E; Fri, 2 Jul 2021 10:12:15 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Don't use vec_duplicate on vector in CTOR expansion Date: Fri, 2 Jul 2021 10:12:15 -0700 Message-Id: <20210702171215.44912-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3032.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Gcc-patches" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: Richard Biener Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Since vec_duplicate only works on scalar, don't use it on vector in store constructor expansion. gcc/ PR middle-end/101294 * expr.c (store_constructor): Don't use vec_duplicate on vector. gcc/testsuite/ PR middle-end/101294 * gcc.dg/pr101294.c: New test. --- gcc/expr.c | 3 ++- gcc/testsuite/gcc.dg/pr101294.c | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr101294.c diff --git a/gcc/expr.c b/gcc/expr.c index 025033c9ecf..bd85bbfdd6f 100644 --- a/gcc/expr.c +++ b/gcc/expr.c @@ -7078,7 +7078,8 @@ store_constructor (tree exp, rtx target, int cleared, poly_int64 size, && eltmode == GET_MODE_INNER (mode) && ((icode = optab_handler (vec_duplicate_optab, mode)) != CODE_FOR_nothing) - && (elt = uniform_vector_p (exp))) + && (elt = uniform_vector_p (exp)) + && !VECTOR_TYPE_P (TREE_TYPE (elt))) { class expand_operand ops[2]; create_output_operand (&ops[0], target, mode); diff --git a/gcc/testsuite/gcc.dg/pr101294.c b/gcc/testsuite/gcc.dg/pr101294.c new file mode 100644 index 00000000000..ca59b35f4be --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr101294.c @@ -0,0 +1,15 @@ +/* PR middle-end/101294 */ +/* { dg-do compile } */ +/* { dg-options "-O0" } */ +/* { dg-additional-options "-mavx" { target avx } } */ + +typedef __attribute__((__vector_size__ (sizeof (unsigned long long)))) unsigned long long U; +typedef __attribute__((__vector_size__ (4 * sizeof (unsigned long long)))) unsigned long long V; + +extern U x; + +void +foo (void) +{ + x = __builtin_shufflevector ((U){}, (V){}, 3); +}