From patchwork Fri Nov 13 14:05:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 1399808 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=QJR9Q9GY; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CXgH36hzfz9sSs for ; Sat, 14 Nov 2020 01:05:50 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5D7C3A51404; Fri, 13 Nov 2020 14:05:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5D7C3A51404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1605276348; bh=SriTYcI9g3QiZ4T9ZcqIRloG24jYAas4klco1UnGreQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=QJR9Q9GYvpsA5KrT0/xctcvEbhy3UfO2kEczeL8jXJgtNfR6YQljefQ62aAWQ0PbD YMkLHQc4JGChWQKp0nJdLGuEsEKI4NqBsqEFO6lfnVNmJX0wuSguS41IpY+KosYf29 kBSLQ6blhgUy+DXlqkYJjDzH3r0QiVEi5861j7GM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050::465:102]) by sourceware.org (Postfix) with ESMTPS id 322C53858012 for ; Fri, 13 Nov 2020 14:05:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 322C53858012 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4CXgGt60YZzQkLK; Fri, 13 Nov 2020 15:05:42 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id HpmM6HmmowUi; Fri, 13 Nov 2020 15:05:39 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [committed] d: Explicitly determine which built-in copysign function to call. Date: Fri, 13 Nov 2020 15:05:32 +0100 Message-Id: <20201113140532.1974473-1-ibuclaw@gdcproject.org> MIME-Version: 1.0 X-MBO-SPAM-Probability: ** X-Rspamd-Score: 1.51 / 15.00 / 15.00 X-Rspamd-Queue-Id: DC7D917E6 X-Rspamd-UID: 47721a X-Spam-Status: No, score=-15.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Iain Buclaw via Gcc-patches From: Iain Buclaw Reply-To: Iain Buclaw Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi, For some targets, mathfn_built_in returns NULL as copysign is not implicitly available, causing an ICE. Now copysign is explicitly requested when expanding the intrinsic. Bootstrapped and regression tested on x86_64-linux-gnu and x86_64-freebsd. Committed to mainline. As this fixes an ICE, will also prep it for the releases/gcc-10 branch. Regards Iain. --- gcc/d/ChangeLog: * intrinsics.cc (expand_intrinsic_copysign): Explicitly determine which built-in copysign function to call. --- gcc/d/intrinsics.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gcc/d/intrinsics.cc b/gcc/d/intrinsics.cc index a629472c6c5..a7de91019a4 100644 --- a/gcc/d/intrinsics.cc +++ b/gcc/d/intrinsics.cc @@ -466,11 +466,14 @@ expand_intrinsic_copysign (tree callexp) from = fold_convert (type, from); /* Which variant of __builtin_copysign* should we call? */ - tree builtin = mathfn_built_in (type, BUILT_IN_COPYSIGN); - gcc_assert (builtin != NULL_TREE); + built_in_function code = (type == float_type_node) ? BUILT_IN_COPYSIGNF + : (type == double_type_node) ? BUILT_IN_COPYSIGN + : (type == long_double_type_node) ? BUILT_IN_COPYSIGNL + : END_BUILTINS; - return call_builtin_fn (callexp, DECL_FUNCTION_CODE (builtin), 2, - to, from); + gcc_assert (code != END_BUILTINS); + + return call_builtin_fn (callexp, code, 2, to, from); } /* Expand a front-end intrinsic call to pow(). This takes two arguments, the