diff mbox series

[2/4] libstdc++: Add a move-only testsuite iterator type

Message ID 20200303163043.2182013-2-ppalka@redhat.com
State New
Headers show
Series [1/4] libstdc++: Fix use of is_nothrow_assignable_v in <bits/ranges_uninitialized.h> | expand

Commit Message

Patrick Palka March 3, 2020, 4:30 p.m. UTC 
This adds a move-only testsuite iterator type to <testsuite_iterators.h>, which
will be used in the tests that verify LWG 3355 and has already seen a need in
the tests for LWG 3389 and 3390.

libstdc++-v3/ChangeLog:

	* testsuite/util/testsuite_iterators.h (input_iterator_wrapper_nocopy):
	New testsuite iterator.
	* testsuite/24_iterators/counted_iterator/lwg3389.cc: Use it.
	* testsuite/24_iterators/move_iterator/lwg3390.cc: Likewise.
---
 .../24_iterators/counted_iterator/lwg3389.cc  | 35 ++-----------------
 .../24_iterators/move_iterator/lwg3390.cc     | 35 ++-----------------
 .../testsuite/util/testsuite_iterators.h      | 28 +++++++++++++++
 3 files changed, 32 insertions(+), 66 deletions(-)

Comments

Jonathan Wakely March 3, 2020, 9:35 p.m. UTC | #1 
On 03/03/20 11:30 -0500, Patrick Palka wrote:
>This adds a move-only testsuite iterator type to <testsuite_iterators.h>, which
>will be used in the tests that verify LWG 3355 and has already seen a need in
>the tests for LWG 3389 and 3390.
>
>libstdc++-v3/ChangeLog:
>
>	* testsuite/util/testsuite_iterators.h (input_iterator_wrapper_nocopy):
>	New testsuite iterator.
>	* testsuite/24_iterators/counted_iterator/lwg3389.cc: Use it.
>	* testsuite/24_iterators/move_iterator/lwg3390.cc: Likewise.

OK, thanks.
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/24_iterators/counted_iterator/lwg3389.cc b/libstdc++-v3/testsuite/24_iterators/counted_iterator/lwg3389.cc
index cf74fd47bec..8b9bf53f6c5 100644
--- a/libstdc++-v3/testsuite/24_iterators/counted_iterator/lwg3389.cc
+++ b/libstdc++-v3/testsuite/24_iterators/counted_iterator/lwg3389.cc
@@ -23,44 +23,13 @@ 
 #include <testsuite_iterators.h>
 
 using __gnu_test::test_range;
-using __gnu_test::input_iterator_wrapper;
-
-template<typename T>
-struct move_only_wrapper : input_iterator_wrapper<T>
-{
-  using input_iterator_wrapper<T>::input_iterator_wrapper;
-
-  move_only_wrapper()
-    : input_iterator_wrapper<T>(nullptr, nullptr)
-  { }
-
-  move_only_wrapper(const move_only_wrapper&) = delete;
-  move_only_wrapper&
-  operator=(const move_only_wrapper&) = delete;
-
-  move_only_wrapper(move_only_wrapper&&) = default;
-  move_only_wrapper&
-  operator=(move_only_wrapper&&) = default;
-
-  using input_iterator_wrapper<T>::operator++;
-
-  move_only_wrapper&
-  operator++()
-  {
-    input_iterator_wrapper<T>::operator++();
-    return *this;
-  }
-};
-
-static_assert(std::input_iterator<move_only_wrapper<int>>);
-static_assert(!std::forward_iterator<move_only_wrapper<int>>);
-static_assert(!std::copyable<move_only_wrapper<int>>);
+using __gnu_test::input_iterator_wrapper_nocopy;
 
 // LWG 3389
 void
 test01()
 {
   int x[] = {1,2,3,4};
-  test_range<int, move_only_wrapper> rx(x);
+  test_range<int, input_iterator_wrapper_nocopy> rx(x);
   auto it = std::counted_iterator(rx.begin(), 2);
 }
diff --git a/libstdc++-v3/testsuite/24_iterators/move_iterator/lwg3390.cc b/libstdc++-v3/testsuite/24_iterators/move_iterator/lwg3390.cc
index 1df7caccece..7e9f4a0d0cc 100644
--- a/libstdc++-v3/testsuite/24_iterators/move_iterator/lwg3390.cc
+++ b/libstdc++-v3/testsuite/24_iterators/move_iterator/lwg3390.cc
@@ -23,44 +23,13 @@ 
 #include <testsuite_iterators.h>
 
 using __gnu_test::test_range;
-using __gnu_test::input_iterator_wrapper;
-
-template<typename T>
-struct move_only_wrapper : input_iterator_wrapper<T>
-{
-  using input_iterator_wrapper<T>::input_iterator_wrapper;
-
-  move_only_wrapper()
-    : input_iterator_wrapper<T>(nullptr, nullptr)
-  { }
-
-  move_only_wrapper(const move_only_wrapper&) = delete;
-  move_only_wrapper&
-  operator=(const move_only_wrapper&) = delete;
-
-  move_only_wrapper(move_only_wrapper&&) = default;
-  move_only_wrapper&
-  operator=(move_only_wrapper&&) = default;
-
-  using input_iterator_wrapper<T>::operator++;
-
-  move_only_wrapper&
-  operator++()
-  {
-    input_iterator_wrapper<T>::operator++();
-    return *this;
-  }
-};
-
-static_assert(std::input_iterator<move_only_wrapper<int>>);
-static_assert(!std::forward_iterator<move_only_wrapper<int>>);
-static_assert(!std::copyable<move_only_wrapper<int>>);
+using __gnu_test::input_iterator_wrapper_nocopy;
 
 // LWG 3390
 void
 test01()
 {
   int x[] = {1,2,3,4};
-  test_range<int, move_only_wrapper> rx(x);
+  test_range<int, input_iterator_wrapper_nocopy> rx(x);
   auto it = std::make_move_iterator(rx.begin());
 }
diff --git a/libstdc++-v3/testsuite/util/testsuite_iterators.h b/libstdc++-v3/testsuite/util/testsuite_iterators.h
index 417dff23c50..e47b2b03e40 100644
--- a/libstdc++-v3/testsuite/util/testsuite_iterators.h
+++ b/libstdc++-v3/testsuite/util/testsuite_iterators.h
@@ -674,6 +674,34 @@  namespace __gnu_test
       { return iter -= n; }
     };
 
+  // A move-only input iterator type.
+  template<typename T>
+    struct input_iterator_wrapper_nocopy : input_iterator_wrapper<T>
+    {
+      using input_iterator_wrapper<T>::input_iterator_wrapper;
+
+      input_iterator_wrapper_nocopy()
+	: input_iterator_wrapper<T>(nullptr, nullptr)
+      { }
+
+      input_iterator_wrapper_nocopy(const input_iterator_wrapper_nocopy&) = delete;
+      input_iterator_wrapper_nocopy&
+      operator=(const input_iterator_wrapper_nocopy&) = delete;
+
+      input_iterator_wrapper_nocopy(input_iterator_wrapper_nocopy&&) = default;
+      input_iterator_wrapper_nocopy&
+      operator=(input_iterator_wrapper_nocopy&&) = default;
+
+      using input_iterator_wrapper<T>::operator++;
+
+      input_iterator_wrapper_nocopy&
+      operator++()
+      {
+	input_iterator_wrapper<T>::operator++();
+	return *this;
+      }
+    };
+
   // A type meeting the minimum std::range requirements
   template<typename T, template<typename> class Iter>
     class test_range