From patchwork Tue Mar 3 09:40:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu X-Patchwork-Id: 1248205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-520519-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=OvO2jFH5; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=QN7HXY/3; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48WsTp6679z9sPg for ; Tue, 3 Mar 2020 20:41:34 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; q=dns; s=default; b=QFO R1B/7qoei7XzIyZoeI0RG8fZW5RUKP9vOfiRP1rQRJtbkSihD1pik/EeauLlMx3W 571TSsZpVPgW6f4X8FdL9lxBQtMw+ez57cQRU2q8Gq8XaVj/qTnB0Hneio7RtDPe wiVCTU4XLC6X+pQ0+XGd2Y8XoqO6sSdQRsy5GzMc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=default; bh=dh5HDEK5b 33IEt460fOXEojf8Qg=; b=OvO2jFH55EOdiTJcMD4BXXf5OgZrn+FbK1TrmnG3g YR0wV0SvuZfP4bY+8r3aJv0iufDHgNCF842XypLdKtm63er0n3nibiPALLihZgN3 xZYNQYBu2fSN9jcBxOMEWiVw4+kId02Iv8J14FhjuJIHyDoHRllkcYrfv/tGbR1E 54= Received: (qmail 64801 invoked by alias); 3 Mar 2020 09:41:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 64712 invoked by uid 89); 3 Mar 2020 09:41:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=5000, HX-Received:251, finalc, UD:final.c X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 09:41:04 +0000 Received: by mail-wm1-f66.google.com with SMTP id g83so2102544wme.1 for ; Tue, 03 Mar 2020 01:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cg4kRZ/iAfOCfULcmAsXd5QGX3C13HwYHXCvNP6r7g4=; b=QN7HXY/3+S8+odrLiJ9olM/h8Y8nPjd5nEXqfQvKFvBwl7j7ric+rmUcw734rPFlx3 hA21SYKEYbfn/0zxgWO7UMaksmVZI6E5NAa/bX+goVQ+uiUq+o1bxVHhvx3ygQO7UrWJ KU5I79xouVnQ06wvpNsCDYLsoReFDoF+NDwEAGfF/ePkoFLgd5ceEijBoGUyd1lFSbHQ meE1R1WUr9DpoNjeXzXmw2X+tDNaMr4iPo8la0PhTW8ozg+gIRmCu2e+2kxX6NmKtIM6 UQcM2R3eVnZZiVmAvpoYNWP7NGjiwAI4tV5zZ2TVwoEsAaNoCX3coX1fNUUvOVQbN0z2 8DQQ== Received: from localhost.localdomain ([79.115.250.90]) by smtp.gmail.com with ESMTPSA id n11sm22453233wrq.40.2020.03.03.01.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 01:41:01 -0800 (PST) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: law@redhat.com, fbedard@synopsys.com, claziss@synopsys.com, andrew.burgess@embecosm.com Subject: [PATCH 3/3] [ARC] Remove munalign-prob-threshold. Date: Tue, 3 Mar 2020 11:40:46 +0200 Message-Id: <20200303094046.1439895-3-claziss@gmail.com> In-Reply-To: <20200303094046.1439895-1-claziss@gmail.com> References: <20200303094046.1439895-1-claziss@gmail.com> MIME-Version: 1.0 X-IsSubscribed: yes The munalign-prob-threshold option is obsolete, remove it. gcc/ xxxx-xx-xx Claudiu Zissulescu * config/arc/arc.opt (munalign-prob-threshold): Remove option. * doc/invoke.texi (ARC): Remove munalign-prob-threshold doc. * config/arc/arc.c (arc_unalign_branch_p): Remove unused function. --- gcc/config/arc/arc.c | 23 ----------------------- gcc/config/arc/arc.opt | 6 ------ gcc/doc/invoke.texi | 11 +---------- 3 files changed, 1 insertion(+), 39 deletions(-) diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index c57febd3783..af26e5b9711 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -9920,29 +9920,6 @@ gen_acc2 (void) return gen_rtx_REG (SImode, TARGET_BIG_ENDIAN ? 57: 56); } -/* FIXME: a parameter should be added, and code added to final.c, - to reproduce this functionality in shorten_branches. */ -#if 0 -/* Return nonzero iff BRANCH should be unaligned if possible by upsizing - a previous instruction. */ -int -arc_unalign_branch_p (rtx branch) -{ - rtx note; - - if (!TARGET_UNALIGN_BRANCH) - return 0; - /* Do not do this if we have a filled delay slot. */ - if (get_attr_delay_slot_filled (branch) == DELAY_SLOT_FILLED_YES - && !NEXT_INSN (branch)->deleted ()) - return 0; - note = find_reg_note (branch, REG_BR_PROB, 0); - return (!note - || (arc_unalign_prob_threshold && !br_prob_note_reliable_p (note)) - || INTVAL (XEXP (note, 0)) < arc_unalign_prob_threshold); -} -#endif - /* When estimating sizes during arc_reorg, when optimizing for speed, there are three reasons why we need to consider branches to be length 6: - annull-false delay slot insns are implemented using conditional execution, diff --git a/gcc/config/arc/arc.opt b/gcc/config/arc/arc.opt index a8af5138183..244c3abd86d 100644 --- a/gcc/config/arc/arc.opt +++ b/gcc/config/arc/arc.opt @@ -287,12 +287,6 @@ mmul32x16 Target Report Mask(MULMAC_32BY16_SET) Generate 32x16 multiply and mac instructions. -; the initializer is supposed to be: Init(REG_BR_PROB_BASE/2) , -; alas, basic-block.h is not included in options.c . -munalign-prob-threshold= -Target RejectNegative Joined UInteger Var(arc_unalign_prob_threshold) Init(10000/2) -Set probability threshold for unaligning branches. - mmedium-calls Target Var(TARGET_MEDIUM_CALLS) Init(TARGET_MMEDIUM_CALLS_DEFAULT) Don't use less than 25 bit addressing range for calls. diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 802d36d4098..51c2d6d04de 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -729,7 +729,7 @@ Objective-C and Objective-C++ Dialects}. -mlra-priority-compact mlra-priority-noncompact -mmillicode @gol -mq-class -mRcq -mRcw -msize-level=@var{level} @gol -mtune=@var{cpu} -mmultcost=@var{num} -mcode-density-frame @gol --munalign-prob-threshold=@var{probability} -mmpy-option=@var{multo} @gol +-mmpy-option=@var{multo} @gol -mdiv-rem -mcode-density -mll64 -mfpu=@var{fpu} -mrf16 -mbranch-index} @emph{ARM Options} @@ -18031,15 +18031,6 @@ Tune for ARC4x release 3.10a. Cost to assume for a multiply instruction, with @samp{4} being equal to a normal instruction. -@item -munalign-prob-threshold=@var{probability} -@opindex munalign-prob-threshold -Set probability threshold for unaligning branches. -When tuning for @samp{ARC700} and optimizing for speed, branches without -filled delay slot are preferably emitted unaligned and long, unless -profiling indicates that the probability for the branch to be taken -is below @var{probability}. @xref{Cross-profiling}. -The default is (REG_BR_PROB_BASE/2), i.e.@: 5000. - @end table The following options are maintained for backward compatibility, but