From patchwork Tue Nov 14 15:53:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 837908 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-466744-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="EJLDUIVs"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ybsVQ3zb4z9sBZ for ; Wed, 15 Nov 2017 02:53:17 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=pQDN1jUz373TBrDhtd8O4UHCRIAeh/JCR5Z3bqix4U2/4obJTr 0yKE+dUcdw4GuLBmMRK4pJ288kCdxbnIdpCVLqPn9jsqMlN46l1FqFACFm1NlVfw O8bINyUBic9vo81Q/FxK82iIxMU+scu1YoD45tfvd/WdPODo4V/AgCz1E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=VrOwBjL+GqMh5vwbOMjO2AB77Cw=; b=EJLDUIVstpxeDsELvaf9 kNvmErylIuKjRGdKtGDSWNyRmfWc9Hu4U1YJbM/f7UE5TJiKvWG9fXJtoQUHPjSa kwYH3aqZdJNOLQx07deP/UAv3oOrbI6hv5/MCmO4nLxHOJM8al95kNJNE/cMYzXy B5x1pVg6w0QwHUDEwJam2zE= Received: (qmail 10107 invoked by alias); 14 Nov 2017 15:53:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9861 invoked by uid 89); 14 Nov 2017 15:53:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1305, H*r:15.20.178 X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10077.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 15:53:05 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; Received: from arm.com (217.140.96.140) by HE1PR08MB0507.eurprd08.prod.outlook.com (2a01:111:e400:50a8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Tue, 14 Nov 2017 15:53:01 +0000 Date: Tue, 14 Nov 2017 15:53:33 +0000 From: Tamar Christina To: gcc-patches@gcc.gnu.org Cc: nd@arm.com, Ramana.Radhakrishnan@arm.com, Richard.Earnshaw@arm.com, nickc@redhat.com, Kyrylo.Tkachov@arm.com Subject: [PATCH][GCC][ARM] Restrict TARGET_DOTPROD to baseline Armv8.2-a. Message-ID: <20171114155327.GA28748@arm.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: HE1PR0402CA0020.eurprd04.prod.outlook.com (2603:10a6:3:d0::30) To HE1PR08MB0507.eurprd08.prod.outlook.com (2a01:111:e400:50a8::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 281ce8e5-0f08-4a3a-fbbb-08d52b77c905 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199)(49563074); SRVR:HE1PR08MB0507; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0507; 3:Cn5B5bgmca7/4lROOXwN5A/QQPWJCon1x2nn2OhtWYj4gsjHplWWfGEhu8ukVSHt0sxqv98sJiG0O6Mvtfm5tvu2qH2Nd7qJd12lWdhjubGykBlGPJRP10B4zVjl03phC0UpiU9yCP0agg+RNexRhY0ppv+N4+84LYUJ78CGWFgjyKo9E+z2Df33Z1aW3yWXRluAzwAEcjEZCPm4AfyHGuQey+m2F1IvpNEsDnpiHeEVfiWzv2CsiDJnVwOxVuu1; 25:ZNKa51hK79cYu4bPYIv5iBEZBcyJ1q+4aYHVWh7wR/fqqdCr1PB9QQ7KWhdm+8gUVXESoxxeFyzE0XmJeRnNqecf4zendOnD5AM8WoYvDjeNvle7dOVXgIiLzZi00BQgWTBtspcwqs/RisA+uRJ4TghPZypOabtAHaFANCdsIuMcbfY3QP60lvwZTYQoBLilmWJhrEnFPcbj0YbaxxFCCC6tYgrpKRpQszaFttUqkNALG6Ji2vSn7lh57X7SUoXqddwl2p0gRYbCDNmMrlVkww/O/frbCl0oCmRF4GCIS0fjxvSUpIHyvNOQQvtvqxq0HZJEp7pQQDtu19jAibmBtlnE5KU2gzKtDGq11XeIxgg=; 31:2/HOYYOZcuAIqO752w492Pfh4qJ6t7045cq9W51mOwR8F8aiGeKX5ywVjeUHAgyeXhWR0GLov6++s8e44JrA7YuJYqRpzxPj5WsvxYkXIGBFYta8l7jDnTqZ1HC39OT/Exnff1FFBDiXp4CpyIbpS2WkKoSpjpE8DgMwmXCwjI1a2xGryMCpUk9fmFN3STP3XQd9q97D4zQ6oHOnWiSoS4fNFIeBsK2E9kDyZrz8g9Y= X-MS-TrafficTypeDiagnostic: HE1PR08MB0507: X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0507; 20:mWQlVCbixQr91LDFjQOmMUehXNx0Q7jRWyjARMxIqLitOomp66ytpk9IT5K49MZj1g9VgwTSGiSgUdlMiMcJmX9utM7wM2/gtqgez34q7eHeI4RFQpPIv28AxA2vmEFQXFid52/0+2Qo7mRpUe8lqR7lo7EYn/6J7WNpwL7UDqs=; 4:nETc4TU0+vPB2Nhe8KT5fhYM+v7IglMb9/EWYFTq2wJ5tSKG+n6/FuZ5GRIubzeYaBdM1HKUzapMm22CjNcJn4ViP751VtJydw8QDY0orBenRwvPxOM07gwjI3bi61vZn4V+RPbnMS9SmFJv3bNrNzWSOorEH0Uv88GLUDXIWxFYamrSZyGPRCiCg+09Nrmwth0mmQVuEBiyUlSgZDvAt/KeCtPxq6eGbWEty925MbFr3R2ky8s6P69VWXYSTznav67oWw2tiTql+AnNUGcGNkH2bPDsHKuv5tquf9vX8SXyyy4s88LB9cSswiYlvQzB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(3231022)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR08MB0507; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR08MB0507; X-Forefront-PRVS: 04916EA04C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(189002)(377424004)(53754006)(199003)(2351001)(7736002)(2361001)(8676002)(305945005)(16526018)(83506002)(189998001)(81156014)(101416001)(33656002)(2906002)(6916009)(68736007)(54356999)(50986999)(106356001)(478600001)(6666003)(53936002)(8936002)(105586002)(81166006)(72206003)(5660300001)(2476003)(5890100001)(21086003)(316002)(4326008)(84326002)(5000100001)(25786009)(58126008)(16586007)(568964002)(6116002)(66066001)(86362001)(1076002)(4610100001)(36756003)(3846002)(4001150100001)(55016002)(97736004)(18370500001)(45673001)(2700100001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0507; H:arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0507; 23:W+PefhC6lWLqpwR/rEYad1jQ0Fet518nhQbUSqalkR6LLhliZSf4HJHEdjW9wGzZMZ2z8HrzxFfmxSNlBSG3waWQh38hJPS7Eeqpu7R3jQiRtl2Z9XwFklI6wIjEBS8YtBh5kguThrTJAIwN7jjJ6Cr6AUZSYDFCgyzDjXWpJ5jeD01iPgNVacS5Y8qrlTwKfeuSmthNm8WoTe7HnnZSjCt/HQZyhgM8w8+e1Xxf5qGUB8wtAuYmx5yl01UL4HsdBBCelsCdQfOFOd95RvKb7sq3Pamdqwz0AzQn0Iwhg/lA/h0Sm1Cl3KWMgPDJNJDJX7fSrnB7VUr+/Ei8fi1anHk4miY+DkZIYcWJtFEUAcCglOpC8DzDxeACOxUxLaHKpu1YXiZJjJO3kHYsWSPPIRFnwqpbgpY2yDtuPIuY+bYTMFYVNa2AWuGEk7LkLNeoeKGYfKcpa1h02+LLZv9iIAv/Y9m39xiffgnbptE/Reizg32E5yBpCZc+WEQiRat0YGM55/R5E2JJ11zy9X5z/FN1OGJlEcEIeOWxapbg2sTa1rhKPvigbh7ATSDw7U7lEnViTqyatzM5MfjDhMGFPbf77dNniQisSeImGBtM7tFpKcCagTlMwfKC9sV38lxIcRbUMW66tyYV4xiTrY1uIxnizmS7nD3iWxBERowTGCbgaAzCDWixQoH2gRKaQmXHbIZKk4o5/4/tXOchm3zHvyniBhlFBOqls6atsOcazKOZC8em04Y7PTmVtMPbIFEMm3ewqRSc1rWS17UVnO2buBjO/Io8xYWb/YqBlTZxuN0jmtCQawU7Cyz+1i8Vk9t0xWHjPHHlyZyzfg+T0EIkX4xnebAVuR7uQL/aBT6l/vtaVwp8yUx9KPrCgf0u9xxjEnz3x+fjaLWy9+3c/gqqKTTebOt1rTZZ83AbOT2m0cDNj02tiy33aKQebVUpPg5m4YScmY+4jtPMPwpcquvPZAvUBTEDk/+XNb3ZSckuyrSwF3KxaapgSm9dQYEm2hMzf9p2ajoetyuhLYb6iM5C7QTrnOiWju1ev4O6Tn8BXLYefzX/UMU/smUDvn01XVZt2MkGqRS5hvKOQVpEibCF/WIJB9ba8q/0PVFc3ajPa+Xp0w1YXFBw7k2H/xz0UP6qbfy90fz6sUk3Nhj79tjPGkZ62S6xdP/RnkGhGeIABcKyHyCyKDg2UUsqZn+SiljlHbQhV5fBG/+Kuayy+NTe7LabDInN5Hs21dkFpw1VEqYoE/TDFDvRC92iM+xxu+pnpoo1oP77HXkADGJAoCp6uAjLal+OW41kQjKfCo/sfydP5XJr3Y3fAkeWEmHB8ns/5jcpDNiyrvRXAUyWalgYYw== X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0507; 6:B+93HNKPVKJ4lR+ZWkh9+ByQbhv5UwE+yPzQ4nk/UKIePv+KorKvC7qyAjAGv31rRfUXMYsEawnWIEzPF6ObVch40KNf/F9MIv51gF7KNJLV5u+XW8XhA71iv5cmYv8EqzenxoHC1yhnAilORARpAp8zm7USrwvO4y3Khv/9rVzwi1rPN7ZPuUW6ULD1keXOHE6vuJGn+iOAbQGZqpkU5lvK5YwdiVYD/4lxDA4POozj5QBETbS9V5OTKGnPlZYmY12Yd9DOeOwkXZfH/sZJAPjynTomnnd7tUdybv+an8oERJguG6CCW37wCALpEPo2Oc7unta5QV1k0d7Z5jRl0zaK8jxg2Q8bY1OrvlG3PWo=; 5:eBtDIMUBDf/SGCXunMYy9wCWb3zwAfMW7QxOfD7xq5zDKRwwAjkZLtVQeZpNIBCObdCVOUZ4qzmu39BZ7Mk9LZzH3LgKix69KAXokOJTF0ISNa9m6PRODPQ30v6ZbHSJXQ+oWPgB0DcG8GDtHDWvd2IPBmkkmM7W2JnJynRaA2E=; 24:YM33DiG8UqmbXp2rLUZqG6b0DiCRMAf2qW821jQRrNs5JCC04tezJo47KU26ET8WKWLA2xSBoVmHcZ/ghkZZPyf176uNVB21Sp+zudiBvGQ=; 7:kZdAQXqd7/2bXH1bYv4PV+oFrpjE4saJZsmOG1makpRfp3MWo4v6AehFg6g1lzOwFIMCyMouFTL3Xmkoex4K2l1COc4eQR+SRoxkWWBIyHjUwz0n7yqyXiZXTqvgtMajp+WRsXGRXFt5gP3a9MKxJkSZn9IrT8GKkYDphI3kn9+0+/l5HrsvzAilVl4WaSOF+Gp33O3f4vrbKp6NGME6GkRGaYPOaD/j8V0SVwor7inMj5n75iMVSt7hInJbR15/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 15:53:01.2445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 281ce8e5-0f08-4a3a-fbbb-08d52b77c905 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0507 X-IsSubscribed: yes Hi All, Dot Product is intended to only be available for Armv8.2-a and newer. While this restriction is reflected in the intrinsics, the patterns themselves were missing the Armv8.2-a bit. While GCC would prevent invalid options e.g. `-march=armv8.1-a+dotprod` we should prevent the pattern from being able to expand at all. Regtested on arm-none-eabi and no issues. Ok for trunk? Thanks, Tamar gcc/ 2017-11-14 Tamar Christina * config/arm/arm.h (TARGET_DOTPROD): Add arm_arch8_2. diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index 9567f6df73a960ab08b3766fcf3677629658a5ab..b189951c934e327c88cc5893e9629515c9c39013 100644 --- a/gcc/config/arm/arm.h +++ b/gcc/config/arm/arm.h @@ -210,10 +210,11 @@ extern tree arm_fp16_type_node; /* FPU supports ARMv8.1 Adv.SIMD extensions. */ #define TARGET_NEON_RDMA (TARGET_NEON && arm_arch8_1) -/* Supports for Dot Product AdvSIMD extensions. */ +/* Supports the Dot Product AdvSIMD extensions. */ #define TARGET_DOTPROD (TARGET_NEON \ && bitmap_bit_p (arm_active_target.isa, \ - isa_bit_dotprod)) + isa_bit_dotprod) \ + && arm_arch8_2) /* FPU supports the floating point FP16 instructions for ARMv8.2 and later. */ #define TARGET_VFP_FP16INST \