From patchwork Fri Sep 8 13:31:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 811588 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-461724-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="QQ3CSaCi"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xpdXP0FgLz9s82 for ; Fri, 8 Sep 2017 23:32:04 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=II4PGCa0CIHhamLm4e7TJQ4Cb6TLFz5MZil+SOywSNGqgBNsZe F7cssbjvoioEHE/dqBieJlUWyKUEGSIcq8XbCTb1Q3sKvW40m1yN5b9A+Jnfg1O0 YQrNliTRXWlgldF/kjuZIhjdI/jYvFKn0KldAnC4yXEJkS6fWHk00U+cU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=WDS5iJWoyMWoXXHJUHgt7RE0YZQ=; b=QQ3CSaCieiyKfdEEWNG8 EMcPQw52DvNnmTrxk/35lYT+EQaGs63nuHGwB/OEOYM7qNG6pOJN+gglBu8Kfve/ hA3UIkMn+6LMnc9MvCNkpKKaNd8oSxKZEp/K2uS5pz6fioW7ez32uOCbP5TfWshX CFaetMXdZV//8WWyafaEvLc= Received: (qmail 6950 invoked by alias); 8 Sep 2017 13:31:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6915 invoked by uid 89); 8 Sep 2017 13:31:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=BV, Hx-languages-length:1571 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Sep 2017 13:31:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C31F05628B; Fri, 8 Sep 2017 09:31:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tWxsyj5a6akc; Fri, 8 Sep 2017 09:31:27 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id B2B7156285; Fri, 8 Sep 2017 09:31:27 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4192) id AEC584A4; Fri, 8 Sep 2017 09:31:27 -0400 (EDT) Date: Fri, 8 Sep 2017 09:31:27 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Javier Miranda Subject: [Ada] Missing error in function expressions Message-ID: <20170908133127.GA87369@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) The compiler skips reporting errors located in function expressions. After this patch the error is reported in the following sources: package Base is type Base_Type is tagged record V : Integer; end record; function Func_1 (B : Base_Type) return Integer is (B.V); end; with Base; package DB is type DB_Type is new Base.Base_Type with record Y : Integer; end record; overriding function Func_1 (B : DB_Type) return Integer; private function Func_1 (B : DB_Type) return Integer is (Base.Func_1 (Base_Type (B)) / 8 * 4); -- Error end; Command: gcc -c db.ads Output: db.ads:13:20: "Base_Type" is not visible db.ads:13:20: non-visible declaration at base.ads:2 Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-08 Javier Miranda * sem_ch8.adb (Find_Direct_Name.Undefined): Do not add entries into the undefined reference table when we are compiling with errors ignored. Index: sem_ch8.adb =================================================================== --- sem_ch8.adb (revision 251892) +++ sem_ch8.adb (working copy) @@ -5328,9 +5328,10 @@ -- Make entry in undefined references table unless the full errors -- switch is set, in which case by refraining from generating the -- table entry, we guarantee that we get an error message for every - -- undefined reference. + -- undefined reference. The entry is not added if we are ignoring + -- errors. - if not All_Errors_Mode then + if not All_Errors_Mode and then Ignore_Errors_Enable = 0 then Urefs.Append ( (Node => N, Err => Emsg,