From patchwork Tue Jun 27 23:34:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Meissner X-Patchwork-Id: 781420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wy2MD10fxz9s1h for ; Wed, 28 Jun 2017 09:34:31 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="jAjNG4X7"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:mime-version:content-type:message-id; q=dns; s= default; b=KeHHgtCSsjqGD8vjLzCGex1AtWvLSZeaoH1Of2QqqlIgIHoueYEY0 k5+7BkK5a0tHapNRqG3X3k6/QFEYZEunIqumKidTzrJdBblv/QF42WOT3WD+9cDY 96PRi8a18bYie8dqVeyGOPwsGo9147Am2Kht/jJii6Wbug4kGfraL4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:mime-version:content-type:message-id; s= default; bh=93Ntvl7EUOdBW1Wy3sVC7Heybsc=; b=jAjNG4X7ylgsERfaH8ty Lnn9HCEFq1v1cXTgBlv+EEQeOnmAtqE08L+vwC1BdJmLxiywmL7bqW+awYX2Nkou uCFBKB1gMhg8W1/NkMpEuAmLBc827TUcRHkUgmDWVmmOeQuZ0rbPeRFLuO24faBz eQqEbymn8k1+LzJ+44OXpgs= Received: (qmail 98403 invoked by alias); 27 Jun 2017 23:34:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 98382 invoked by uid 89); 27 Jun 2017 23:34:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KAM_MANYTO, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=king, Street X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 23:34:20 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5RNY1X5031107 for ; Tue, 27 Jun 2017 19:34:18 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0b-001b2d01.pphosted.com with ESMTP id 2bbsgnjbhu-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 27 Jun 2017 19:34:18 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Jun 2017 19:34:17 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 27 Jun 2017 19:34:15 -0400 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5RNYE2A61865990; Tue, 27 Jun 2017 23:34:14 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AFD362803F; Tue, 27 Jun 2017 19:34:08 -0400 (EDT) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id 94FEE2803D; Tue, 27 Jun 2017 19:34:08 -0400 (EDT) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id BAACD492F8; Tue, 27 Jun 2017 19:34:13 -0400 (EDT) Date: Tue, 27 Jun 2017 19:34:13 -0400 From: Michael Meissner To: GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt , Martin Liska , Jan Hubicka Subject: [PATCH], PR ipa/81238, make default target_clone static Mail-Followup-To: Michael Meissner , GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt , Martin Liska , Jan Hubicka MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17062723-0044-0000-0000-0000035DE786 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007287; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00879639; UDB=6.00438431; IPR=6.00659794; BA=6.00005445; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015981; XFM=3.00000015; UTC=2017-06-27 23:34:17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062723-0045-0000-0000-0000078BF075 Message-Id: <20170627233413.GA11400@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-27_15:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706270368 X-IsSubscribed: yes In going through the target_clone support for the PowerPC, I noticed that the default target clone function was not explicitly set to private. This patch fixes this. I have checked both the x86_64 and PowerPC target clone code, and the patch does make it private. I'm doing bootstrap builds on both little endian power8 and an x86_64 system right now (both builds are at stage3, so I don't expect any problems). Assuming there is no regression, can I check this patch in to the trunk? 2017-06-27 Michael Meissner PR ipa/81238 * multiple_target.c (create_dispatcher_calls): Set the default clone to be static, not public. Index: gcc/multiple_target.c =================================================================== --- gcc/multiple_target.c (revision 249710) +++ gcc/multiple_target.c (working copy) @@ -148,6 +148,7 @@ create_dispatcher_calls (struct cgraph_n } } + TREE_PUBLIC (node->decl) = 0; symtab->change_decl_assembler_name (node->decl, clone_function_name (node->decl, "default"));