From patchwork Tue Apr 25 09:43:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 754669 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wByvX4phbz9s3s for ; Tue, 25 Apr 2017 19:43:36 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="kywdtc8M"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=G7u4P2gIGA+KJpNDk6z+sq3z/+TB53wdTV2f6uhtyniyWXi2ec /dj0w6mDfANqwmKbFmYw93gXw0Vjfd/GvuY1uenCjl0mO+WDwHV9ITwCMPNZ0DVw 4kM9Nkzn2P4hubWubzkyokGrEqMYFrSZ0Bj4+wRhvT8bM7cTyPgVrwuXU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=V37CG0NSOjtMvW2dWOQMuFVsy5c=; b=kywdtc8MThRrou82QVAY EcgRWnX7BR/qqnivH8K2R+5xtmrmHPHhuLbD1E8D+v7qOLCUwGkyuIaC9KNQFQrC uvSg5fV8ZTVXBLlyie9D2cwQooeCKeQcptLxnQT3GyL+lcv32EEiOtZx8MHeVJZw iTZzcsTfv8w3LpS1X87nj4c= Received: (qmail 95004 invoked by alias); 25 Apr 2017 09:43:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 91056 invoked by uid 89); 25 Apr 2017 09:43:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 09:43:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6D5C13546; Tue, 25 Apr 2017 05:43:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ACiHkrKx4w2X; Tue, 25 Apr 2017 05:43:12 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 5DD55350F; Tue, 25 Apr 2017 05:43:12 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4192) id 5CA06521; Tue, 25 Apr 2017 05:43:12 -0400 (EDT) Date: Tue, 25 Apr 2017 05:43:12 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Static intialization with pragma Linker_Section Message-ID: <20170425094312.GA131280@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) This patch is an improvement that causes an array object that has a pragma Linker_Section with a compile-time-known initial value to be statically initialized in place in the appropriate section. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-04-25 Bob Duff * freeze.adb (Freeze_Object_Declaration): Do not Remove_Side_Effects if there is a pragma Linker_Section, because in that case we want static initialization in the appropriate section. Index: freeze.adb =================================================================== --- freeze.adb (revision 247155) +++ freeze.adb (working copy) @@ -3197,12 +3197,15 @@ -- Similar processing is needed for aspects that may affect -- object layout, like Alignment, if there is an initialization - -- expression. + -- expression. We don't do this if there is a pragma Linker_Section, + -- because it would prevent the back end from statically initializing + -- the object; we don't want elaboration code in that case. if Has_Delayed_Aspects (E) and then Expander_Active and then Is_Array_Type (Etype (E)) and then Present (Expression (Parent (E))) + and then No (Linker_Section_Pragma (E)) then declare Decl : constant Node_Id := Parent (E);