From patchwork Sun Dec 18 23:40:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 706870 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3thgXy4r30z9t1d for ; Mon, 19 Dec 2016 10:41:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="nAErHDoJ"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; q=dns; s=default; b=kqrV 6pA7QgTA36VspxD4hQdcNiC2j4WMg25gF28MmqXo0q6rNGiO0nrUOhprTuq9NJ61 +Dp9h9FcBfXTMyTRm0fZHTk/t8psAuE2ffWD2dhXzJSIQwaFbyDKUR9ovqW/3lbu OOrzPRHIXFUjAutgB8cldaVMb+8GM8dUzCrVgG0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; s=default; bh=ytwwLLIWIy semzSvG2tIH/2u2+Y=; b=nAErHDoJcDT/T0ZxgK9+w3zjRJ7Oy4hvfIPDyFa1Rs 30Oy0i8YDCteb6FoN4wPDCdVFdgCNc8LWCEF5V34bZhzS3M2rcYI4z/77GOWvp5c EcLtzw97OFO5iKcmFnG8xUd3y0r2YOkskQFX2oEF3U+/uYcGCC99aCBSytOS0J26 Q= Received: (qmail 23559 invoked by alias); 18 Dec 2016 23:40:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23543 invoked by uid 89); 18 Dec 2016 23:40:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=BAYES_50, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no version=3.3.2 spammy=H*M:home, travail, HX-Envelope-From:sk:samuel., 1-4 X-HELO: hera.aquilenet.fr Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Dec 2016 23:40:43 +0000 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CC8898F9A; Mon, 19 Dec 2016 00:40:41 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IVaViA8dxOOS; Mon, 19 Dec 2016 00:40:39 +0100 (CET) Received: from var.youpi.perso.aquilenet.fr (unknown [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 857ADAF2; Mon, 19 Dec 2016 00:40:39 +0100 (CET) Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88) (envelope-from ) id 1cIl4J-00006S-2Z; Mon, 19 Dec 2016 00:40:39 +0100 Date: Mon, 19 Dec 2016 00:40:39 +0100 From: Samuel Thibault To: Svante Signell , bug-hurd , Debian GCC Maintainers , gcc-patches Subject: Re: Hurd port for gcc go PATCH 1-4(23) Message-ID: <20161218234039.GW2895@var.home> Mail-Followup-To: Svante Signell , bug-hurd , Debian GCC Maintainers , gcc-patches References: <1480103846.24382.99.camel@gmail.com> <20161218232535.GT2895@var.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161218232535.GT2895@var.home> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Samuel Thibault, on Mon 19 Dec 2016 00:25:35 +0100, wrote: > as the attached patch does, which should really be applied or done > any other way. Or rather this patch, which makes it more like the test above. Matthias, I'm committing this to Debian's gcc-6, along the other go patches from Svante. Samuel Index: gcc/src/libgo/runtime/go-caller.c =================================================================== --- gcc/src/libgo/runtime/go-caller.c (révision 235086) +++ gcc/src/libgo/runtime/go-caller.c (copie de travail) @@ -93,7 +93,7 @@ argv[0] (http://gcc.gnu.org/PR61895). It would be nice to have a better check for whether this file is the real executable. */ - if (stat (filename, &s) < 0 || s.st_size < 1024) + if (filename != NULL && (stat (filename, &s) < 0 || s.st_size < 1024)) filename = NULL; back_state = backtrace_create_state (filename, 1, error_callback, NULL);