From patchwork Sun Aug 7 03:08:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 656438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s6QW854Qyz9t0p for ; Sun, 7 Aug 2016 13:09:16 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=RDFJRmyM; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=T6MNGYSq3pSbgtgLj Rf+KCssWW+Ma+tP9YwK9I0uQQ+6Zqjbm6+FqGIhlqCNTvObbljDHs0tYC2FXbPY8 8Gt3us2TXYKvEBRm/1G2kMqSviEK5Opc8Ko2Dh4rIuHudgTFhI/24wXIMrysoJpj Ma2CYIFjV1zsdCoJ24GxwXhlcQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=hdw/AuE7hQOIXJA2WTCqy2c 5+fs=; b=RDFJRmyM8O7FzFs+rxw8fG1sH32t1+f3+eUwMD8vDagg64C9ESU/aAm jxUEhEB/NYhryP5xS4GFV2Me7dJSBeXBAoHGqDT67KDnFGKNGXkdbNg9sG+dRzVe /nqrr81BL8pvZHnlvL3iBMXuLMp3NflOLtRBs6eIopfjQ/4lzpSY= Received: (qmail 13747 invoked by alias); 7 Aug 2016 03:09:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13737 invoked by uid 89); 7 Aug 2016 03:09:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=force_reg, H*RU:209.85.192.195, Hx-spam-relays-external:209.85.192.195, E500_CONVERT X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 07 Aug 2016 03:08:59 +0000 Received: by mail-pf0-f195.google.com with SMTP id y134so22608734pfg.3 for ; Sat, 06 Aug 2016 20:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VyrJm1wIfYxK7hweSkMJR06aMhdrtcdykJZERyNsA2k=; b=ks+qQqNR9m/VGAntT5LqbpPVldD8OheEsNh0r/kfZOtM9I8kcbE+AklINTt50iCrdr 47CDCYPu7IF8pX+wXoxbB7lBv6fFTHIWV86Ei+0z88C+Hn5y+Nm2vbI/y045TDkJupTq 0eCe7DX3C5pCA0VHcZ6DylqqCV2r+R/YrBO1LslYGjw5gyEic5rawv8h4sQvOPKC05gY 4S9jEYuBMUTWdWXtRwi/VhihpHmoxVPNa6czrIiIMUwnUpoB5Ru60NLclGHvJVW9K3aa Fck9cU92pTaHxiOh3is4IHsgT5GS6yns+poPHNA81xQVDPnNj0EmCrvnFdGDsLHfHqUx wFEw== X-Gm-Message-State: AEkoousSSi29MnzQwzVzJvbr+xZZDrOUy8zP/nONVG4PD5jJt97Qui5TpGJnpVUmig3xAQ== X-Received: by 10.98.99.67 with SMTP id x64mr150009006pfb.26.1470539337655; Sat, 06 Aug 2016 20:08:57 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-146-233.sa.bigpond.net.au. [58.160.146.233]) by smtp.gmail.com with ESMTPSA id fe8sm38180608pad.2.2016.08.06.20.08.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Aug 2016 20:08:56 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2CDABC17F7; Sun, 7 Aug 2016 12:38:52 +0930 (ACST) Date: Sun, 7 Aug 2016 12:38:52 +0930 From: Alan Modra To: Michael Meissner , gcc-patches@gcc.gnu.org Cc: Segher Boessenkool Subject: Re: [RS6000] Force source of fix_truncsi2 to reg Message-ID: <20160807030851.GS20904@bubble.grove.modra.org> References: <20160802143254.GF20904@bubble.grove.modra.org> <20160805202526.GA10210@ibm-tiger.the-meissners.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160805202526.GA10210@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes On Fri, Aug 05, 2016 at 04:25:26PM -0400, Michael Meissner wrote: > Ummm, this patch looks wrong. Because the insn uses the SFDF iterator, the > mode of operands[1] could be either SFmode or DFmode. I think it should be: > > - rtx tmp, stack; > + rtx src = force_reg (mode, operands[1]); Thanks for the correction. I'm committing this as obvious. * config/rs6000/rs6000.md (fix_truncsi2): Fix mode of reg. diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md index 45ad661..bc01dc7 100644 --- a/gcc/config/rs6000/rs6000.md +++ b/gcc/config/rs6000/rs6000.md @@ -5357,7 +5357,7 @@ { if (!) { - rtx src = force_reg (SFmode, operands[1]); + rtx src = force_reg (mode, operands[1]); if (TARGET_STFIWX) emit_insn (gen_fix_truncsi2_stfiwx (operands[0], src));